From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Zhang, Roy Fan" <roy.fan.zhang@intel.com>,
"Hunt, David" <david.hunt@intel.com>
Subject: Re: [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2
Date: Wed, 30 Mar 2016 14:15:01 +0000 [thread overview]
Message-ID: <3EB4FA525960D640B5BDFFD6A3D89126479745AA@IRSMSX108.ger.corp.intel.com> (raw)
In-Reply-To: <1519299.Ljb19TASP1@xps13>
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Wednesday, March 30, 2016 3:07 PM
> To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Singh, Jasvinder <jasvinder.singh@intel.com>; Zhang,
> Roy Fan <roy.fan.zhang@intel.com>; Hunt, David <david.hunt@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2 2/4] examples/ip_pipeline: fix build for
> x86_64 without SSE4.2
>
> 2016-03-30 13:57, Dumitrescu, Cristian:
> > I think the correct fix is:
> > #if defined(__x86_64__) && (defined(RTE_MACHINE_CPUFLAG_SSE4_2)
> || defined(RTE_MACHINE_CPUFLAG_CRC32))
> >
> > We'll test it and send a patch asap.
>
> I had prepared this patch. Please be inspired:
>
> examples/ip_pipeline: fix SSE4.2 optimization branch
>
> The branch was disabled because of a typo in the SSE4.2 flag.
> Change also the x86_64 flag to use a DPDK one.
>
> Fixes: 28377375c6c0 ("examples/ip_pipeline: fix build for x86_64 without
> SSE4.2")
>
> -#if defined(__x86_64__) && defined(RTE_CPUFLAG_SSE4_2)
> +#if defined(RTE_ARCH_X86_64) &&
> defined(RTE_MACHINE_CPUFLAG_SSE4_2)
Acked-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com>
next prev parent reply other threads:[~2016-03-30 14:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-16 6:46 [PATCH v2 0/4] fix examples build Thomas Monjalon
2016-02-16 6:46 ` [PATCH v2 1/4] examples/l3fwd: fix build without SSE4.1 Thomas Monjalon
2016-02-16 6:46 ` [PATCH v2 2/4] examples/ip_pipeline: fix build for x86_64 without SSE4.2 Thomas Monjalon
2016-03-30 13:24 ` Dumitrescu, Cristian
2016-03-30 13:58 ` Thomas Monjalon
2016-03-30 13:57 ` Dumitrescu, Cristian
2016-03-30 14:06 ` Thomas Monjalon
2016-03-30 14:15 ` Dumitrescu, Cristian [this message]
2016-03-30 15:50 ` Thomas Monjalon
2016-03-30 16:31 ` Dumitrescu, Cristian
2016-03-30 18:06 ` [PATCH] examples/ip_pipeline: fix SSE4.2 optimization branch Thomas Monjalon
2016-03-31 20:49 ` Thomas Monjalon
2016-02-16 6:46 ` [PATCH v2 3/4] examples/ethtool: fix build Thomas Monjalon
2016-02-16 6:46 ` [PATCH v2 4/4] examples: fix build dependencies Thomas Monjalon
2016-02-16 6:56 ` [PATCH v2 0/4] fix examples build Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3EB4FA525960D640B5BDFFD6A3D89126479745AA@IRSMSX108.ger.corp.intel.com \
--to=cristian.dumitrescu@intel.com \
--cc=david.hunt@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
--cc=roy.fan.zhang@intel.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.