All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Marques <pmarques@grupopie.com>
To: Linus Torvalds <torvalds@osdl.org>
Cc: James Bottomley <James.Bottomley@steeleye.com>,
	Andrew Morton <akpm@osdl.org>,
	johnstultz@us.ibm.com,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fix get_jiffies_64 to work on voyager
Date: Tue, 06 Jan 2004 19:04:15 +0000	[thread overview]
Message-ID: <3FFB06AF.6000503@grupopie.com> (raw)
In-Reply-To: Pine.LNX.4.58.0401061033490.9166@home.osdl.org

Linus Torvalds wrote:

> 
> On Tue, 6 Jan 2004, Paulo Marques wrote:
> 
>>	....
> 
> Yes, we used to do things like that at some point (and your code is 
> buggy: by leaving out the size, the "volatile" cast casts to the implicit 
> "int" size in C). 
> 


Ugh, stupid mistake. Just wrote the code to fast... :(


Anyway, thanks for your clarification. People like me that code a lot of 
user-space stuff, take a while to realize all the implications of SMP, ordering, 
preemption, etc., etc.

By the way, after double checking your logic, it looks good as long as there are 
no interrupts that take more than 3 jiffies to complete :)

-- 
Paulo Marques - www.grupopie.com

"In a world without walls and fences who needs windows and gates?"


      reply	other threads:[~2004-01-06 19:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-06 16:04 [PATCH] fix get_jiffies_64 to work on voyager James Bottomley
2004-01-06 16:19 ` Andrew Morton
2004-01-06 16:26   ` James Bottomley
2004-01-06 17:05     ` Andrew Morton
2004-01-06 18:53       ` James Bottomley
2004-01-06 16:29   ` Linus Torvalds
2004-01-06 17:05     ` Andrew Morton
2004-01-06 17:11     ` Tim Schmielau
2004-01-06 17:22       ` Andrew Morton
2004-01-06 17:37         ` Tim Schmielau
2004-01-06 18:02       ` Linus Torvalds
2004-01-06 16:30   ` Tim Schmielau
2004-01-06 16:26 ` Linus Torvalds
2004-01-06 18:29   ` Paulo Marques
2004-01-06 18:46     ` Linus Torvalds
2004-01-06 19:04       ` Paulo Marques [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3FFB06AF.6000503@grupopie.com \
    --to=pmarques@grupopie.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=akpm@osdl.org \
    --cc=johnstultz@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.