All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Ani Sinha <ani@anisinha.ca>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx
Date: Wed, 16 Sep 2020 09:41:42 +0200	[thread overview]
Message-ID: <3be8a75b-d1be-16a2-9ed4-a26674cde0e7@redhat.com> (raw)
In-Reply-To: <20200916061335.14045-11-ani@anisinha.ca>

 Hi!

On 16/09/2020 08.13, Ani Sinha wrote:
> This change adds a unit test to exercize the case when hotplug is disabled both for

exercize ==> exercise
(also in the subject, please)

[...]> diff --git a/tests/qtest/bios-tables-test.c
b/tests/qtest/bios-tables-test.c
> index 7632cfe1be..4c834474ad 100644
> --- a/tests/qtest/bios-tables-test.c
> +++ b/tests/qtest/bios-tables-test.c
> @@ -768,6 +768,21 @@ static void test_acpi_piix4_bridge_hotplug(void)
>      free_test_data(&data);
>  }
>  
> +static void test_acpi_piix4_bridge_root_hotplug(void)
> +{
> +    test_data data;
> +
> +    memset(&data, 0, sizeof(data));
> +    data.machine = MACHINE_PC;
> +    data.variant = ".hpbrroot";

You could use:

    test data = {
        .machine = MACHINE_PC;
        .variant = ".hpbrroot";
    };

... then you don't need the memset() call anymore.

  Thomas



  parent reply	other threads:[~2020-09-16  7:42 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-16  6:13 [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes Ani Sinha
2020-09-16  6:13 ` [PATCH v4 01/11] tests/acpi: document addition of table DSDT.roothp for unit testing root pci hotplug on/off Ani Sinha
2020-09-16  6:13 ` [PATCH v4 02/11] tests/acpi: add a new unit test to test hotplug off/on feature on the root pci bus Ani Sinha
2020-09-16  6:35   ` Igor Mammedov
2020-09-16  6:13 ` [PATCH v4 03/11] tests/acpi: add a new ACPI table in order to test root pci hotplug on/off Ani Sinha
2020-09-16  6:36   ` Igor Mammedov
2020-09-16  6:13 ` [PATCH v4 04/11] Fix a gap where acpi_pcihp_find_hotplug_bus() returns a non-hotpluggable bus Ani Sinha
2020-09-16  6:41   ` Igor Mammedov
2020-09-16  6:13 ` [PATCH v4 05/11] i440fx/acpi: do not add hotplug related amls for cold plugged bridges Ani Sinha
2020-09-16  6:55   ` Igor Mammedov
2020-09-16  6:13 ` [PATCH v4 06/11] tests/acpi: list added acpi table binary file for pci bridge hotplug test Ani Sinha
2020-09-16  6:13 ` [PATCH v4 07/11] tests/acpi: unit test for 'acpi-pci-hotplug-with-bridge-support' bridge flag Ani Sinha
2020-09-16  7:01   ` Igor Mammedov
2020-09-16  6:13 ` [PATCH v4 08/11] tests/acpi: add newly added acpi DSDT table blob for pci bridge hotplug flag Ani Sinha
2020-09-16  7:02   ` Igor Mammedov
2020-09-16  6:13 ` [PATCH v4 09/11] piix4: don't reserve hw resources when hotplug is off globally Ani Sinha
2020-09-16  6:13 ` [PATCH v4 10/11] tests/acpi: unit test exercizing hotplug off for pci root bus & bridge in i440fx Ani Sinha
2020-09-16  7:11   ` Igor Mammedov
2020-09-16  7:36   ` Igor Mammedov
2020-09-16  7:41   ` Thomas Huth [this message]
2020-09-16 10:57     ` Ani Sinha
2020-09-16  6:13 ` [PATCH v4 11/11] tests/acpi: add DSDT.hpbrroot DSDT table blob to test global i440fx hotplug Ani Sinha
2020-09-16  7:15 ` [PATCH v4 00/11] i440fx/acpi: addition of feature and bug fixes Igor Mammedov
2020-09-16  7:18   ` Ani Sinha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3be8a75b-d1be-16a2-9ed4-a26674cde0e7@redhat.com \
    --to=thuth@redhat.com \
    --cc=ani@anisinha.ca \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.