All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guido Kiener <Guido.Kiener@rohde-schwarz.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	dave penkler <dpenkler@gmail.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
	"qiang.zhang@windriver.com" <qiang.zhang@windriver.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	"paulmck@kernel.org" <paulmck@kernel.org>,
	USB <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] USB: usbtmc: Fix RCU stall warning
Date: Wed, 21 Jul 2021 15:24:13 +0000	[thread overview]
Message-ID: <3bef7f032d2142ddac469eef8aee0d49@rohde-schwarz.com> (raw)

> -----Original Message-----
> From: Alan Stern <stern@rowland.harvard.edu>
> Sent: Wednesday, July 21, 2021 4:22 PM
> To: dave penkler <dpenkler@gmail.com>
> Cc: Greg KH <gregkh@linuxfoundation.org>; qiang.zhang@windriver.com; Dmitry
> Vyukov <dvyukov@google.com>; paulmck@kernel.org; Kiener Guido 14DS1
> <Guido.Kiener@rohde-schwarz.com>; USB <linux-usb@vger.kernel.org>
> Subject: *EXT* Re: [PATCH] USB: usbtmc: Fix RCU stall warning
> 
> On Wed, Jul 21, 2021 at 11:44:23AM +0200, dave penkler wrote:
> > Sorry, the issue this patch is trying to fix occurs because the
> > current usbtmc driver resubmits the URB when it gets an EPROTO return.
> > The dummy usb host controller driver used in the syzbot tests keeps
> > returning the resubmitted URB with EPROTO causing a loop that starves
> > RCU. With an actual HCI driver it either recovers or returns an EPIPE.
> 
> Are you sure about that?  Have you ever observed a usbtmc device recovering and
> continuing to operate after an EPROTO error?

I can't speak for Dave and his investigations. However as you remember I did tests with
EPROTO errors, see thread: https://marc.info/?l=linux-usb&m=162163776930423&w=2
In the thread you can see the recovering.
Since no user blamed the usbtmc driver for system locks up to now, it's worth to think about
whether the problem is caused by the dummy_hcd driver.
I still have no time for further investigations and would agree to use the simple patch
to get rid of the topic for the usbtmc driver. Then the syzbot will maybe find another usb driver.

-Guido

> An EPIPE error also seems rather unlikely -- particularly if the device is not plugged
> into a high-speed hub.
> 
> Alan Stern
> 
> > In either case no loop occurs. So for my part as a user and maintainer
> > this patch is not ok.

             reply	other threads:[~2021-07-21 15:24 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-21 15:24 Guido Kiener [this message]
2021-07-21 16:17 ` [PATCH] USB: usbtmc: Fix RCU stall warning Alan Stern
  -- strict thread matches above, loose matches on Subject: below --
2021-07-22 17:33 Guido Kiener
2021-07-23  0:36 ` Zhang, Qiang
2021-07-21 17:08 Guido Kiener
2021-07-21 18:16 ` Alan Stern
2021-07-21 11:15 Guido Kiener
2021-06-29  3:32 qiang.zhang
2021-07-07  1:29 ` Zhang, Qiang
2021-07-07  5:58   ` gregkh
2021-07-21  7:08 ` Greg KH
2021-07-21  7:30   ` Zhang, Qiang
2021-07-21  7:52     ` Greg KH
2021-07-21  8:28       ` Zhang, Qiang
2021-07-21  7:41   ` dave penkler
2021-07-21  7:52     ` Greg KH
2021-07-21  9:44       ` dave penkler
2021-07-21  9:47         ` Greg KH
2021-07-21 14:22         ` Alan Stern
2021-07-21  8:34     ` Zhang, Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bef7f032d2142ddac469eef8aee0d49@rohde-schwarz.com \
    --to=guido.kiener@rohde-schwarz.com \
    --cc=dpenkler@gmail.com \
    --cc=dvyukov@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=paulmck@kernel.org \
    --cc=qiang.zhang@windriver.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.