From: Julien Grall <julien@xen.org>
To: Michal Orzel <michal.orzel@arm.com>, xen-devel@lists.xenproject.org
Cc: "Stefano Stabellini" <sstabellini@kernel.org>,
"Bertrand Marquis" <bertrand.marquis@arm.com>,
"Volodymyr Babchuk" <Volodymyr_Babchuk@epam.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"George Dunlap" <george.dunlap@citrix.com>,
"Jan Beulich" <jbeulich@suse.com>, "Wei Liu" <wl@xen.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros
Date: Fri, 8 Apr 2022 18:58:41 +0100 [thread overview]
Message-ID: <3c5a736d-3c38-a975-62d9-7c5623d89728@xen.org> (raw)
In-Reply-To: <20220405091616.200270-3-michal.orzel@arm.com>
Hi Michal,
On 05/04/2022 10:16, Michal Orzel wrote:
> #if defined(BUILD_ID)
> @@ -109,12 +104,7 @@ SECTIONS
> *(.data.schedulers)
> __end_schedulers_array = .;
>
> -#ifdef CONFIG_HYPFS
> - . = ALIGN(8);
This will be replaced with POINTER_ALIGN which is 4-byte on Arm32.
AFAICT, there are no 64-bit value used in struct param_hypfs. So it
should be fine.
That said, I think this is worth mentioning in the commit message.
The rest of this patch looks good to me.
Cheers,
--
Julien Grall
next prev parent reply other threads:[~2022-04-08 17:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-05 9:16 [PATCH v4 0/2] xen: Linker scripts synchronization Michal Orzel
2022-04-05 9:16 ` [PATCH v4 1/2] xen: Introduce a header to store common linker scripts content Michal Orzel
2022-04-05 9:16 ` [PATCH v4 2/2] xen: Populate xen.lds.h and make use of its macros Michal Orzel
2022-04-05 9:29 ` Jan Beulich
2022-04-08 17:58 ` Julien Grall [this message]
2022-04-11 6:29 ` Michal Orzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c5a736d-3c38-a975-62d9-7c5623d89728@xen.org \
--to=julien@xen.org \
--cc=Volodymyr_Babchuk@epam.com \
--cc=andrew.cooper3@citrix.com \
--cc=bertrand.marquis@arm.com \
--cc=george.dunlap@citrix.com \
--cc=jbeulich@suse.com \
--cc=michal.orzel@arm.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.