Re: [PATCH 2/4] scsi: libsas: Add sas_execute_internal_abort_dev()

From: Hannes Reinecke <hare@suse.de>
To: John Garry <john.garry@huawei.com>,
	jejb@linux.ibm.com, martin.petersen@oracle.com,
	jinpu.wang@cloud.ionos.com, damien.lemoal@opensource.wdc.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	Ajish.Koshy@microchip.com, linuxarm@huawei.com,
	Viswas.G@microchip.com, hch@lst.de, liuqi115@huawei.com,
	chenxiang66@hisilicon.com
Subject: Re: [PATCH 2/4] scsi: libsas: Add sas_execute_internal_abort_dev()
Date: Wed, 20 Apr 2022 14:22:40 +0200	[thread overview]
Message-ID: <3e9c9954-8b0d-6bf5-3321-4deeb4ca77bf@suse.de> (raw)
In-Reply-To: <1646309930-138960-3-git-send-email-john.garry@huawei.com>

On 3/3/22 13:18, John Garry wrote:
> Add support for a "device" variant of internal abort, which will abort all
> pending IOs for a specific device.
> 
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---
>   drivers/scsi/libsas/sas_scsi_host.c | 8 ++++++++
>   include/scsi/libsas.h               | 8 ++++++++
>   2 files changed, 16 insertions(+)
> 
> diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c
> index 0d05826e6e8c..8d6c83d15148 100644
> --- a/drivers/scsi/libsas/sas_scsi_host.c
> +++ b/drivers/scsi/libsas/sas_scsi_host.c
> @@ -995,6 +995,14 @@ int sas_execute_internal_abort_single(struct domain_device *device, u16 tag,
>   }
>   EXPORT_SYMBOL_GPL(sas_execute_internal_abort_single);
>   
> +int sas_execute_internal_abort_dev(struct domain_device *device,
> +				   unsigned int qid, void *data)
> +{
> +	return sas_execute_internal_abort(device, SAS_INTERNAL_ABORT_DEV,
> +					  SCSI_NO_TAG, qid, data);
> +}
> +EXPORT_SYMBOL_GPL(sas_execute_internal_abort_dev);
> +
>   int sas_execute_tmf(struct domain_device *device, void *parameter,
>   		    int para_len, int force_phy_id,
>   		    struct sas_tmf_task *tmf)
> diff --git a/include/scsi/libsas.h b/include/scsi/libsas.h
> index 2d30d57916e5..71f632b2d2bd 100644
> --- a/include/scsi/libsas.h
> +++ b/include/scsi/libsas.h
> @@ -560,6 +560,7 @@ struct sas_ata_task {
>   /* LLDDs rely on these values */
>   enum sas_internal_abort {
>   	SAS_INTERNAL_ABORT_SINGLE	= 0,
> +	SAS_INTERNAL_ABORT_DEV		= 1,
>   };
>   
>   struct sas_internal_abort_task {
> @@ -641,6 +642,11 @@ extern struct sas_task *sas_alloc_task(gfp_t flags);
>   extern struct sas_task *sas_alloc_slow_task(gfp_t flags);
>   extern void sas_free_task(struct sas_task *task);
>   
> +static inline bool sas_is_internal_abort(struct sas_task *task)
> +{
> +	return task->task_proto == SAS_PROTOCOL_INTERNAL_ABORT;
> +}
> +
>   struct sas_domain_function_template {
>   	/* The class calls these to notify the LLDD of an event. */
>   	void (*lldd_port_formed)(struct asd_sas_phy *);
> @@ -697,6 +703,8 @@ extern int sas_bios_param(struct scsi_device *, struct block_device *,
>   int sas_execute_internal_abort_single(struct domain_device *device,
>   				      u16 tag, unsigned int qid,
>   				      void *data);
> +int sas_execute_internal_abort_dev(struct domain_device *device,
> +				   unsigned int qid, void *data);
>   extern struct scsi_transport_template *
>   sas_domain_attach_transport(struct sas_domain_function_template *);
>   extern struct device_attribute dev_attr_phy_event_threshold;

Same comment as in the previous patch: Please use the existing TMF_XXX 
values.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@suse.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer