All of lore.kernel.org
 help / color / mirror / Atom feed
From: Farhan Ali <alifm@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: cohuck@redhat.com, borntraeger@de.ibm.com,
	pasic@linux.vnet.ibm.com, farman@linux.vnet.ibm.com,
	walling@linux.vnet.ibm.com
Subject: [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1
Date: Fri, 25 Aug 2017 09:24:46 -0400	[thread overview]
Message-ID: <3ed8b810b6592daee6a775037ce21f850e40647d.1503667215.git.alifm@linux.vnet.ibm.com> (raw)
In-Reply-To: <cover.1503667215.git.alifm@linux.vnet.ibm.com>

The commit 198c0d1f9df8c4 s390x/css: check ccw address validity
exposes an alignment issue in ccw bios.

According to PoP the CCW must be doubleword aligned. Let's fix
this in the bios.

Cc: qemu-stable@nongnu.org
Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Reviewed-by: Eric Farman <farman@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
 pc-bios/s390-ccw/cio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/pc-bios/s390-ccw/cio.h b/pc-bios/s390-ccw/cio.h
index f5b4549..55eaeee 100644
--- a/pc-bios/s390-ccw/cio.h
+++ b/pc-bios/s390-ccw/cio.h
@@ -133,7 +133,7 @@ struct ccw1 {
     __u8 flags;
     __u16 count;
     __u32 cda;
-} __attribute__ ((packed));
+} __attribute__ ((packed, aligned(8)));
 
 #define CCW_FLAG_DC              0x80
 #define CCW_FLAG_CC              0x40
-- 
1.9.1

       reply	other threads:[~2017-08-25 13:25 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1503667215.git.alifm@linux.vnet.ibm.com>
2017-08-25 13:24 ` Farhan Ali [this message]
2017-08-25 13:55   ` [Qemu-devel] [PATCH] s390-ccw: Fix alignment for CCW1 no-reply
2017-08-25 14:04   ` Cornelia Huck
2017-08-25 15:05     ` Farhan Ali
2017-08-28  8:22       ` Cornelia Huck
2017-08-28 12:56         ` Farhan Ali
2017-08-28 13:06           ` Cornelia Huck
2017-08-28 13:18             ` Farhan Ali
2017-08-28 13:24               ` Christian Borntraeger
2017-08-28 13:52                 ` Farhan Ali
2017-08-28 14:05                   ` Cornelia Huck
2017-08-28 14:15                     ` Farhan Ali
2017-08-28 14:19                       ` Halil Pasic
2017-08-28 14:28                         ` Farhan Ali
2017-08-29 12:04                           ` Cornelia Huck
2017-08-29 12:39                             ` Farhan Ali
2017-08-29 12:45                               ` Cornelia Huck
2017-08-29 18:45                                 ` Eric Farman
2017-08-30  7:27                                   ` Cornelia Huck
2017-08-28 15:04                       ` Philippe Mathieu-Daudé
2017-08-28 18:47                         ` Farhan Ali

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3ed8b810b6592daee6a775037ce21f850e40647d.1503667215.git.alifm@linux.vnet.ibm.com \
    --to=alifm@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=farman@linux.vnet.ibm.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=walling@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.