From: Pkshih <pkshih@realtek.com>
To: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"kuba@kernel.org" <kuba@kernel.org>,
"colin.king@canonical.com" <colin.king@canonical.com>,
"kvalo@codeaurora.org" <kvalo@codeaurora.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] rtlwifi: rtl8192de: make arrays static const, makes object smaller
Date: Mon, 2 Aug 2021 08:04:39 +0000 [thread overview]
Message-ID: <3f972eb809700581ff912d3dabd237bcb9708776.camel@realtek.com> (raw)
In-Reply-To: <20210731124044.101927-2-colin.king@canonical.com>
On Sat, 2021-07-31 at 13:40 +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> Don't populate arrays the stack but instead make them static const
> Makes the object code smaller by 852 bytes.
>
> Before:
> text data bss dec hex filename
> 128211 44250 1024 173485 2a5ad ../realtek/rtlwifi/rt
> l8192de/phy.o
>
> After:
> text data bss dec hex filename
> 127199 44410 1024 172633 2a259 ../realtek/rtlwifi/rt
> l8192de/phy.o
>
> (gcc version 10.2.0)
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> index 4eaa40d73baf..79956254f798 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/phy.c
> @@ -1354,7 +1354,7 @@ static void
> _rtl92d_phy_switch_rf_setting(struct ieee80211_hw *hw, u8 channel)
>
> u8 rtl92d_get_rightchnlplace_for_iqk(u8 chnl)
> {
> - u8 channel_all[59] = {
> + static const u8 channel_all[59] = {
> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
> 36, 38, 40, 42, 44, 46, 48, 50, 52, 54, 56, 58,
> 60, 62, 64, 100, 102, 104, 106, 108, 110, 112,
> @@ -3220,7 +3220,7 @@ void rtl92d_phy_config_macphymode_info(struct
> ieee80211_hw *hw)
> u8 rtl92d_get_chnlgroup_fromarray(u8 chnl)
> {
> u8 group;
> - u8 channel_info[59] = {
> + static const u8 channel_info[59] = {
> 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14,
> 36, 38, 40, 42, 44, 46, 48, 50, 52, 54, 56,
> 58, 60, 62, 64, 100, 102, 104, 106, 108,
> --
> 2.31.1
>
> ------Please consider the environment before printing this e-mail.
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2021-08-02 8:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-31 12:40 [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations Colin King
2021-07-31 12:40 ` [PATCH 2/2] rtlwifi: rtl8192de: make arrays static const, makes object smaller Colin King
2021-08-02 8:04 ` Pkshih [this message]
2021-08-02 8:35 ` Joe Perches
2021-08-03 14:03 ` Colin Ian King
2021-08-02 8:04 ` [PATCH 1/2] rtlwifi: rtl8192de: Remove redundant variable initializations Pkshih
2021-08-02 8:35 ` Joe Perches
2021-08-03 14:03 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3f972eb809700581ff912d3dabd237bcb9708776.camel@realtek.com \
--to=pkshih@realtek.com \
--cc=colin.king@canonical.com \
--cc=davem@davemloft.net \
--cc=kernel-janitors@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.