From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42DEDC4363D for ; Sun, 4 Oct 2020 18:22:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 019CB20663 for ; Sun, 4 Oct 2020 18:22:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GdVCYPMM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726345AbgJDSWi (ORCPT ); Sun, 4 Oct 2020 14:22:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:52182 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726289AbgJDSWh (ORCPT ); Sun, 4 Oct 2020 14:22:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601835756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+z+3QnpezIdPFc/Jyz8I8pdkhO58upU4jK8SfFO6pE=; b=GdVCYPMMxRVtm+Dyt8bSQyyS8bUkDkgctcEDPj24CqH96Vf514PzK2LCk+bh822E+4O2/G pmvzku7ISnCO7LrlU1nMfrd+x/ulqLWBdN4j/2y289Iecs7Dub7jOs+zX4kZwwm+oX+iy/ HR/NU50pzpD67aNfCTE3GaxFTQOy5Fw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-574-KJu3lBfhMdicm4peOabUYg-1; Sun, 04 Oct 2020 14:22:34 -0400 X-MC-Unique: KJu3lBfhMdicm4peOabUYg-1 Received: by mail-qv1-f69.google.com with SMTP id j4so380787qvn.0 for ; Sun, 04 Oct 2020 11:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=E+z+3QnpezIdPFc/Jyz8I8pdkhO58upU4jK8SfFO6pE=; b=bYRZhDaU9bvDzOiVGNx9exprb692uk+CJS/QW2nduPzHr38ceEXbbPD1gpPT787zOC 52M4fBEsL+R7alIF9FA25z6jXVAq5DMvQ/YVEQLQJm4n9baQPwnJXTwrpUtFTUaxuBv5 SVFDOcQ4VS/MOVyNItboo4ihIEfyLzgzo1Pge9NiRk9pTZc98H9B+MO6lZr4aylZUutf Pyn99bY/3evQqAQxPBCSD0CsmHvCVUDOzMdYIAZ/Pyy8/JG9KH8+JWgzhjoDTGE8XjCv oRlMX9+cKEVsxsuG3mZRXw5b7gD7sq6Q4Ltc1GigOxCmH3mwI37OXQgdJaI0y0ZM9pKx Gtdw== X-Gm-Message-State: AOAM533WI5cQIwbEoilysWvWOjn9jJ1WASf15SVOOoVsNm8ggUaq0STt V2lGKEpG486dZpnBL/z0HHixY8GpW6I5anwVzRnuvOHS8Vw6rzukJjkRzh3J4qdu2UPi+Jy7+uo a13PWzBbdgErjDEIo/DopWwE5 X-Received: by 2002:a37:9e8e:: with SMTP id h136mr561992qke.205.1601835754309; Sun, 04 Oct 2020 11:22:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+HbQ8Td/estDK0M/QzXF2k7W6Atz9B+/Jr3kBLoEy9X4bEQfTw3kyfvz/jNcI428QW0FZNA== X-Received: by 2002:a37:9e8e:: with SMTP id h136mr561979qke.205.1601835754127; Sun, 04 Oct 2020 11:22:34 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id p187sm5625268qkd.129.2020.10.04.11.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2020 11:22:33 -0700 (PDT) Subject: Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration To: Moritz Fischer , linux-fpga@vger.kernel.org Cc: hao.wu@intel.com, michal.simek@xilinx.com, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, russell.h.weight@intel.com, matthew.gerlach@intel.com References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-4-mdf@kernel.org> From: Tom Rix Message-ID: <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> Date: Sun, 4 Oct 2020 11:22:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201004051423.75879-4-mdf@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/3/20 10:14 PM, Moritz Fischer wrote: > Simplify registration using new devm_fpga_mgr_register() API. > > Signed-off-by: Moritz Fischer > --- > drivers/fpga/dfl-fme-mgr.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > index b3f7eee3c93f..3fc2be87d059 100644 > --- a/drivers/fpga/dfl-fme-mgr.c > +++ b/drivers/fpga/dfl-fme-mgr.c > @@ -316,16 +316,7 @@ static int fme_mgr_probe(struct platform_device *pdev) > mgr->compat_id = compat_id; > platform_set_drvdata(pdev, mgr); Is this call is still needed ? Tom > > - return fpga_mgr_register(mgr); > -} > - > -static int fme_mgr_remove(struct platform_device *pdev) > -{ > - struct fpga_manager *mgr = platform_get_drvdata(pdev); > - > - fpga_mgr_unregister(mgr); > - > - return 0; > + return devm_fpga_mgr_register(dev, mgr); > } > > static struct platform_driver fme_mgr_driver = { > @@ -333,7 +324,6 @@ static struct platform_driver fme_mgr_driver = { > .name = DFL_FPGA_FME_MGR, > }, > .probe = fme_mgr_probe, > - .remove = fme_mgr_remove, > }; > > module_platform_driver(fme_mgr_driver); From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D0D2C4363C for ; Sun, 4 Oct 2020 18:24:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A0EA206B6 for ; Sun, 4 Oct 2020 18:24:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="s7DlcYUp"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GdVCYPMM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A0EA206B6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+iSNU9nFD6Pzik5p+sSJ9buDe5aItcN39/7NOzbLlCc=; b=s7DlcYUpKRMIMcMJoHAyjO6cH nPH+D+Fynczq80U91OrBNGj0NsZW2ll93bWy0MbLeBDwKf5i9iPKK+OuHAFoGpXt/fSoG4cy8nGs2 tfiULUo0QOwPg0MM7KYjQ1+7UykUo2Tl8RH3pyzLae346mbvZ+IwpkQzo8zQ4WaN48rv+25VREtgB r+me2VE+5vklVGltPPL/v60ECV/ndJxZ5DFLfzh4Oz/DFkCOmQ/lEDoQIH3/LNSw4dfqIo1KMo+dy VTrbetJc12iTl+0kAbEBEz66D3p6YrROY0QM1GwM1pWfh7vIO2hQDiFScojcE3f2X+A8m3MvwJeZl f8MV13rqA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kP8ee-0008UD-Kf; Sun, 04 Oct 2020 18:22:40 +0000 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kP8ec-0008To-1D for linux-arm-kernel@lists.infradead.org; Sun, 04 Oct 2020 18:22:38 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601835756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E+z+3QnpezIdPFc/Jyz8I8pdkhO58upU4jK8SfFO6pE=; b=GdVCYPMMxRVtm+Dyt8bSQyyS8bUkDkgctcEDPj24CqH96Vf514PzK2LCk+bh822E+4O2/G pmvzku7ISnCO7LrlU1nMfrd+x/ulqLWBdN4j/2y289Iecs7Dub7jOs+zX4kZwwm+oX+iy/ HR/NU50pzpD67aNfCTE3GaxFTQOy5Fw= Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-277-HBGx-hDCOa6SieIgoGHpWw-1; Sun, 04 Oct 2020 14:22:34 -0400 X-MC-Unique: HBGx-hDCOa6SieIgoGHpWw-1 Received: by mail-qt1-f199.google.com with SMTP id h31so5010913qtd.14 for ; Sun, 04 Oct 2020 11:22:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=E+z+3QnpezIdPFc/Jyz8I8pdkhO58upU4jK8SfFO6pE=; b=k0Irt2nwd+X+whIs06WXBdkL4gUIi7pDthS05jwi9zPZAEq6vKiGJ44f/A6ZCnGmkR D0tLTbPZlcDQs+uIYlhbYGXsOt87X94HKTkHQRoxYBqaG1lrNocMNN0hNWzolzwansun 1+4zCUQO+0F447Tgo93GNzSddyIEVe2UcwLKo6qW8jziDmqWgP6QzRAVConjbyWJpnyq 1YLI2LD9uInGGry/pqmhRTV26XCnfdEaM+6mP7H8CE6nVbwJJaQIy8zApJF2YqZN+17t V/u/ePjEGDRt4UOjfq1aDjLjwgqS7LruZQxQEvc5+U2U0AXgq4TdrWTnH0TIbXTMMLBC 7HMw== X-Gm-Message-State: AOAM533Ydqk45NzyOLjOaDWiJxBQzLMkDsXQ/DKN40FvDDkLiSXOxzsH 8pGb2kT0kfVSW/CrWyFK1ZH5wFLiQAxMi/93fmchPgu+nzj5e4WcIgBnDuMz0ByrSvQ/zxVtTaG 7yT7N1umwQ9eL7hEPSt+TJOnFR+KeiRuxINc= X-Received: by 2002:a37:9e8e:: with SMTP id h136mr561996qke.205.1601835754310; Sun, 04 Oct 2020 11:22:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy+HbQ8Td/estDK0M/QzXF2k7W6Atz9B+/Jr3kBLoEy9X4bEQfTw3kyfvz/jNcI428QW0FZNA== X-Received: by 2002:a37:9e8e:: with SMTP id h136mr561979qke.205.1601835754127; Sun, 04 Oct 2020 11:22:34 -0700 (PDT) Received: from trix.remote.csb (075-142-250-213.res.spectrum.com. [75.142.250.213]) by smtp.gmail.com with ESMTPSA id p187sm5625268qkd.129.2020.10.04.11.22.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 04 Oct 2020 11:22:33 -0700 (PDT) Subject: Re: [PATCH 03/10] fpga: fpga-mgr: dfl-fme-mgr: Simplify registration To: Moritz Fischer , linux-fpga@vger.kernel.org References: <20201004051423.75879-1-mdf@kernel.org> <20201004051423.75879-4-mdf@kernel.org> From: Tom Rix Message-ID: <408267d9-1026-1a80-56c9-3a8beaaa2b82@redhat.com> Date: Sun, 4 Oct 2020 11:22:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20201004051423.75879-4-mdf@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=trix@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201004_142238_118277_754C6F25 X-CRM114-Status: GOOD ( 17.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: russell.h.weight@intel.com, linux-kernel@vger.kernel.org, matthew.gerlach@intel.com, michal.simek@xilinx.com, linux-arm-kernel@lists.infradead.org, hao.wu@intel.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/3/20 10:14 PM, Moritz Fischer wrote: > Simplify registration using new devm_fpga_mgr_register() API. > > Signed-off-by: Moritz Fischer > --- > drivers/fpga/dfl-fme-mgr.c | 12 +----------- > 1 file changed, 1 insertion(+), 11 deletions(-) > > diff --git a/drivers/fpga/dfl-fme-mgr.c b/drivers/fpga/dfl-fme-mgr.c > index b3f7eee3c93f..3fc2be87d059 100644 > --- a/drivers/fpga/dfl-fme-mgr.c > +++ b/drivers/fpga/dfl-fme-mgr.c > @@ -316,16 +316,7 @@ static int fme_mgr_probe(struct platform_device *pdev) > mgr->compat_id = compat_id; > platform_set_drvdata(pdev, mgr); Is this call is still needed ? Tom > > - return fpga_mgr_register(mgr); > -} > - > -static int fme_mgr_remove(struct platform_device *pdev) > -{ > - struct fpga_manager *mgr = platform_get_drvdata(pdev); > - > - fpga_mgr_unregister(mgr); > - > - return 0; > + return devm_fpga_mgr_register(dev, mgr); > } > > static struct platform_driver fme_mgr_driver = { > @@ -333,7 +324,6 @@ static struct platform_driver fme_mgr_driver = { > .name = DFL_FPGA_FME_MGR, > }, > .probe = fme_mgr_probe, > - .remove = fme_mgr_remove, > }; > > module_platform_driver(fme_mgr_driver); _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel