Re: [PATCH 1/2] btrfs-progs: fi show: Print missing device for a mounted file system

[Goffredo Baroncelli <kreijack@libero.it>]

On 9/6/21 6:47 PM, g.btrfs@cobb.uk.net wrote:
> 
> On 02/09/2021 13:17, Qu Wenruo wrote:
>>
[...]
> I realise this comment might be too late so feel free to ignore it if
> so. Could this path name potentially conflict with a (new) device using
> the same name? For example, could someone have created a new /dev/loop1?
> Or could a USB disk /dev/sdf1 (say) have been removed and a different
> disk inserted and acquired the /dev/sdf1 name? Or would that be
> prevented in the case where "the device's record was still in the
> fs_devices"?
> 
> If so, I think this could be very confusing to the user trying to work
> out what has happened. Maybe the output needs to change to something like:
> 
> devid    2 size 0 used 0 last seen as /dev/loop1 ***MISSING***
> 
> "last seen as" could just be "previously". Or, to make it even clearer
> that this is just a hint to help the user understand which device is
> missing, maybe something like "(last mounted as /dev/loop1)".
> 


My 2¢:

   Label: none  uuid: 4a85a40b-9b79-4bde-8e52-c65a550a176b
	  Total devices 2 FS bytes used 128.00KiB
   	  devid    1 size 5.00GiB used 1.26GiB path /dev/loop0
	  devid    2 size 0 used 0 ***MISSING*** (last seen as /dev/loop1)

I suggest to swap MISSING and 'last seen as...' part, because I think that the most
important part of the message is MISSING.


> Graham
> 


-- 
gpg @keyserver.linux.it: Goffredo Baroncelli <kreijackATinwind.it>
Key fingerprint BBF5 1610 0B64 DAC6 5F7D  17B2 0EDA 9B37 8B82 E0B5