From: Andrew Cooper <andrew.cooper3@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH 5/7] x86emul: don't special case fetching unsigned 8-bit immediates
Date: Fri, 12 Aug 2016 12:47:21 +0100 [thread overview]
Message-ID: <42f30860-f420-bdc1-4eb8-73a53908a394@citrix.com> (raw)
In-Reply-To: <57ADC622020000780010565E@prv-mh.provo.novell.com>
On 12/08/16 11:50, Jan Beulich wrote:
>>>> On 11.08.16 at 19:38, <andrew.cooper3@citrix.com> wrote:
>> On 11/08/16 17:44, Jan Beulich wrote:
>>>>>> On 11.08.16 at 18:32, <andrew.cooper3@citrix.com> wrote:
>>>> On 11/08/16 13:06, Jan Beulich wrote:
>>>>> @@ -2893,7 +2894,6 @@ x86_emulate(
>>>>> goto swint;
>>>>>
>>>>> case 0xcd: /* int imm8 */
>>>>> - src.val = insn_fetch_type(uint8_t);
>>>>> swint_type = x86_swint_int;
>>>>> swint:
>>>>> rc = inject_swint(swint_type, src.val,
>>>> I would be tempted to and an explicit (uint8_t) here, so that injection
>>>> doesn't break if the prototype of inject_swint() changes.
>>> I guess I'll leave it that way, for two reasons:
>>> - One shouldn't change prototypes without checking whether callers
>>> cope.
>> Indeed, but that doesn't alter the fact that you, I, and others we have
>> reviewed code from have managed to do precisely this, and break things.
> Well, okay, will do that then.
>
>>> - Here you basically suggest the opposite of what you wish done to
>>> the earlier patch for the jmp_rel() invocations.
>> jmp_rel() is a macro not a function, but in hindsight, I rescind that
>> request.
> As that was the only change request to that other patch, may I
> translate that to an ack / R-b for it then?
Yes. Sorry for the confusion.
~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-08-12 11:47 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-11 11:53 [PATCH 0/7] x86emul: misc small adjustments Jan Beulich
2016-08-11 12:03 ` [PATCH 1/7] x86emul: don't special case fetching the immediate of PUSH Jan Beulich
2016-08-11 12:58 ` Andrew Cooper
2016-08-11 13:26 ` Jan Beulich
2016-08-11 17:33 ` Andrew Cooper
2016-08-11 12:04 ` [PATCH 2/7] x86emul: don't special case fetching immediates of near and short branches Jan Beulich
2016-08-11 13:19 ` Andrew Cooper
2016-08-11 13:27 ` Jan Beulich
2016-08-11 12:04 ` [PATCH 3/7] x86emul: all push flavors are data moves Jan Beulich
2016-08-11 13:40 ` Andrew Cooper
2016-08-11 12:05 ` [PATCH 4/7] x86emul: fold SrcImmByte fetching Jan Beulich
2016-08-11 13:41 ` Andrew Cooper
2016-08-11 14:09 ` Jan Beulich
2016-08-11 15:06 ` Andrew Cooper
2016-08-11 12:06 ` [PATCH 5/7] x86emul: don't special case fetching unsigned 8-bit immediates Jan Beulich
2016-08-11 16:32 ` Andrew Cooper
2016-08-11 16:44 ` Jan Beulich
2016-08-11 17:38 ` Andrew Cooper
2016-08-12 10:50 ` Jan Beulich
2016-08-12 11:47 ` Andrew Cooper [this message]
2016-08-11 12:06 ` [PATCH 6/7] x86emul: use DstEax where possible Jan Beulich
2016-08-11 16:41 ` Andrew Cooper
2016-08-11 12:07 ` [PATCH 7/7] x86emul: introduce SrcImm16 Jan Beulich
2016-08-11 17:23 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=42f30860-f420-bdc1-4eb8-73a53908a394@citrix.com \
--to=andrew.cooper3@citrix.com \
--cc=JBeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.