From: Mark Salyzyn <mark_salyzyn@xyratex.com>
To: Jack Wang <jack_wang@usish.com>
Cc: "Mark Salyzyn" <mark_salyzyn@xyratex.com>,
linux-scsi@vger.kernel.org,
"'James Bottomley'" <JBottomley@parallels.com>,
'lindar_liu' <lindar_liu@usish.com>, '于爱华' <crystal_yu@usish.com>,
'john_gong' <john_gong@usish.com>
Subject: Re: RE [PATCH] pm8001: support HDA (flashless) mode (take 2)
Date: Thu, 3 May 2012 13:18:08 -0400 [thread overview]
Message-ID: <4300E2A0-D9C8-44AB-B0F0-CD1945A6D2E6@xyratex.com> (raw)
In-Reply-To: <2275E35DFBB74B10B6049A728D6F46E3@usish.com.cn>
I had viewed the hot-plug changes as separate (I see now that was a bogus distinction), I will merge them in.
Yes, the check_fw_ready is not needed, but was left in as an attempt to not touch the 'good path' for the other modes, I saw it as it could not hurt. I will test without it, and ensure operation in both our upstream code (?) and the kernel.org patch to be 100% sure. I was admittedly paranoid about removing that one. I had been experimenting and thinking about this one ever since Take-2 left the gate and am not yet satisfied.
I appreciate the comments, a sign of a deep dive into this one! Thanks!
Take-3 will arrive after testing, I will send you a PM preview to confirm ...
Sincerely -- Mark Salyzyn
On May 2, 2012, at 8:35 PM, Jack Wang wrote:
> Hi Mark,
>
> I found other issue in this patch need to be addressed. when HDA mode is
> enable, we need also change the soft reset signature to HDA signature in
> pci_remove/suspend/resume function.
>
> and in pm8001_chip_init, check fw ready is not need for HDA mode.
>
>
> Best regards
>
> Jack
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-05-03 17:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-27 17:10 [PATCH] pm8001: support HDA (flashless) mode Mark Salyzyn
2012-04-28 1:06 ` Jack Wang
2012-04-30 14:00 ` Mark Salyzyn
2012-04-28 4:44 ` Re " Jack Wang
2012-04-30 13:43 ` Mark Salyzyn
2012-04-28 6:07 ` Jack Wang
2012-04-30 13:49 ` Mark Salyzyn
2012-04-30 16:56 ` Mark Salyzyn
2012-05-01 1:10 ` jack_wang
2012-05-01 12:45 ` [PATCH] pm8001: support HDA (flashless) mode (take 2) Mark Salyzyn
2012-05-03 0:35 ` RE " Jack Wang
2012-05-03 17:18 ` Mark Salyzyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4300E2A0-D9C8-44AB-B0F0-CD1945A6D2E6@xyratex.com \
--to=mark_salyzyn@xyratex.com \
--cc=JBottomley@parallels.com \
--cc=crystal_yu@usish.com \
--cc=jack_wang@usish.com \
--cc=john_gong@usish.com \
--cc=lindar_liu@usish.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.