From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] ARM: sirf: add two debug ports for CSRatlas7 SoC
Date: Wed, 31 Dec 2014 16:31:05 +0100 [thread overview]
Message-ID: <43053389.8mSSmmg5HD@wuerfel> (raw)
In-Reply-To: <CAGsJ_4wUO6rOW4ZyciXkdKtZjkbdHyo=je7_20B5kumKnu8m9A@mail.gmail.com>
On Wednesday 31 December 2014 23:05:44 Barry Song wrote:
> 2014-12-31 6:35 GMT+08:00 Arnd Bergmann <arnd@arndb.de>:
> > On Thursday 25 December 2014 16:34:17 Barry Song wrote:
> >> #if defined(CONFIG_DEBUG_SIRFPRIMA2_UART1)
> >> -#define SIRFSOC_UART1_PA_BASE 0xb0060000
> >> +#define SIRF_LLUART_PA_BASE 0xb0060000
> >> #elif defined(CONFIG_DEBUG_SIRFMARCO_UART1)
> >> -#define SIRFSOC_UART1_PA_BASE 0xcc060000
> >> +#define SIRF_LLUART_PA_BASE 0xcc060000
> >> +#elif defined(CONFIG_DEBUG_SIRFATLAS7_UART1)
> >> +#define SIRF_LLUART_PA_BASE 0x18020000
> >> +#elif defined(CONFIG_DEBUG_SIRFATLAS7_UART0)
> >> +#define SIRF_LLUART_PA_BASE 0x18010000
> >> #else
> >> -#define SIRFSOC_UART1_PA_BASE 0
> >> +#define SIRF_LLUART_PA_BASE 0
> >> #endif
> >
> > I think it would be nicer to use DEBUG_UART_PHYS/DEBUG_UART_VIRT here.
>
> yes if it is more general name for all. my second feeling is that does
> this conflict CSR namespace stuff into high-level and common namespace
> things?
I think my comment was misleading. What I meant was to use
CONFIG_DEBUG_UART_PHYS from arch/arm/Kconfig.debug the same way
we do for the 8250 and pl011 compatible uarts.
Arnd
next prev parent reply other threads:[~2014-12-31 15:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-25 8:34 [PATCH 0/4] ARM: add basic CSR atlas7 Auto SoC support Barry Song
2014-12-25 8:34 ` [PATCH 1/4] ARM: sirf: add two debug ports for CSRatlas7 SoC Barry Song
2014-12-30 22:35 ` Arnd Bergmann
2014-12-31 15:05 ` Barry Song
2014-12-31 15:31 ` Arnd Bergmann [this message]
2015-01-02 7:51 ` Barry Song
2015-01-02 8:59 ` Arnd Bergmann
2014-12-25 8:34 ` [PATCH 2/4] ARM: sirf: add atlas7 machine support Barry Song
2014-12-30 22:34 ` Arnd Bergmann
2014-12-31 14:50 ` Barry Song
2015-01-02 9:00 ` Arnd Bergmann
2015-01-04 7:23 ` Barry Song
2014-12-25 8:34 ` [PATCH 3/4] ARM: dts: add init dts file for CSR atlas7 SoC Barry Song
2014-12-25 8:34 ` [PATCH 4/4] ARM: sirf: bring up SMP in " Barry Song
2014-12-30 22:38 ` Arnd Bergmann
2014-12-31 14:52 ` Barry Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43053389.8mSSmmg5HD@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.