From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Chaitanya Kulkarni <chaitanyak@nvidia.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@kernel.dk" <axboe@kernel.dk>,
Chaitanya Kulkarni <kch@nvidia.com>
Subject: Re: [PATCH 7/8] loop: remove extra variable in lo_req_flush
Date: Tue, 21 Sep 2021 13:37:20 +0000 [thread overview]
Message-ID: <433B1173-C70F-48EB-97D3-2B8946CE4B22@oracle.com> (raw)
In-Reply-To: <20210921092123.13632-8-chaitanyak@nvidia.com>
> On Sep 21, 2021, at 4:21 AM, Chaitanya Kulkarni <chaitanyak@nvidia.com> wrote:
>
> From: Chaitanya Kulkarni <kch@nvidia.com>
>
> The local variable file is used to pass it to the vfs_fsync(). We can
> get away with using lo->lo_backing_file instead of storing in a local
> variable which is not used anywhere else.
>
> No functional change in this patch.
>
> Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
> ---
> drivers/block/loop.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index 51c42788731a..6478d3b0dd2a 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -498,8 +498,7 @@ static int lo_fallocate(struct loop_device *lo, struct request *rq, loff_t pos,
>
> static int lo_req_flush(struct loop_device *lo, struct request *rq)
> {
> - struct file *file = lo->lo_backing_file;
> - int ret = vfs_fsync(file, 0);
> + int ret = vfs_fsync(lo->lo_backing_file, 0);
> if (unlikely(ret && ret != -EINVAL))
> ret = -EIO;
>
> --
> 2.29.0
>
Looks Good.
Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>
--
Himanshu Madhani Oracle Linux Engineering
next prev parent reply other threads:[~2021-09-21 13:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-21 9:21 [PATCH 0/8] loop: small clenaup Chaitanya Kulkarni
2021-09-21 9:21 ` [PATCH 1/8] loop: use sysfs_emit() in the sysfs offset show Chaitanya Kulkarni
2021-09-21 13:33 ` Himanshu Madhani
2021-09-21 9:21 ` [PATCH 2/8] loop: use sysfs_emit() in the sysfs sizelimit show Chaitanya Kulkarni
2021-09-21 13:35 ` Himanshu Madhani
2021-09-21 9:21 ` [PATCH 3/8] loop: use sysfs_emit() in the sysfs autoclear show Chaitanya Kulkarni
2021-09-21 13:35 ` Himanshu Madhani
2021-09-21 9:21 ` [PATCH 4/8] loop: use sysfs_emit() in the sysfs partscan show Chaitanya Kulkarni
2021-09-21 13:35 ` Himanshu Madhani
2021-09-21 9:21 ` [PATCH 5/8] loop: use sysfs_emit() in the sysfs dio show Chaitanya Kulkarni
2021-09-21 13:36 ` Himanshu Madhani
2021-09-21 9:21 ` [PATCH 6/8] loop: remove extra variable in lo_fallocate() Chaitanya Kulkarni
2021-09-21 13:36 ` Himanshu Madhani
2021-09-21 9:21 ` [PATCH 7/8] loop: remove extra variable in lo_req_flush Chaitanya Kulkarni
2021-09-21 13:37 ` Himanshu Madhani [this message]
2021-09-21 9:21 ` [PATCH 8/8] loop: allow user to set the queue depth Chaitanya Kulkarni
2021-09-21 13:38 ` Himanshu Madhani
2022-02-14 10:01 [PATCH 0/8] loop: cleanup and few improvements Chaitanya Kulkarni
2022-02-14 10:01 ` [PATCH 7/8] loop: remove extra variable in lo_req_flush Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=433B1173-C70F-48EB-97D3-2B8946CE4B22@oracle.com \
--to=himanshu.madhani@oracle.com \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=kch@nvidia.com \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.