All of lore.kernel.org
 help / color / mirror / Atom feed
From: gaoxiang25@huawei.com (Gao Xiang)
Subject: [PATCH] erofs-utils: fix an uninitialized variable
Date: Thu, 23 May 2019 13:37:01 +0800	[thread overview]
Message-ID: <43a07df7-324f-eb40-b2bc-e1606d126986@huawei.com> (raw)
In-Reply-To: <20190523045717.GA15346@hlj.localdomain>

Hi Lianjun,

On 2019/5/23 12:57, Lianjun Huang wrote:
> This fixes a building failure caused by using a variable before initialization.
> 
> Signed-off-by: Lianjun Huang <huanglianjun at vivo.com>

Thanks for your patch. I will apply this patch to the current mkfs-dev branch this evening.

p.s. could you have some time to take a look at erofs-mkfs and do some test/fixes on the new code,
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/log/?h=experimental

I plan to send new mkfs code to mailing list for review, and switch new erofs-mkfs from experimental
to dev branch, and mark the current mkfs obsoleted since the new mkfs is more cleaner, powerful
(with designs to support the upcoming erofs features) and seems already stable...

Thanks,
Gao Xiang

> ---
>  mkfs/erofs_cache.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/erofs_cache.c b/mkfs/erofs_cache.c
> index 5bb293b..0d7acf7 100644
> --- a/mkfs/erofs_cache.c
> +++ b/mkfs/erofs_cache.c
> @@ -142,7 +142,7 @@ int erofs_flush_all_blocks(void)
>  	char *erofs_blk_buf;
>  	char *pbuf;
>  	int count;
> -	int ret;
> +	int ret = 0;
>  
>  	erofs_blk_buf = malloc(EROFS_BLKSIZE);
>  	if (!erofs_blk_buf)
> 

  reply	other threads:[~2019-05-23  5:37 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-23  4:57 [PATCH] erofs-utils: fix an uninitialized variable Lianjun Huang
2019-05-23  5:37 ` Gao Xiang [this message]
2019-05-24  8:32 ` Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43a07df7-324f-eb40-b2bc-e1606d126986@huawei.com \
    --to=gaoxiang25@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.