From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdH1OS7 (ORCPT ); Mon, 28 Aug 2017 10:18:59 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35408 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751161AbdH1OS6 (ORCPT ); Mon, 28 Aug 2017 10:18:58 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 25ABE7E424 Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH] MAINTAINERS: Add files under drivers/virt/* to CHAR and MISC DRIVERS section To: Greg Kroah-Hartman Cc: Arnd Bergmann , linux-kernel@vger.kernel.org References: <20170825115623.22785-1-hdegoede@redhat.com> <20170825131006.GA14726@kroah.com> <0d43b1d1-1976-dad5-fe45-de854417ef4f@redhat.com> <20170828140852.GA30541@kroah.com> From: Hans de Goede Message-ID: <43c3b97f-20c0-9232-432e-96af6bf369f6@redhat.com> Date: Mon, 28 Aug 2017 16:13:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170828140852.GA30541@kroah.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Mon, 28 Aug 2017 14:18:58 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 28-08-17 16:08, Greg Kroah-Hartman wrote: > On Fri, Aug 25, 2017 at 03:11:25PM +0200, Hans de Goede wrote: >> Hi, >> >> On 25-08-17 15:10, Greg Kroah-Hartman wrote: >>> On Fri, Aug 25, 2017 at 01:56:23PM +0200, Hans de Goede wrote: >>>> Cc: Greg Kroah-Hartman >>>> Cc: Arnd Bergmann >>>> Signed-off-by: Hans de Goede >>>> --- >>>> MAINTAINERS | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/MAINTAINERS b/MAINTAINERS >>>> index 6a349b5c0c2a..db633caa5a1d 100644 >>>> --- a/MAINTAINERS >>>> +++ b/MAINTAINERS >>>> @@ -3284,6 +3284,7 @@ T: git git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git >>>> S: Supported >>>> F: drivers/char/* >>>> F: drivers/misc/* >>>> +F: drivers/virt/* >>> >>> Really? I'm now in charge of this directory too? That's news to me... >> >> This was suggested by Arnd, as he preferred putting the vboxguest driver >> under drivers/virt rather then drivers/misc. Note that currently there is >> only one .c file under drivers/virt: fsl_hypervisor.c > > Ok, but how about we wait until there is more than one file in here? That is fine by me. > And what happened to all of the other "virt" drivers, why are they not here? Some vmware drivers are currently under drivers/misc, Arnd's proposal was to move those to drivers/virt. virtio and hyperv have their own subsys dirs. > Perhaps using this directory isn't really a good idea? I started out with the same idea which is why v1 of my RFC posting of the vboxguest driver used drivers/misc, alternatively we could move the single driver currently under drivers/virt to drivers/misc and stop using drivers/virt. > I don't know... Arnd indicated he has a preference for using drivers/virt for vboxguest + the vmware drivers, I'm fine either way. This really is a bit of a bikeshed- ish discussion IMHO. So if you and/or Arnd pick one I will happily follow whatever you choose. Regards, Hans