From: Arnaud Mouiche <arnaud.mouiche@invoxia.com>
To: Fabio Estevam <festevam@gmail.com>, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, kernel@pengutronix.de,
timur@tabi.org, caleb@crome.org, nicoleotsuka@gmail.com,
max.krummenacher@toradex.com,
Fabio Estevam <fabio.estevam@nxp.com>
Subject: Re: [PATCH v2] ASoC: fsl_ssi: Fix channel swap on playback start
Date: Sat, 1 Apr 2017 17:13:22 +0200 [thread overview]
Message-ID: <43dbe05d-8047-cd2a-80ae-d570e9fb17bd@invoxia.com> (raw)
In-Reply-To: <1491058131-31366-1-git-send-email-festevam@gmail.com>
hello.
On 01/04/2017 16:48, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@nxp.com>
>
> Commit f8fdf5375e2005f2 ("ASoC: fsl-ssi: add SSIEN errata work around")
> implemented the workaround for the following erratum found on i.MX35
> errata document:
>
> ENGcm06222: SSI:Transmission does not take place in bit length early
> frame sync configuration
>
> and also for ENGcm06222 from the same document.
>
> However it has been only applied for AC97 mode. Apply it to I2S mode
> as well so that it can fix audio channel swap during playback start.
>
> The channel swap can be noticed in about 10% of the times an audio track
> starts.
>
> With the recommended workaround in place no more channel swap
> happened after running audio start/stop sequence in more than
> 2000 times.
>
> Tested on a mx6dl-wandboard.
>
> Signed-off-by: Fabio Estevam <fabio.estevam@nxp.com>
> ---
> Changes since v1:
> - Do not impact 61fcf10a0ee44763e0 ("ASoC: fsl_ssi: Fix channel slipping in
> Playback at startup")
>
> sound/soc/fsl/fsl_ssi.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c
> index 17f92b8..549b2a5 100644
> --- a/sound/soc/fsl/fsl_ssi.c
> +++ b/sound/soc/fsl/fsl_ssi.c
> @@ -575,7 +575,9 @@ static void fsl_ssi_config(struct fsl_ssi_private *ssi_private, bool enable,
> "Timeout waiting TX FIFO filling\n");
> }
> }
> - regmap_update_bits(regs, CCSR_SSI_SCR, vals->scr, vals->scr);
> + regmap_update_bits(regs, CCSR_SSI_SCR,
> + CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE | CCSR_SSI_SCR_RE,
> + CCSR_SSI_SCR_SSIEN | CCSR_SSI_SCR_TE | CCSR_SSI_SCR_RE);
> }
> }
>
I will take time to look at the possible impact on imx6 using my
previous test method.
Regards,
Arnaud
next prev parent reply other threads:[~2017-04-01 15:13 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 14:48 [PATCH v2] ASoC: fsl_ssi: Fix channel swap on playback start Fabio Estevam
2017-04-01 15:13 ` Arnaud Mouiche [this message]
2017-04-01 16:03 ` Fabio Estevam
2017-04-03 8:19 ` Max Krummenacher
2017-04-03 20:32 ` Caleb Crome
2017-04-03 20:50 ` Caleb Crome
2017-04-03 21:53 ` Fabio Estevam
2017-04-03 22:05 ` Arnaud Mouiche
2017-04-03 22:20 ` Nicolin Chen
2017-04-03 23:22 ` Caleb Crome
2017-04-03 23:40 ` Fabio Estevam
2017-04-03 23:42 ` Caleb Crome
2017-04-04 8:59 ` Arnaud Mouiche
2017-04-04 9:03 ` Arnaud Mouiche
2017-04-04 11:38 ` Fabio Estevam
2017-04-04 17:12 ` Fabio Estevam
2017-04-04 20:09 ` Arnaud Mouiche
2017-04-04 20:28 ` Fabio Estevam
2017-04-05 7:54 ` Arnaud Mouiche
2017-04-05 13:43 ` Fabio Estevam
2017-04-05 14:04 ` Max Krummenacher
2017-04-03 22:08 ` Nicolin Chen
2017-04-03 23:31 ` Caleb Crome
2017-04-03 23:55 ` Nicolin Chen
2017-04-04 0:07 ` Timur Tabi
2017-04-04 0:39 ` Caleb Crome
2017-04-04 1:25 ` Nicolin Chen
2017-04-03 22:36 ` Nicolin Chen
2017-04-03 22:54 ` Fabio Estevam
2017-04-04 0:08 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43dbe05d-8047-cd2a-80ae-d570e9fb17bd@invoxia.com \
--to=arnaud.mouiche@invoxia.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=caleb@crome.org \
--cc=fabio.estevam@nxp.com \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=max.krummenacher@toradex.com \
--cc=nicoleotsuka@gmail.com \
--cc=timur@tabi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.