All of lore.kernel.org
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>,
	Vivien Didelot <vivien.didelot@gmail.com>,
	Vladimir Oltean <olteanv@gmail.com>,
	"David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>
Cc: netdev@vger.kernel.org, "Mauri Sandberg" <sandberg@mailfence.com>,
	"Alvin Šipraga" <alsi@bang-olufsen.dk>,
	"DENG Qingfang" <dqfext@gmail.com>
Subject: Re: [PATCH net-next 7/8] net: dsa: rtl8366: Fix a bug in deleting VLANs
Date: Mon, 13 Sep 2021 10:34:46 -0700	[thread overview]
Message-ID: <43ee7616-ca74-b783-1810-bd11f9c03868@gmail.com> (raw)
In-Reply-To: <20210913144300.1265143-8-linus.walleij@linaro.org>



On 9/13/2021 7:42 AM, Linus Walleij wrote:
> We were checking that the MC (member config) was != 0
> for some reason, all we need to check is that the config
> has no ports, i.e. no members. Then it can be recycled.
> This must be some misunderstanding.
> 
> Cc: Vladimir Oltean <olteanv@gmail.com>
> Cc: Mauri Sandberg <sandberg@mailfence.com>
> Cc: Alvin Šipraga <alsi@bang-olufsen.dk>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: DENG Qingfang <dqfext@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>

Might be worth adding a Fixes tag?
-- 
Florian

  reply	other threads:[~2021-09-13 17:34 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-13 14:42 [PATCH net-next 0/8] RTL8366(RB) cleanups part 1 Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 1/8] net: dsa: rtl8366rb: Support bridge offloading Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 2/8] net: dsa: rtl8366: Drop custom VLAN set-up Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 3/8] net: dsa: rtl8366rb: Rewrite weird VLAN filering enablement Linus Walleij
2021-09-13 17:29   ` Florian Fainelli
2021-09-13 14:42 ` [PATCH net-next 4/8] net: dsa: rtl8366rb: Always treat VLAN 0 as untagged Linus Walleij
2021-09-13 15:45   ` Vladimir Oltean
2021-09-13 14:42 ` [PATCH net-next 5/8] net: dsa: rtl8366: Disable "4K" VLANs Linus Walleij
2021-09-13 15:34   ` Vladimir Oltean
2021-09-13 23:20     ` Linus Walleij
2021-09-14  6:29       ` DENG Qingfang
2021-09-14 13:12         ` Linus Walleij
2021-09-13 14:42 ` [PATCH net-next 6/8] net: dsa: rtl8366rb: Fix off-by-one bug Linus Walleij
2021-09-13 17:22   ` Vladimir Oltean
2021-09-13 14:42 ` [PATCH net-next 7/8] net: dsa: rtl8366: Fix a bug in deleting VLANs Linus Walleij
2021-09-13 17:34   ` Florian Fainelli [this message]
2021-09-13 14:43 ` [PATCH net-next 8/8] net: dsa: rtl8366: Drop and depromote pointless prints Linus Walleij
2021-09-13 17:35   ` Florian Fainelli
2021-09-13 17:38     ` Vladimir Oltean
2021-09-13 18:13       ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43ee7616-ca74-b783-1810-bd11f9c03868@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=alsi@bang-olufsen.dk \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=dqfext@gmail.com \
    --cc=kuba@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=olteanv@gmail.com \
    --cc=sandberg@mailfence.com \
    --cc=vivien.didelot@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.