From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC06DC4363A for ; Tue, 27 Oct 2020 20:26:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 480E42222C for ; Tue, 27 Oct 2020 20:26:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Afy4UATb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S372763AbgJ0U0X (ORCPT ); Tue, 27 Oct 2020 16:26:23 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:34208 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S372761AbgJ0U0W (ORCPT ); Tue, 27 Oct 2020 16:26:22 -0400 Received: by mail-lf1-f67.google.com with SMTP id z2so4067399lfr.1; Tue, 27 Oct 2020 13:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4zirdglvRKElBhw1oHaKvJRIsORyh5R1+dsaAdlhLCs=; b=Afy4UATbiLcRJ6mibHq/8mDeJ03DWWHqsG+y0nIeJTOrw7fDiP64+33bMCToTKEvja xdFOthRZHqmnPIhGj5ZfKnR43BhyllTOKmU529IGQ81mPWs7B6LzYbzjZm0m0p2w9V/s OXf1jshGMJ7NvufDXleu+jo0icuXTQP3gbZ0XFpfqw1tfsr2lhM2htiAk91NrNQHmx0z goMHZioTJ1x5uocbN4WtGpSYhdYpgrAn23R1bCiQ2akaXIMpbCgikGZ7OhVnlLlyLo3r n/D+jkdH2lUm5BcglFOmF7MexwtT1D+REZp5CJ/zawPbsDx4vF5mz6NmZFZFrUJyTwlT 3XeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4zirdglvRKElBhw1oHaKvJRIsORyh5R1+dsaAdlhLCs=; b=OT6YrVbQESlBpnmCmDgOqummlT0fGMPhuSY3v/Lg6ILK0BEFuXqkNWTD8e2HihVhl4 kbPi73D01Ijw3+Fve430CmP0RQ/x8DpmXinYWF6Mpt8ye2zgdGGiMPWC1CrTyexfC7o1 /Vw9jVY6SiKSVKO/to03J11AI44byeS/pPoQ+s1k6sNNZbj3XUMHU0DxpjhzphPfW8kP bd+vgLCPU3kN14W9OKkEkKqVFA7RPx59KkxhBSCv8Jiu38TzjsxOs0m8b4oAf+n6RaGk wO/byQnX7V35KlzDTs5zJAIh2p5GxGJk37sFxswaNmpZGy2b2GNx9vwlTMRBoxAJGgc4 1Qow== X-Gm-Message-State: AOAM533mmairIfTlSWfRGjx/KRgwCujK4tIhrXjIVIroIWWouIwp0eCx iDTGJsyo6HP/ylVXJu2X+o8TTE2kzSc= X-Google-Smtp-Source: ABdhPJycQ9/ABotDTtJ/6fjLHoGmXYUNWeaWgm/69zF9L+kp2N7BWN//ZPWGWmM3YEiQjlV15T1SvA== X-Received: by 2002:a19:9d5:: with SMTP id 204mr1361256lfj.583.1603830378059; Tue, 27 Oct 2020 13:26:18 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id t10sm283304lfc.258.2020.10.27.13.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 13:26:17 -0700 (PDT) Subject: Re: [PATCH v6 46/52] opp: Put interconnect paths outside of opp_table_lock To: Viresh Kumar Cc: Thierry Reding , Jonathan Hunter , Georgi Djakov , Rob Herring , Michael Turquette , Stephen Boyd , Peter De Schrijver , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Mikko Perttunen , Viresh Kumar , Peter Geis , Nicolas Chauvet , Krzysztof Kozlowski , linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-47-digetx@gmail.com> <20201027051013.5gr4s3wuuwxsd7ax@vireshk-i7> From: Dmitry Osipenko Message-ID: <44169d24-4afc-5388-788f-d1e8263fc627@gmail.com> Date: Tue, 27 Oct 2020 23:26:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027051013.5gr4s3wuuwxsd7ax@vireshk-i7> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org 27.10.2020 08:10, Viresh Kumar пишет: > On 26-10-20, 01:17, Dmitry Osipenko wrote: >> This patch fixes lockup which happens when OPP table is released if >> interconnect provider uses OPP in the icc_provider->set() callback >> and bandwidth of the ICC path is set to 0 by the ICC core when path >> is released. The icc_put() doesn't need the opp_table_lock protection, >> hence let's move it outside of the lock in order to resolve the problem. >> >> In particular this fixes tegra-devfreq driver lockup on trying to unload >> the driver module. The devfreq driver uses OPP-bandwidth API and its ICC >> provider also uses OPP for DVFS, hence they both take same opp_table_lock >> when OPP table of the devfreq is released. >> >> Signed-off-by: Dmitry Osipenko >> --- ... > > Never make such _fixes_ part of such a big patchset. Always send them > separately. Perhaps it's not obvious from the commit description that this patch doesn't fix any known problems of the current mainline kernel and it's needed only for the new patches. > Having said that, I already have a patch with me which shall fix it for you as > well: I see that yours fix is already applied, thanks! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0331C55178 for ; Wed, 28 Oct 2020 08:07:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5CCA520724 for ; Wed, 28 Oct 2020 08:07:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Afy4UATb" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5CCA520724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 05CDC6EC9D; Wed, 28 Oct 2020 08:06:41 +0000 (UTC) Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by gabe.freedesktop.org (Postfix) with ESMTPS id 978E36EC43 for ; Tue, 27 Oct 2020 20:26:19 +0000 (UTC) Received: by mail-lf1-x142.google.com with SMTP id 126so4000339lfi.8 for ; Tue, 27 Oct 2020 13:26:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4zirdglvRKElBhw1oHaKvJRIsORyh5R1+dsaAdlhLCs=; b=Afy4UATbiLcRJ6mibHq/8mDeJ03DWWHqsG+y0nIeJTOrw7fDiP64+33bMCToTKEvja xdFOthRZHqmnPIhGj5ZfKnR43BhyllTOKmU529IGQ81mPWs7B6LzYbzjZm0m0p2w9V/s OXf1jshGMJ7NvufDXleu+jo0icuXTQP3gbZ0XFpfqw1tfsr2lhM2htiAk91NrNQHmx0z goMHZioTJ1x5uocbN4WtGpSYhdYpgrAn23R1bCiQ2akaXIMpbCgikGZ7OhVnlLlyLo3r n/D+jkdH2lUm5BcglFOmF7MexwtT1D+REZp5CJ/zawPbsDx4vF5mz6NmZFZFrUJyTwlT 3XeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4zirdglvRKElBhw1oHaKvJRIsORyh5R1+dsaAdlhLCs=; b=FsQlcwgFbgDse2nkXMfd1hs4nyqaeWmcgSH/cdhawKVRwfeYDIM4PjGL25XHnQN4Bn YyltKMHcxfhyEnVZaLaaV3WrToKouU8EKVtrTtvt+zdoEQwK3o0voE5IZMCrHqkmCXJ6 8oIgKonFnm404Y30WGcC6qszs9y4CaII3TU61JXXtvBfgmwqpHZsf8fQoOP3yf6hO9Mk tcntimAcaNKKvOETtCP7BO04wuXm92tjh92RWD5wHaqrJQ1FsKtiDw8uHFyzNuoakYqZ Uuoh3SnahXFiq2aLhFvaQawTwiB2ZP8syRAIKyaAVOAseg5rp74veDgw917MtoTQfKS7 Ihlw== X-Gm-Message-State: AOAM533rxuntB8/T1fdVtZD0H5M14Lf6nn7nONhcFT37yxwv95kWn5DS tyisvKN1NGg/l+SpeLXMg+0= X-Google-Smtp-Source: ABdhPJycQ9/ABotDTtJ/6fjLHoGmXYUNWeaWgm/69zF9L+kp2N7BWN//ZPWGWmM3YEiQjlV15T1SvA== X-Received: by 2002:a19:9d5:: with SMTP id 204mr1361256lfj.583.1603830378059; Tue, 27 Oct 2020 13:26:18 -0700 (PDT) Received: from [192.168.2.145] (109-252-193-186.dynamic.spd-mgts.ru. [109.252.193.186]) by smtp.googlemail.com with ESMTPSA id t10sm283304lfc.258.2020.10.27.13.26.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 13:26:17 -0700 (PDT) Subject: Re: [PATCH v6 46/52] opp: Put interconnect paths outside of opp_table_lock To: Viresh Kumar References: <20201025221735.3062-1-digetx@gmail.com> <20201025221735.3062-47-digetx@gmail.com> <20201027051013.5gr4s3wuuwxsd7ax@vireshk-i7> From: Dmitry Osipenko Message-ID: <44169d24-4afc-5388-788f-d1e8263fc627@gmail.com> Date: Tue, 27 Oct 2020 23:26:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201027051013.5gr4s3wuuwxsd7ax@vireshk-i7> Content-Language: en-US X-Mailman-Approved-At: Wed, 28 Oct 2020 08:06:31 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter De Schrijver , Krzysztof Kozlowski , Mikko Perttunen , dri-devel@lists.freedesktop.org, Nicolas Chauvet , Stephen Boyd , Viresh Kumar , Michael Turquette , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, Rob Herring , Jonathan Hunter , Chanwoo Choi , Kyungmin Park , Thierry Reding , MyungJoo Ham , Peter Geis , linux-tegra@vger.kernel.org, Georgi Djakov , devicetree@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" MjcuMTAuMjAyMCAwODoxMCwgVmlyZXNoIEt1bWFyINC/0LjRiNC10YI6Cj4gT24gMjYtMTAtMjAs IDAxOjE3LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4+IFRoaXMgcGF0Y2ggZml4ZXMgbG9ja3Vw IHdoaWNoIGhhcHBlbnMgd2hlbiBPUFAgdGFibGUgaXMgcmVsZWFzZWQgaWYKPj4gaW50ZXJjb25u ZWN0IHByb3ZpZGVyIHVzZXMgT1BQIGluIHRoZSBpY2NfcHJvdmlkZXItPnNldCgpIGNhbGxiYWNr Cj4+IGFuZCBiYW5kd2lkdGggb2YgdGhlIElDQyBwYXRoIGlzIHNldCB0byAwIGJ5IHRoZSBJQ0Mg Y29yZSB3aGVuIHBhdGgKPj4gaXMgcmVsZWFzZWQuIFRoZSBpY2NfcHV0KCkgZG9lc24ndCBuZWVk IHRoZSBvcHBfdGFibGVfbG9jayBwcm90ZWN0aW9uLAo+PiBoZW5jZSBsZXQncyBtb3ZlIGl0IG91 dHNpZGUgb2YgdGhlIGxvY2sgaW4gb3JkZXIgdG8gcmVzb2x2ZSB0aGUgcHJvYmxlbS4KPj4KPj4g SW4gcGFydGljdWxhciB0aGlzIGZpeGVzIHRlZ3JhLWRldmZyZXEgZHJpdmVyIGxvY2t1cCBvbiB0 cnlpbmcgdG8gdW5sb2FkCj4+IHRoZSBkcml2ZXIgbW9kdWxlLiBUaGUgZGV2ZnJlcSBkcml2ZXIg dXNlcyBPUFAtYmFuZHdpZHRoIEFQSSBhbmQgaXRzIElDQwo+PiBwcm92aWRlciBhbHNvIHVzZXMg T1BQIGZvciBEVkZTLCBoZW5jZSB0aGV5IGJvdGggdGFrZSBzYW1lIG9wcF90YWJsZV9sb2NrCj4+ IHdoZW4gT1BQIHRhYmxlIG9mIHRoZSBkZXZmcmVxIGlzIHJlbGVhc2VkLgo+Pgo+PiBTaWduZWQt b2ZmLWJ5OiBEbWl0cnkgT3NpcGVua28gPGRpZ2V0eEBnbWFpbC5jb20+Cj4+IC0tLQouLi4KPiAK PiBOZXZlciBtYWtlIHN1Y2ggX2ZpeGVzXyBwYXJ0IG9mIHN1Y2ggYSBiaWcgcGF0Y2hzZXQuIEFs d2F5cyBzZW5kIHRoZW0KPiBzZXBhcmF0ZWx5LgoKUGVyaGFwcyBpdCdzIG5vdCBvYnZpb3VzIGZy b20gdGhlIGNvbW1pdCBkZXNjcmlwdGlvbiB0aGF0IHRoaXMgcGF0Y2gKZG9lc24ndCBmaXggYW55 IGtub3duIHByb2JsZW1zIG9mIHRoZSBjdXJyZW50IG1haW5saW5lIGtlcm5lbCBhbmQgaXQncwpu ZWVkZWQgb25seSBmb3IgdGhlIG5ldyBwYXRjaGVzLgoKPiBIYXZpbmcgc2FpZCB0aGF0LCBJIGFs cmVhZHkgaGF2ZSBhIHBhdGNoIHdpdGggbWUgd2hpY2ggc2hhbGwgZml4IGl0IGZvciB5b3UgYXMK PiB3ZWxsOgoKSSBzZWUgdGhhdCB5b3VycyBmaXggaXMgYWxyZWFkeSBhcHBsaWVkLCB0aGFua3Mh Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZl bCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xp c3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=