From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B80D6C433E0 for ; Thu, 18 Feb 2021 16:03:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A39264E0F for ; Thu, 18 Feb 2021 16:03:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233017AbhBRQDG (ORCPT ); Thu, 18 Feb 2021 11:03:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33288 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229745AbhBRNax (ORCPT ); Thu, 18 Feb 2021 08:30:53 -0500 Received: from mail.marcansoft.com (marcansoft.com [IPv6:2a01:298:fe:f::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C046DC061788 for ; Thu, 18 Feb 2021 05:29:31 -0800 (PST) Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 5984A3FA55; Thu, 18 Feb 2021 13:24:58 +0000 (UTC) To: Krzysztof Kozlowski Cc: linux-arm-kernel@lists.infradead.org, Marc Zyngier , Rob Herring , Arnd Bergmann , Olof Johansson , Mark Kettenis , Tony Lindgren , Mohamed Mediouni , Stan Skowronek , Alexander Graf , Will Deacon , Linus Walleij , Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-18-marcan@marcan.st> <20210215180652.tbccd5dhsfjpdayp@kozik-lap> From: Hector Martin Subject: Re: [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure Message-ID: <4475513e-ffe5-6064-d37e-8dbc16805dc7@marcan.st> Date: Thu, 18 Feb 2021 22:24:55 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210215180652.tbccd5dhsfjpdayp@kozik-lap> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: es-ES Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 16/02/2021 03.06, Krzysztof Kozlowski wrote: > On Mon, Feb 15, 2021 at 09:17:05PM +0900, Hector Martin wrote: >> +static void s3c64xx_serial_shutdown(struct uart_port *port) >> +{ >> + struct s3c24xx_uart_port *ourport = to_ourport(port); >> + >> + free_irq(port->irq, ourport); >> + >> + wr_regl(port, S3C64XX_UINTP, 0xf); >> + wr_regl(port, S3C64XX_UINTM, 0xf); >> + >> + ourport->tx_enabled = 0; >> + ourport->tx_mode = 0; >> + ourport->rx_enabled = 0; > > For S3C64xx type this is not equivalent: the assignments were > happening before free_irq() and wr_regl(). Honestly I don't know whether > it matters (except some barriers coming from these functions) but please > do not change the order of code in this patch. If needed, the > re-ordering should be a patch on its own. With explanation why. Honestly, I think if anything the masking should happen first (to make sure no IRQs go off), but at this point it's probably better to play it safe and not introduce any logic changes, so I've moved the assignments first to retain the old behavior. > Make the s3c24xx_serial_ops const as well. Done for v3, thanks. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7069C433E0 for ; Thu, 18 Feb 2021 13:26:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6030264E76 for ; Thu, 18 Feb 2021 13:26:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6030264E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=marcan.st Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wy4Kxx+A1RQum9YAF7X6gZbE9jDxigxM5ye/yDBJ8m8=; b=NUhZw3UFIIK2xAxpM7E1CqYGB ApoU5XoJrLBfkqn3rVA6jN3V3UUVynUt2IawGBpU1e8SyXCNDNEsya5ivIFKfkIJEFFE9+tjiLYNV txwT15A3BSK1Cayy7/iIEima1jeZGtzZkI0o4FW0vlX6cR4SGEmBl6VOPFmBjlnxta+pLZrlLOT67 +i+kN7cQlr4aqInh+WsSK1Bf1Nf1xeBNezonN+4Zw20+Dkx/oZu5aoJqTrtnaUsLkiuy7OEiNoT96 bR6NyhK+VyHLtKpbTd+DyrjzZGzwcaYiEmX7cpX2iex4pWYKmT+uKeAZRHk1hyAO9HW2cAf5v1VUN 5iCCgqfMw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCjIs-0001t2-G9; Thu, 18 Feb 2021 13:25:10 +0000 Received: from marcansoft.com ([2a01:298:fe:f::2] helo=mail.marcansoft.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lCjIp-0001rt-DV for linux-arm-kernel@lists.infradead.org; Thu, 18 Feb 2021 13:25:09 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: marcan@marcan.st) by mail.marcansoft.com (Postfix) with ESMTPSA id 5984A3FA55; Thu, 18 Feb 2021 13:24:58 +0000 (UTC) To: Krzysztof Kozlowski References: <20210215121713.57687-1-marcan@marcan.st> <20210215121713.57687-18-marcan@marcan.st> <20210215180652.tbccd5dhsfjpdayp@kozik-lap> From: Hector Martin Subject: Re: [PATCH v2 17/25] tty: serial: samsung_tty: Separate S3C64XX ops structure Message-ID: <4475513e-ffe5-6064-d37e-8dbc16805dc7@marcan.st> Date: Thu, 18 Feb 2021 22:24:55 +0900 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210215180652.tbccd5dhsfjpdayp@kozik-lap> Content-Language: es-ES X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210218_082507_643869_066CAB2B X-CRM114-Status: GOOD ( 18.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Rob Herring , Tony Lindgren , Marc Zyngier , Linus Walleij , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Alexander Graf , Olof Johansson , Mohamed Mediouni , Stan Skowronek , Will Deacon , linux-arm-kernel@lists.infradead.org, Mark Kettenis Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 16/02/2021 03.06, Krzysztof Kozlowski wrote: > On Mon, Feb 15, 2021 at 09:17:05PM +0900, Hector Martin wrote: >> +static void s3c64xx_serial_shutdown(struct uart_port *port) >> +{ >> + struct s3c24xx_uart_port *ourport = to_ourport(port); >> + >> + free_irq(port->irq, ourport); >> + >> + wr_regl(port, S3C64XX_UINTP, 0xf); >> + wr_regl(port, S3C64XX_UINTM, 0xf); >> + >> + ourport->tx_enabled = 0; >> + ourport->tx_mode = 0; >> + ourport->rx_enabled = 0; > > For S3C64xx type this is not equivalent: the assignments were > happening before free_irq() and wr_regl(). Honestly I don't know whether > it matters (except some barriers coming from these functions) but please > do not change the order of code in this patch. If needed, the > re-ordering should be a patch on its own. With explanation why. Honestly, I think if anything the masking should happen first (to make sure no IRQs go off), but at this point it's probably better to play it safe and not introduce any logic changes, so I've moved the assignments first to retain the old behavior. > Make the s3c24xx_serial_ops const as well. Done for v3, thanks. -- Hector Martin (marcan@marcan.st) Public Key: https://mrcn.st/pub _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel