From: Sergei Shtylyov <sshtylyov@ru.mvista.com>
To: Marc St-Jean <Marc_St-Jean@pmc-sierra.com>
Cc: Alan <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
linux-mips@linux-mips.org
Subject: Re: [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er
Date: Wed, 24 Jan 2007 18:33:03 +0300 [thread overview]
Message-ID: <45B77C2F.7010007@ru.mvista.com> (raw)
In-Reply-To: <45B68E23.7080800@pmc-sierra.com>
Hello.
Marc St-Jean wrote:
>> > 2. Fix for Busy Detect on LCR write
>> > 3. Workaround for interrupt/data concurrency issue
>> > case UPIO_MEM:
>> > +#ifdef CONFIG_PMC_MSP
>> > + /* Save the LCR value so it can be re-written when a
>> > + * Busy Detect interrupt occurs. */
>> > + if (dwapb_offset == UART_LCR)
>> > + up->dwapb_lcr = value;
>> > +#endif
>> > writeb(value, up->port.membase + offset);
>> > +#ifdef CONFIG_PMC_MSP
>> > + /* Re-read the IER to ensure any interrupt disabling has
>> > + * completed before proceeding with ISR. */
>> > + if (dwapb_offset == UART_IER)
>> > + value = serial_in(up, dwapb_offset);
>> > +#endif
>> > break;
>>This I would hope you can hide in the platform specific
>>serial_in/serial_out functions. If you write the UART_LCR save it in
>>serial_out(), if you read IER etc.
> I couldn't find hooks for platform specific serial_in/out functions.
It's because there are none. :-)
> Do you mean using the up->port.iotype's in serial_in/out from 8250.c?
Not sure what Alan meant, but this seems the only option for now.
>>And we might want to add a void * for board specific insanity to the 8250
>>structures if we really have to so you can hang your brain damage
>>privately off that ?
> Sounds good to me, it would give us a location to store the address of the
> UART_STATUS_REG required by this UART variant.
I doubt we really need to *store* it somewhere. Isn't it an fixed offset
from UART's base (I haven't seen the header)?
> Marc
MBR, Sergei
next prev parent reply other threads:[~2007-01-24 15:33 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 22:37 [PATCH] serial driver PMC MSP71xx, kernel linux-mips.git mast er Marc St-Jean
2007-01-23 23:41 ` Alan
2007-01-24 15:33 ` Sergei Shtylyov [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-02-16 17:06 Marc St-Jean
2007-02-16 17:21 ` Sergei Shtylyov
2007-02-16 16:30 Marc St-Jean
2007-02-13 22:11 Marc St-Jean
2007-02-12 17:46 Marc St-Jean
2007-02-12 17:56 ` Sergei Shtylyov
2007-02-09 19:39 Marc St-Jean
2007-02-10 17:30 ` Sergei Shtylyov
2007-02-07 20:50 Marc St-Jean
2007-02-06 16:52 Marc St-Jean
2007-01-27 0:28 Marc St-Jean
2007-01-25 23:10 Marc St-Jean
2007-01-26 13:58 ` Sergei Shtylyov
2007-01-24 21:10 Marc St-Jean
2007-01-25 14:29 ` Sergei Shtylyov
2007-01-24 16:48 Marc St-Jean
2007-01-24 20:38 ` Sergei Shtylyov
2007-01-24 16:40 Marc St-Jean
2007-01-24 19:40 ` Sergei Shtylyov
2007-01-22 20:35 Marc St-Jean
2007-01-22 20:34 Marc St-Jean
2007-01-22 19:07 Marc St-Jean
2007-01-22 18:11 Marc St-Jean
2007-01-22 18:11 ` Marc St-Jean
2007-01-22 18:11 ` Marc St-Jean
2007-01-22 20:23 ` Sergei Shtylyov
2007-01-24 15:25 ` Sergei Shtylyov
2007-01-19 18:40 Marc St-Jean
2007-01-19 17:33 Marc St-Jean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45B77C2F.7010007@ru.mvista.com \
--to=sshtylyov@ru.mvista.com \
--cc=Marc_St-Jean@pmc-sierra.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.