From: Max Reitz <mreitz@redhat.com>
To: Alberto Garcia <berto@igalia.com>, qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, Kevin Wolf <kwolf@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen
Date: Thu, 13 Sep 2018 15:32:53 +0200 [thread overview]
Message-ID: <468c987f-b5b3-da16-b722-8481afc5bb9b@redhat.com> (raw)
In-Reply-To: <4e73b26693677b6067545590708adcba66da1c06.1536226505.git.berto@igalia.com>
[-- Attachment #1: Type: text/plain, Size: 613 bytes --]
On 06.09.18 11:37, Alberto Garcia wrote:
> 'discard' is one of the basic BlockdevOptions available for all
> drivers, but it's not handled by bdrv_reopen_prepare() so any attempt
> to change it results in an error:
>
> (qemu) qemu-io virtio0 "reopen -o discard=on"
> Cannot change the option 'discard'
>
> Since there's no reason why we shouldn't allow changing it and the
> implementation is simple let's just do it.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
> ---
> block.c | 11 +++++++++++
> 1 file changed, 11 insertions(+)
Reviewed-by: Max Reitz <mreitz@redhat.com>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2018-09-13 13:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-06 9:37 [Qemu-devel] [PATCH v3 00/10] Misc reopen-related patches Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 01/10] qemu-io: Fix writethrough check in reopen Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 02/10] file-posix: x-check-cache-dropped should default to false on reopen Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 03/10] block: Remove child references from bs->{options, explicit_options} Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 04/10] block: Don't look for child references in append_open_options() Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 05/10] block: Allow child references on reopen Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 06/10] block: Forbid trying to change unsupported options during reopen Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 07/10] file-posix: " Alberto Garcia
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 08/10] block: Allow changing 'discard' on reopen Alberto Garcia
2018-09-13 13:32 ` Max Reitz [this message]
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 09/10] block: Allow changing 'detect-zeroes' " Alberto Garcia
2018-09-13 13:34 ` Max Reitz
2018-09-06 9:37 ` [Qemu-devel] [PATCH v3 10/10] block: Allow changing 'force-share' " Alberto Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468c987f-b5b3-da16-b722-8481afc5bb9b@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.