All of lore.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Re: 2.6.24 says "serial8250: too much work for irq4" a lot.
Date: Fri, 08 Feb 2008 23:12:12 -0800	[thread overview]
Message-ID: <47AD524C.2070508@zytor.com> (raw)
In-Reply-To: <f43fc5580802082304w2d667b8fp18370767dd854036@mail.gmail.com>

Blue Swirl wrote:
> On 2/9/08, Rob Landley <rob@landley.net> wrote:
>> Here's a patch Peter Anvin wrote so the serial I/O doesn't flood the kernel.
> 
> The patch looks OK, but the throttling should benefit all devices, as
> discussed here:
> http://lists.gnu.org/archive/html/qemu-devel/2007-12/msg00283.html

I strongly disagree with the sentiments in that post.

This is not a matter of rate throttling, but simulated FIFO exhaustion 
-- they are NOT the same thing.  Simulated FIFO exhaustion is 
functionally equivalent to making sure there are interrupt windows 
opened in an otherwise-too-long critical section; it doesn't constrain 
any particular flow rate, as it still permits another interrupt to 
immediately come in.

If you look at the patch, there are no timing dependencies; the only 
parameter is the depth of the virtual queue.  The exhaustion is 
completely controlled by target OS access patterns.

	-hpa

  reply	other threads:[~2008-02-09  7:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 20:55 2.6.24 says "serial8250: too much work for irq4" a lot Rob Landley
2008-02-05 21:07 ` H. Peter Anvin
2008-02-06  0:43   ` [Qemu-devel] " Rob Landley
2008-02-07 12:39   ` Ingo Molnar
2008-02-07 17:37     ` H. Peter Anvin
2008-02-07 20:13       ` Rob Landley
2008-02-07 20:53         ` H. Peter Anvin
2008-02-07 21:19         ` H. Peter Anvin
2008-02-08  7:04           ` Rob Landley
2008-02-09  5:49           ` [Qemu-devel] " Rob Landley
2008-02-09  7:04             ` Blue Swirl
2008-02-09  7:12               ` H. Peter Anvin [this message]
2008-02-09 11:15                 ` Blue Swirl
2008-02-09 21:36                   ` H. Peter Anvin
2008-02-10  8:01                     ` Blue Swirl
2008-02-10 11:26                       ` Paul Brook
2008-03-11 23:51                         ` Aurelien Jarno

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47AD524C.2070508@zytor.com \
    --to=hpa@zytor.com \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.