Re: Switch SensorCollection to show all sensors as new power/thermal schemas implemented

From: Gunnar Mills <gmills@linux.vnet.ibm.com>
To: Deepak Kodihalli <deepak.kodihalli.83@gmail.com>
Cc: "openbmc@lists.ozlabs.org" <openbmc@lists.ozlabs.org>,
	Ed Tanous <ed@tanous.net>, Lei Yu <yulei.sh@bytedance.com>,
	"Li, Yong B" <yong.b.li@intel.com>
Subject: Re: Switch SensorCollection to show all sensors as new power/thermal schemas implemented
Date: Mon, 15 Feb 2021 19:16:21 -0700	[thread overview]
Message-ID: <48458f34-53d0-3a61-b1bd-4d6ff513a2cb@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAM=TmwWkokfJMdT-Vd88SSui4ee7jYPudMmRXPo0uPO=6bCY4Q@mail.gmail.com>

On 1/19/2021 9:53 PM, Deepak Kodihalli wrote:
> 
> Where would the sensor collection be rooted at?
> /redfish/v1/chassis/{ID}/sensors? 

Late reply. Yes. Sensors are associated to a chassis via an association.
https://github.com/openbmc/docs/blob/919a7b6816a5f16aa72d298e81e0756d95d5031e/architecture/sensor-architecture.md#association-type-1-linking-a-chassis-to-all-sensors-within-the-chassis

https://gerrit.openbmc-project.xyz/c/openbmc/bmcweb/+/40169 is the code 
for moving bmcweb to all sensors in the sensor collection.

If so, would this also contain
> sensors accessible to the system software (some CPU/DIMM sensors for
> eg)?

Yes, it could. There is nothing in the Redfish spec that prevents that. 
The definition of what a sensor is in Redfish is very broad.
If you need additional "ReadingTypes", I'm sure Redfish would be willing 
to add with a use case.

https://redfish.dmtf.org/schemas/v1/Sensor.v1_2_0.json

Hope this helps,
Gunnar