From: Or Gerlitz <ogerlitz-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
To: kxie-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org
Cc: open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org,
James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org
Subject: Re: [PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu()
Date: Wed, 11 Feb 2009 10:21:50 +0200 [thread overview]
Message-ID: <49928A9E.5070600@Voltaire.com> (raw)
In-Reply-To: <200902110301.n1B31q5M002101-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
Karen Xie wrote:
> So I only added the offset and count as additional parameters to alloc_pdu().
> So that the pdu payload is known at the time of pdu memory allocation.
> include/scsi/libiscsi.h | 12 +++++
> include/scsi/scsi_transport_iscsi.h | 3 +
Hi Karen,
Please take into account that the iscsi transport and libiscsi APIs has more consumers that are effects by changes. For example iSER also uses the alloc_pdu API and your patch should take care of that. I would recommend adding the needed CONFIG directives the other iSCSI transports to your default .config profile which will allow you to catch such issues. Building Linus tree with your patch I see warning both in the cxgbi and iser drivers wrt to the change.
Or.
[root@linux-cto-1 linus-linux-2.6]# make
CHK include/linux/version.h
CHK include/linux/utsrelease.h
SYMLINK include/asm -> include/asm-x86
CALL scripts/checksyscalls.sh
CHK include/linux/compile.h
CC [M] drivers/infiniband/ulp/iser/iscsi_iser.o
drivers/infiniband/ulp/iser/iscsi_iser.c:656: warning: initialization from incompatible pointer type
LD [M] drivers/infiniband/ulp/iser/ib_iser.o
CC [M] drivers/scsi/cxgb3i/cxgb3i_iscsi.o
drivers/scsi/cxgb3i/cxgb3i_iscsi.c:913: warning: initialization from incompatible pointer type
LD [M] drivers/scsi/cxgb3i/cxgb3i.o
Kernel: arch/x86/boot/bzImage is ready (#3)
Building modules, stage 2.
MODPOST 514 modules
LD [M] drivers/infiniband/ulp/iser/ib_iser.ko
LD [M] drivers/scsi/cxgb3i/cxgb3i.ko
the config directives for iser and ql4xxx are CONFIG_SCSI_QLA_ISCSI=m and CONFIG_INFINIBAND_ISER=m
for iser you would also need CONFIG_INFINIBAND=m and CONFIG_INFINIBAND_ADDR_TRANS=y
next prev parent reply other threads:[~2009-02-11 8:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 3:01 [PATCH 2.6.29-rc] iscsi - add offset and count to alloc_pdu() Karen Xie
[not found] ` <200902110301.n1B31q5M002101-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-02-11 8:21 ` Or Gerlitz [this message]
2009-02-11 19:57 ` Mike Christie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49928A9E.5070600@Voltaire.com \
--to=ogerlitz-hkgkho2ms0fwk0htik3j/w@public.gmane.org \
--cc=James.Bottomley-d9PhHud1JfjCXq6kfMZ53/egYHeGw8Jk@public.gmane.org \
--cc=kxie-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org \
--cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=michaelc-hcNo3dDEHLuVc3sceRu5cw@public.gmane.org \
--cc=open-iscsi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.