From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E3CCC433EF for ; Mon, 8 Nov 2021 19:51:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7458E619E3 for ; Mon, 8 Nov 2021 19:51:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237944AbhKHTyd (ORCPT ); Mon, 8 Nov 2021 14:54:33 -0500 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:53302 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237891AbhKHTyb (ORCPT ); Mon, 8 Nov 2021 14:54:31 -0500 Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA id kAgBmHCd3OvR0kAgBmrd8n; Mon, 08 Nov 2021 20:51:45 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Mon, 08 Nov 2021 20:51:45 +0100 X-ME-IP: 86.243.171.122 Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' To: Florian Fainelli , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= Cc: nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> From: Christophe JAILLET Message-ID: <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> Date: Mon, 8 Nov 2021 20:51:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 08/11/2021 à 17:28, Florian Fainelli a écrit : > > > On 11/7/2021 5:34 PM, Krzysztof Wilczyński wrote: >> Hi Christophe! >> >> [...] >>> This bitmap can be BRCM_INT_PCI_MSI_LEGACY_NR or BRCM_INT_PCI_MSI_NR >>> long. >> >> Ahh.  OK.  Given this an option would be to: do nothing (keep current >> status quo); allocate memory dynamically passing the "msi->nr" after it >> has been set accordingly; use BRCM_INT_PCI_MSI_NR and waste a little bit >> of space. >> >> Perhaps moving to using the DECLARE_BITMAP() would be fine in this case >> too, at least to match style of other drivers more closely. >> >> Jim, Florian and Lorenzo - is this something that would be OK with you, >> or you would rather keep things as they were? > > I would be tempted to leave the code as-is, but if we do we are probably > bound to seeing patches like Christophe's in the future to address the Even if I don't find this report in the Coverity database, it should from around April 2018. So, if you have not already received several patches for that, I doubt that you will receive many in the future. My own feeling is that using a long (and not a long *) as a bitmap, and accessing it with &long may look spurious to a reader. That said, it works. So, I let you decide if the patch is of any use. Should I need to tweak or resend it, let me know. CJ > problem, unless we place a coverity specific comment in the source tree, > which is probably frowned upon. > > The addition of the BUILD_BUG_ON() is a good addition though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1E353C433F5 for ; Mon, 8 Nov 2021 19:53:15 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C4974619E1 for ; Mon, 8 Nov 2021 19:53:14 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org C4974619E1 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=wanadoo.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=TQrrprf+hYaXLZT4ovo+X7C/qNQLd5aHCcTYoQJP2mE=; b=SlKtJqkKjZ/PpdYal1ml9lWlgK 502NGlE1nDUTX7phDHYkkKXwWPg1vBj/WVRzwerYtyfJp4HIHfVKHWXkUNlKiLW1n82wWk5NDxTh1 pMdVgfjnGG3TtA3aVJbi+uf/D+aEvxPijd/FSJK+hyiNkFsYiI7q+C5tQhtM2ltdL4jMj2H5w6Q0+ u/YHRkZKn1N9//QCbiVbFiENAPjL/UWrwXAIQp6rpRppUtuECOF6lykKDVrY2VTo8/uKowleK1Pwy 0/kswrOEyx3IcCzYa3RkBrB1wWupxiVCRoYWQro1FMScVg/ayokcC1R/jil0SZv3RQu1H9g8q7p4+ ixOHjKLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkAgN-00HLJL-6b; Mon, 08 Nov 2021 19:51:55 +0000 Received: from smtp05.smtpout.orange.fr ([80.12.242.127] helo=smtp.smtpout.orange.fr) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mkAgJ-00HLHX-5F for linux-arm-kernel@lists.infradead.org; Mon, 08 Nov 2021 19:51:53 +0000 Received: from [192.168.1.18] ([86.243.171.122]) by smtp.orange.fr with ESMTPA id kAgBmHCd3OvR0kAgBmrd8n; Mon, 08 Nov 2021 20:51:45 +0100 X-ME-Helo: [192.168.1.18] X-ME-Auth: YWZlNiIxYWMyZDliZWIzOTcwYTEyYzlhMmU3ZiQ1M2U2MzfzZDfyZTMxZTBkMTYyNDBjNDJlZmQ3ZQ== X-ME-Date: Mon, 08 Nov 2021 20:51:45 +0100 X-ME-IP: 86.243.171.122 Subject: Re: [PATCH] PCI: brcmstb: Declare a bitmap as a bitmap, not as a plain 'unsigned long' To: Florian Fainelli , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= Cc: nsaenz@kernel.org, jim2101024@gmail.com, bcm-kernel-feedback-list@broadcom.com, lorenzo.pieralisi@arm.com, robh@kernel.org, bhelgaas@google.com, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> From: Christophe JAILLET Message-ID: <4997ef3c-5867-7ce0-73a2-f4381cf0879b@wanadoo.fr> Date: Mon, 8 Nov 2021 20:51:43 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <4d556ac3-b936-b99c-5a50-9add8607047d@gmail.com> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211108_115151_376762_9AE8C83E X-CRM114-Status: GOOD ( 21.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org TGUgMDgvMTEvMjAyMSDDoCAxNzoyOCwgRmxvcmlhbiBGYWluZWxsaSBhIMOpY3JpdMKgOgo+IAo+ IAo+IE9uIDExLzcvMjAyMSA1OjM0IFBNLCBLcnp5c3p0b2YgV2lsY3p5xYRza2kgd3JvdGU6Cj4+ IEhpIENocmlzdG9waGUhCj4+Cj4+IFsuLi5dCj4+PiBUaGlzIGJpdG1hcCBjYW4gYmUgQlJDTV9J TlRfUENJX01TSV9MRUdBQ1lfTlIgb3IgQlJDTV9JTlRfUENJX01TSV9OUiAKPj4+IGxvbmcuCj4+ Cj4+IEFoaC7CoCBPSy7CoCBHaXZlbiB0aGlzIGFuIG9wdGlvbiB3b3VsZCBiZSB0bzogZG8gbm90 aGluZyAoa2VlcCBjdXJyZW50Cj4+IHN0YXR1cyBxdW8pOyBhbGxvY2F0ZSBtZW1vcnkgZHluYW1p Y2FsbHkgcGFzc2luZyB0aGUgIm1zaS0+bnIiIGFmdGVyIGl0Cj4+IGhhcyBiZWVuIHNldCBhY2Nv cmRpbmdseTsgdXNlIEJSQ01fSU5UX1BDSV9NU0lfTlIgYW5kIHdhc3RlIGEgbGl0dGxlIGJpdAo+ PiBvZiBzcGFjZS4KPj4KPj4gUGVyaGFwcyBtb3ZpbmcgdG8gdXNpbmcgdGhlIERFQ0xBUkVfQklU TUFQKCkgd291bGQgYmUgZmluZSBpbiB0aGlzIGNhc2UKPj4gdG9vLCBhdCBsZWFzdCB0byBtYXRj aCBzdHlsZSBvZiBvdGhlciBkcml2ZXJzIG1vcmUgY2xvc2VseS4KPj4KPj4gSmltLCBGbG9yaWFu IGFuZCBMb3JlbnpvIC0gaXMgdGhpcyBzb21ldGhpbmcgdGhhdCB3b3VsZCBiZSBPSyB3aXRoIHlv dSwKPj4gb3IgeW91IHdvdWxkIHJhdGhlciBrZWVwIHRoaW5ncyBhcyB0aGV5IHdlcmU/Cj4gCj4g SSB3b3VsZCBiZSB0ZW1wdGVkIHRvIGxlYXZlIHRoZSBjb2RlIGFzLWlzLCBidXQgaWYgd2UgZG8g d2UgYXJlIHByb2JhYmx5IAo+IGJvdW5kIHRvIHNlZWluZyBwYXRjaGVzIGxpa2UgQ2hyaXN0b3Bo ZSdzIGluIHRoZSBmdXR1cmUgdG8gYWRkcmVzcyB0aGUgCgpFdmVuIGlmIEkgZG9uJ3QgZmluZCB0 aGlzIHJlcG9ydCBpbiB0aGUgQ292ZXJpdHkgZGF0YWJhc2UsIGl0IHNob3VsZCAKZnJvbSBhcm91 bmQgQXByaWwgMjAxOC4KU28sIGlmIHlvdSBoYXZlIG5vdCBhbHJlYWR5IHJlY2VpdmVkIHNldmVy YWwgcGF0Y2hlcyBmb3IgdGhhdCwgSSBkb3VidCAKdGhhdCB5b3Ugd2lsbCByZWNlaXZlIG1hbnkg aW4gdGhlIGZ1dHVyZS4KCgpNeSBvd24gZmVlbGluZyBpcyB0aGF0IHVzaW5nIGEgbG9uZyAoYW5k IG5vdCBhIGxvbmcgKikgYXMgYSBiaXRtYXAsIGFuZCAKYWNjZXNzaW5nIGl0IHdpdGggJmxvbmcg bWF5IGxvb2sgc3B1cmlvdXMgdG8gYSByZWFkZXIuClRoYXQgc2FpZCwgaXQgd29ya3MuCgpTbywg SSBsZXQgeW91IGRlY2lkZSBpZiB0aGUgcGF0Y2ggaXMgb2YgYW55IHVzZS4gU2hvdWxkIEkgbmVl ZCB0byB0d2VhayAKb3IgcmVzZW5kIGl0LCBsZXQgbWUga25vdy4KCgpDSgoKPiBwcm9ibGVtLCB1 bmxlc3Mgd2UgcGxhY2UgYSBjb3Zlcml0eSBzcGVjaWZpYyBjb21tZW50IGluIHRoZSBzb3VyY2Ug dHJlZSwgCj4gd2hpY2ggaXMgcHJvYmFibHkgZnJvd25lZCB1cG9uLgo+IAo+IFRoZSBhZGRpdGlv biBvZiB0aGUgQlVJTERfQlVHX09OKCkgaXMgYSBnb29kIGFkZGl0aW9uIHRob3VnaC4KCgpfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2Vy bmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0 cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVs Cg==