All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Bernhard Kohl <bernhard.kohl@nsn.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] kvm: external module: support building against Windriver 2.0 (kernel 2.6.21)
Date: Sun, 15 Mar 2009 12:24:17 +0200	[thread overview]
Message-ID: <49BCD751.6010106@redhat.com> (raw)
In-Reply-To: <49B94F09.90302@siemens.com>

Jan Kiszka wrote:
> Bernhard Kohl wrote:
>   
>> This is needed to compile kvm in a Windriver 2.0 distribution
>> (kernel 2.6.21). This kernel has an include file marker.h, but
>> trace_mark is not defined there. So the compat code in
>> kernel/include-compat/linux/marker.h is not included.
>>     
>
> I bet this is because Wind River patched some variant of LTTng into
> their kernel.
>
> However, I'm unsure if supporting significantly modified distribution
> kernels is in the scope of this compat layer. 

Yes, for example we support the RHEL 5 series, which significantly 
deviates from plain 2.6.18.

> If it is ok for the
> maintainers, you should try to make the test more Wind River specific
> (did you check that there is no side-effect for normal <= 2.6.21
> kernels?) and maybe add a comment.
>   

Best would be to check for a Wind River kernel as this is likely to 
break on mainline Linux.



-- 
error compiling committee.c: too many arguments to function


  parent reply	other threads:[~2009-03-15 10:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 17:37 [PATCH] kvm: external module: support building against Windriver 2.0 (kernel 2.6.21) Bernhard Kohl
2009-03-12 18:06 ` Jan Kiszka
2009-03-13 15:12   ` Bernhard Kohl
2009-03-15 10:24   ` Avi Kivity [this message]
2009-03-16 23:03     ` Bernhard Kohl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49BCD751.6010106@redhat.com \
    --to=avi@redhat.com \
    --cc=bernhard.kohl@nsn.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kvm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.