All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Varghese, Vipin" <vipin.varghese@intel.com>
To: Suanming.Mou <mousuanming@huawei.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support.
Date: Tue, 30 Apr 2019 05:03:27 +0000	[thread overview]
Message-ID: <4C9E0AB70F954A408CC4ADDBF0F8FA7D4D33FAA0@BGSMSX101.gar.corp.intel.com> (raw)
In-Reply-To: <de034d33-3ef1-4eab-3f0b-d9ba8f1c0cca@huawei.com>

snipped
> >
> > 1. the documentation update.
> 
> I'd like to reconfirm that since Anatoly suggested to make the option default, I
> deleted the option supporting code.
> 
> Is it aligned that we can make it default?
> 
> If it is aligned to make it default, then if I understand correctly, to add a new note
> in the documentation to describe pdump will exit with primary will be OK?

I am not aware of the conversation and will leave this to maintainer if the option should be `--exit-with-primary` or `--do-not-exit-primary`. 

Please add the changes to `doc/guides/tools/proc_info.rst` of the changes and new option that gets added.

> 
> > 2. cover letter.
> Sorry for that. Will add the cover letter in the V5 patch.
thanks

> > 3. for signal SIGINT, set for ` rte_eal_alarm_cancel`.
> Ah, yes.
Thanks

> >
> > Can you share a new patch as v5 with these changes?
> Thanks for your reviewing. I will send the next patch after Q1 confirmed.
Ok


snipped


  reply	other threads:[~2019-04-30  5:03 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-25 16:35 [dpdk-dev] [PATCH] app/pdump: exits once primary app exited Suanming.Mou
2019-04-25 15:51 ` Varghese, Vipin
2019-04-26  7:11   ` Suanming.Mou
2019-04-26 10:54     ` Varghese, Vipin
2019-04-26 10:56       ` Varghese, Vipin
2019-04-26 12:08         ` Suanming.Mou
2019-04-26 13:46           ` Burakov, Anatoly
2019-04-26 14:32             ` Suanming.Mou
2019-04-26 14:39               ` Burakov, Anatoly
2019-04-26 14:49                 ` Suanming.Mou
2019-04-26 14:50                   ` Burakov, Anatoly
2019-04-28  4:58 ` [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option support Suanming.Mou
2019-04-28  5:07   ` [dpdk-dev] [PATCH v3] " Suanming.Mou
2019-04-30  3:39     ` [dpdk-dev] [PATCH v4] app/pdump: add pudmp exits with primary support Suanming.Mou
2019-04-30  2:33       ` Varghese, Vipin
2019-04-30  3:43         ` Suanming.Mou
2019-04-30  5:03           ` Varghese, Vipin [this message]
2019-04-30  9:34         ` Burakov, Anatoly
2019-04-30 10:37           ` Varghese, Vipin
2019-04-30 16:38             ` Burakov, Anatoly
2019-04-30 11:35       ` [dpdk-dev] [PATCH v5] Make pdump exits with primary Suanming.Mou
2019-04-30 11:35         ` [dpdk-dev] [PATCH v5] app/pdump: add pudmp exits with primary support Suanming.Mou
2019-04-30  9:42           ` Burakov, Anatoly
2019-04-30 11:25             ` Suanming.Mou
2019-04-30 16:39               ` Burakov, Anatoly
2019-05-02  3:07                 ` Suanming.Mou
2019-04-30 12:44           ` Pattan, Reshma
2019-05-02  5:20           ` [dpdk-dev] [PATCH v6] " Suanming.Mou
2019-05-02  8:04             ` Varghese, Vipin
2019-05-02  8:32               ` Suanming.Mou
2019-05-02  9:12                 ` Burakov, Anatoly
2019-05-02  9:22                 ` Varghese, Vipin
2019-05-02  9:54             ` Pattan, Reshma
2019-05-02 10:40               ` Suanming.Mou
2019-05-02 12:35             ` [dpdk-dev] [PATCH v7] " Suanming.Mou
2019-05-02 11:03               ` Pattan, Reshma
2019-05-02 11:31               ` Burakov, Anatoly
2019-05-03  5:48               ` [dpdk-dev] [PATCH v8] " Suanming.Mou
2019-05-04 21:17                 ` Thomas Monjalon
2019-05-05  1:20                   ` Suanming.Mou
2019-05-05  9:42                     ` Thomas Monjalon
2019-05-05 11:13                       ` Suanming.Mou
2019-05-08  8:04                 ` Thomas Monjalon
2019-05-08  9:37                   ` Suanming.Mou
2019-05-08 10:22                     ` Thomas Monjalon
2019-05-08 13:14                       ` Suanming.Mou
2019-05-15  5:10                 ` [dpdk-dev] [PATCH v9] app/pdump: exit with primary process Suanming.Mou
2019-06-20 12:32                   ` Pattan, Reshma
2019-06-23 22:30                     ` Thomas Monjalon
2019-07-10 14:04                       ` Suanming Mou
2019-07-10 22:28                         ` Thomas Monjalon
2019-04-29  9:14   ` [dpdk-dev] [PATCH v2] app/pdump: add exit_with_primary option support Burakov, Anatoly
2019-04-29  9:43     ` Suanming.Mou
2019-04-29 10:42       ` Burakov, Anatoly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C9E0AB70F954A408CC4ADDBF0F8FA7D4D33FAA0@BGSMSX101.gar.corp.intel.com \
    --to=vipin.varghese@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=mousuanming@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.