From: Jan Kiszka <jan.kiszka@siemens.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: xen-devel <xen-devel@lists.xensource.com>,
Wei Liu <wei.liu2@citrix.com>, "liuw@liuw.name" <liuw@liuw.name>,
Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>,
QEMU-devel <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/2] Xen: Add xen-apic support and hook it up.
Date: Wed, 11 Apr 2012 18:13:03 +0200 [thread overview]
Message-ID: <4F85AD8F.7000004@siemens.com> (raw)
In-Reply-To: <CAFEAcA9GJKPQBohDg-7NtcLKofH8vWRzO2KUjxNVk90exCknNw@mail.gmail.com>
On 2012-04-11 18:07, Peter Maydell wrote:
>> +#include "hw/apic_internal.h"
>> +#include "hw/msi.h"
>> +#include "xen.h"
>> +
>> +static uint64_t xen_apic_mem_read(void *opaque, target_phys_addr_t addr,
>> + unsigned size)
>> +{
>> + return -1U;
>> +}
>
> This seems a rather confusing way to write 'return 0xffffffff;'
You mean 0xffffffffffffffff? :)
Jan
--
Siemens AG, Corporate Technology, CT T DE IT 1
Corporate Competence Center Embedded Linux
next prev parent reply other threads:[~2012-04-11 16:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-05 9:32 [Qemu-devel] [PATCH 0/0] MSI/MSIX injection for Xen HVM guests Wei Liu
2012-04-05 9:32 ` Wei Liu
2012-04-05 9:34 ` [Qemu-devel] [PATCH 1/2] Xen: basic HVM MSI injection support Wei Liu
2012-04-05 9:34 ` Wei Liu
2012-04-05 9:35 ` [Qemu-devel] [PATCH 2/2] Xen: Add xen-apic support and hook it up Wei Liu
2012-04-05 9:35 ` Wei Liu
2012-04-11 16:02 ` Stefano Stabellini
2012-04-11 16:01 ` Jan Kiszka
2012-04-11 16:07 ` Peter Maydell
2012-04-11 16:13 ` Jan Kiszka [this message]
2012-04-11 16:23 ` Peter Maydell
2012-04-11 16:17 ` Stefano Stabellini
2012-04-11 16:19 ` Stefano Stabellini
2012-04-11 17:02 ` Eric Blake
2012-04-12 3:23 ` [Qemu-devel] " Wei Liu
2012-04-11 21:37 ` Paolo Bonzini
2012-04-05 10:14 ` [Qemu-devel] [PATCH 0/0] MSI/MSIX injection for Xen HVM guests Paolo Bonzini
2012-04-05 10:14 ` Paolo Bonzini
2012-04-05 10:43 ` [Qemu-devel] " Stefano Stabellini
2012-04-05 10:43 ` Stefano Stabellini
2012-04-05 10:50 ` [Qemu-devel] " Paolo Bonzini
2012-04-05 10:50 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F85AD8F.7000004@siemens.com \
--to=jan.kiszka@siemens.com \
--cc=Stefano.Stabellini@eu.citrix.com \
--cc=liuw@liuw.name \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.