From: Sakari Ailus <sakari.ailus@iki.fi>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 3/4] omap3isp: ccdc: Add crop support on output formatter source pad
Date: Tue, 24 Apr 2012 01:23:06 +0300 [thread overview]
Message-ID: <4F95D64A.10505@iki.fi> (raw)
In-Reply-To: <1335180595-27931-4-git-send-email-laurent.pinchart@ideasonboard.com>
Hi Laurent,
The patch looks good as such on the first glance, but I have another
question: why are you not using the selections API instead? It's in
Mauro's tree already. Also, the old S_CROP IOCTL only has been defined
for sink pads, not source.
Cheers,
--
Sakari Ailus
sakari.ailus@iki.fi
next prev parent reply other threads:[~2012-04-23 22:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 11:29 [PATCH 0/4] Miscellaneous OMAP3 ISP fixes and enhancements Laurent Pinchart
2012-04-23 11:29 ` [PATCH 1/4] omap3isp: preview: Rename last occurences of *_rgb_to_ycbcr to *_csc Laurent Pinchart
2012-04-23 11:29 ` [PATCH 2/4] omap3isp: preview: Add support for greyscale input Laurent Pinchart
2012-04-24 23:19 ` Sakari Ailus
2012-04-23 11:29 ` [PATCH 3/4] omap3isp: ccdc: Add crop support on output formatter source pad Laurent Pinchart
2012-04-23 22:23 ` Sakari Ailus [this message]
2012-04-24 9:08 ` Laurent Pinchart
2012-04-24 15:14 ` Sakari Ailus
2012-04-24 20:10 ` Laurent Pinchart
2012-04-24 20:46 ` Sakari Ailus
2012-04-23 11:29 ` [PATCH 4/4] omap3isp: Mark probe and cleanup functions with __devinit and __devexit Laurent Pinchart
2012-04-24 23:05 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F95D64A.10505@iki.fi \
--to=sakari.ailus@iki.fi \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.