All of lore.kernel.org
 help / color / mirror / Atom feed
From: Caspar Zhang <caspar@casparzhang.com>
To: Zhouping Liu <zliu@redhat.com>
Cc: LTP List <ltp-list@lists.sourceforge.net>
Subject: Re: [LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config()
Date: Sat, 28 Apr 2012 15:56:46 +0800	[thread overview]
Message-ID: <4F9BA2BE.2060809@casparzhang.com> (raw)
In-Reply-To: <e83b4d425c1586a967531228804843d8bc3b391f.1335599279.git.zliu@redhat.com>

On 04/28/2012 03:48 PM, Zhouping Liu wrote:
> removed tst_exit in check_config(), as it's always involked
> at any time, instead, using tst_brkm to displace tst_resm,
> since TCONF should be called by tst_brkm.
> 
> Signed-off-by: Zhouping Liu <zliu@redhat.com>

Acked-by: Caspar Zhang <caspar@casparzhang.com>

> ---
>  testcases/kernel/syscalls/move_pages/move_pages_support.c |    9 ++++-----
>  1 file changed, 4 insertions(+), 5 deletions(-)
> 
> diff --git a/testcases/kernel/syscalls/move_pages/move_pages_support.c b/testcases/kernel/syscalls/move_pages/move_pages_support.c
> index 6bd95d3..320486f 100644
> --- a/testcases/kernel/syscalls/move_pages/move_pages_support.c
> +++ b/testcases/kernel/syscalls/move_pages/move_pages_support.c
> @@ -382,14 +382,13 @@ void check_config(unsigned int min_nodes)
>  {
>  #if HAVE_NUMA_H && HAVE_NUMAIF_H
>  	if (numa_available() < 0) {
> -		tst_resm(TCONF, "NUMA support is not available");
> +		tst_brkm(TCONF, NULL, "NUMA support is not available");
>  	} else if (numa_max_node() < (min_nodes - 1)) {
> -		tst_resm(TCONF, "atleast 2 NUMA nodes are required");
> +		tst_brkm(TCONF, NULL, "atleast 2 NUMA nodes are required");
>  	} else if (tst_kvercmp(2, 6, 18) < 0) {
> -		tst_resm(TCONF, "2.6.18 or greater kernel required");
> +		tst_brkm(TCONF, NULL, "2.6.18 or greater kernel required");
>  	}
>  #else
> -	tst_resm(TCONF, "NUMA support not provided");
> +	tst_brkm(TCONF, NULL, "NUMA support not provided");
>  #endif
> -	tst_exit();
>  }


------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and 
threat landscape has changed and how IT managers can respond. Discussions 
will include endpoint security, mobile security and the latest in malware 
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
Ltp-list mailing list
Ltp-list@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/ltp-list

  reply	other threads:[~2012-04-28  7:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-28  7:48 [LTP] [PATCH 1/3] m4/ltp-numa.m4: fixed numa config Zhouping Liu
2012-04-28  7:48 ` [LTP] [PATCH 2/3] syscalls/move_pages: modified HAS_NUMA_H as HAVE_NUMA_H Zhouping Liu
2012-04-28  7:48   ` [LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config() Zhouping Liu
2012-04-28  7:56     ` Caspar Zhang [this message]
2012-04-28  7:53   ` [LTP] [PATCH 2/3] syscalls/move_pages: modified HAS_NUMA_H as HAVE_NUMA_H Garrett Cooper
2012-04-28  7:56   ` Caspar Zhang
2012-04-28  7:57 ` [LTP] [PATCH 1/3] m4/ltp-numa.m4: fixed numa config Caspar Zhang
2012-04-28 11:35 ` Wanlong Gao
     [not found] <2F2D931F-792A-425D-9BFE-D97AD02CDEF7@gmail.com>
2012-04-28  9:04 ` [LTP] [PATCH 3/3] syscalls/move_pages: removed tst_exit in check_config() Zhouping Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F9BA2BE.2060809@casparzhang.com \
    --to=caspar@casparzhang.com \
    --cc=ltp-list@lists.sourceforge.net \
    --cc=zliu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.