From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eugeni Dodonov Subject: Re: [PATCH] drm/i915: fix gen4 gpu reset Date: Fri, 04 May 2012 14:06:29 -0300 Message-ID: <4FA40C95.8060400@linux.intel.com> References: <87wr50rc31.fsf@eliezer.anholt.net> <1335987232-4786-1-git-send-email-daniel.vetter@ffwll.ch> Reply-To: eugeni.dodonov@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 0002D9E968 for ; Fri, 4 May 2012 10:06:14 -0700 (PDT) In-Reply-To: <1335987232-4786-1-git-send-email-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Daniel Vetter Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org On 05/02/2012 04:33 PM, Daniel Vetter wrote: > While trying to fix up gen4 gpu reset in > > commit f49f0586191fe16140410db0a46d43bdc690d6af > Author: Kenneth Graunke > Date: Sat Sep 11 01:19:14 2010 -0700 > > drm/i915: Actually set the reset bit in i965_reset > > a little confusion about when wait_for times out has been introduced - > wait for loops _until_ the condition is true. > > This fixes gpu reset on my gm45, testing with my hangman code shows > that it's now fairly reliable - it only died after well over 100 reset > cycles. > > Cc: Kenneth Graunke > Cc: Eric Anholt > Signed-Off-by: Daniel Vetter I haven't tested it on a real machine to verify if it actually does the reset, but this change does explains why it could not work before :). Reviewed-by: Eugeni Dodonov