From: Alexey Kardashevskiy <aik@ozlabs.ru> To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, kvm-ppc@vger.kernel.org Subject: [Qemu-devel] [PATCH 1/3] msi/msix: added functions to API to set up message address and data Date: Thu, 14 Jun 2012 14:31:58 +1000 [thread overview] Message-ID: <4FD9693E.2090508@ozlabs.ru> (raw) In-Reply-To: <4FD968BB.2000505@ozlabs.ru> Normally QEMU expects the guest to initialize MSI/MSIX vectors. However on POWER the guest uses RTAS subsystem to configure MSI/MSIX and does not write these vectors to device's config space or MSIX BAR. On the other hand, msi_notify()/msix_notify() write to these vectors to signal the guest about an interrupt so we have to write correct vectors to the devices in order not to change every user of MSI/MSIX. The first aim is to support MSIX for virtio-pci on POWER. There is another patch for POWER coming which introduces a special memory region where MSI/MSIX vectors point to. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> --- hw/msi.c | 14 ++++++++++++++ hw/msi.h | 1 + hw/msix.c | 10 ++++++++++ hw/msix.h | 3 +++ 4 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 5d6ceb6..124878a 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -358,3 +358,17 @@ unsigned int msi_nr_vectors_allocated(const PCIDevice *dev) uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); return msi_nr_vectors(flags); } + +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data) +{ + uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); + bool msi64bit = flags & PCI_MSI_FLAGS_64BIT; + + if (msi64bit) { + pci_set_quad(dev->config + msi_address_lo_off(dev), address); + } else { + pci_set_long(dev->config + msi_address_lo_off(dev), address); + } + pci_set_word(dev->config + msi_data_off(dev, msi64bit), data); +} + diff --git a/hw/msi.h b/hw/msi.h index 3040bb0..0acf434 100644 --- a/hw/msi.h +++ b/hw/msi.h @@ -34,6 +34,7 @@ void msi_reset(PCIDevice *dev); void msi_notify(PCIDevice *dev, unsigned int vector); void msi_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len); unsigned int msi_nr_vectors_allocated(const PCIDevice *dev); +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data); static inline bool msi_present(const PCIDevice *dev) { diff --git a/hw/msix.c b/hw/msix.c index 3835eaa..c57c299 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -414,3 +414,13 @@ void msix_unuse_all_vectors(PCIDevice *dev) return; msix_free_irq_entries(dev); } + +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data) +{ + uint8_t *table_entry = dev->msix_table_page + vector * PCI_MSIX_ENTRY_SIZE; + pci_set_quad(table_entry + PCI_MSIX_ENTRY_LOWER_ADDR, address); + pci_set_long(table_entry + PCI_MSIX_ENTRY_DATA, data); + table_entry[PCI_MSIX_ENTRY_VECTOR_CTRL] &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT; +} + diff --git a/hw/msix.h b/hw/msix.h index 5aba22b..e6bb696 100644 --- a/hw/msix.h +++ b/hw/msix.h @@ -29,4 +29,7 @@ void msix_notify(PCIDevice *dev, unsigned vector); void msix_reset(PCIDevice *dev); +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data); + #endif -- 1.7.7.3
WARNING: multiple messages have this Message-ID (diff)
From: Alexey Kardashevskiy <aik@ozlabs.ru> To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>, kvm-ppc@vger.kernel.org Subject: [PATCH 1/3] msi/msix: added functions to API to set up message address and data Date: Thu, 14 Jun 2012 04:31:58 +0000 [thread overview] Message-ID: <4FD9693E.2090508@ozlabs.ru> (raw) In-Reply-To: <4FD968BB.2000505@ozlabs.ru> Normally QEMU expects the guest to initialize MSI/MSIX vectors. However on POWER the guest uses RTAS subsystem to configure MSI/MSIX and does not write these vectors to device's config space or MSIX BAR. On the other hand, msi_notify()/msix_notify() write to these vectors to signal the guest about an interrupt so we have to write correct vectors to the devices in order not to change every user of MSI/MSIX. The first aim is to support MSIX for virtio-pci on POWER. There is another patch for POWER coming which introduces a special memory region where MSI/MSIX vectors point to. Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru> --- hw/msi.c | 14 ++++++++++++++ hw/msi.h | 1 + hw/msix.c | 10 ++++++++++ hw/msix.h | 3 +++ 4 files changed, 28 insertions(+), 0 deletions(-) diff --git a/hw/msi.c b/hw/msi.c index 5d6ceb6..124878a 100644 --- a/hw/msi.c +++ b/hw/msi.c @@ -358,3 +358,17 @@ unsigned int msi_nr_vectors_allocated(const PCIDevice *dev) uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); return msi_nr_vectors(flags); } + +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data) +{ + uint16_t flags = pci_get_word(dev->config + msi_flags_off(dev)); + bool msi64bit = flags & PCI_MSI_FLAGS_64BIT; + + if (msi64bit) { + pci_set_quad(dev->config + msi_address_lo_off(dev), address); + } else { + pci_set_long(dev->config + msi_address_lo_off(dev), address); + } + pci_set_word(dev->config + msi_data_off(dev, msi64bit), data); +} + diff --git a/hw/msi.h b/hw/msi.h index 3040bb0..0acf434 100644 --- a/hw/msi.h +++ b/hw/msi.h @@ -34,6 +34,7 @@ void msi_reset(PCIDevice *dev); void msi_notify(PCIDevice *dev, unsigned int vector); void msi_write_config(PCIDevice *dev, uint32_t addr, uint32_t val, int len); unsigned int msi_nr_vectors_allocated(const PCIDevice *dev); +void msi_set_address_data(PCIDevice *dev, uint64_t address, uint16_t data); static inline bool msi_present(const PCIDevice *dev) { diff --git a/hw/msix.c b/hw/msix.c index 3835eaa..c57c299 100644 --- a/hw/msix.c +++ b/hw/msix.c @@ -414,3 +414,13 @@ void msix_unuse_all_vectors(PCIDevice *dev) return; msix_free_irq_entries(dev); } + +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data) +{ + uint8_t *table_entry = dev->msix_table_page + vector * PCI_MSIX_ENTRY_SIZE; + pci_set_quad(table_entry + PCI_MSIX_ENTRY_LOWER_ADDR, address); + pci_set_long(table_entry + PCI_MSIX_ENTRY_DATA, data); + table_entry[PCI_MSIX_ENTRY_VECTOR_CTRL] &= ~PCI_MSIX_ENTRY_CTRL_MASKBIT; +} + diff --git a/hw/msix.h b/hw/msix.h index 5aba22b..e6bb696 100644 --- a/hw/msix.h +++ b/hw/msix.h @@ -29,4 +29,7 @@ void msix_notify(PCIDevice *dev, unsigned vector); void msix_reset(PCIDevice *dev); +void msix_set_address_data(PCIDevice *dev, int vector, + uint64_t address, uint32_t data); + #endif -- 1.7.7.3
next prev parent reply other threads:[~2012-06-14 4:32 UTC|newest] Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top 2012-06-14 4:29 [Qemu-devel] [PATCH 0/3] adding MSI/MSIX for PCI on POWER Alexey Kardashevskiy 2012-06-14 4:29 ` Alexey Kardashevskiy 2012-06-14 4:31 ` Alexey Kardashevskiy [this message] 2012-06-14 4:31 ` [PATCH 1/3] msi/msix: added functions to API to set up message address and data Alexey Kardashevskiy 2012-06-14 4:56 ` [Qemu-devel] " Alex Williamson 2012-06-14 4:56 ` Alex Williamson 2012-06-14 5:17 ` Alexey Kardashevskiy 2012-06-14 5:17 ` Alexey Kardashevskiy 2012-06-14 5:38 ` Alex Williamson 2012-06-14 5:38 ` Alex Williamson 2012-06-14 5:44 ` Alexey Kardashevskiy 2012-06-14 5:44 ` Alexey Kardashevskiy 2012-06-14 18:37 ` Alex Williamson 2012-06-14 18:37 ` Alex Williamson 2012-06-14 5:45 ` Jan Kiszka 2012-06-14 5:45 ` Jan Kiszka 2012-06-21 6:46 ` [Qemu-devel] [PATCH] msi/msix: added functions to API to set up message address, " Alexey Kardashevskiy 2012-06-21 6:46 ` Alexey Kardashevskiy 2012-06-21 6:53 ` [Qemu-devel] " Jan Kiszka 2012-06-21 6:53 ` Jan Kiszka 2012-06-21 7:18 ` [Qemu-devel] [PATCH] msi/msix: added public API to set/get MSI " Alexey Kardashevskiy 2012-06-21 7:18 ` Alexey Kardashevskiy 2012-06-21 7:39 ` [Qemu-devel] " Jan Kiszka 2012-06-21 7:39 ` Jan Kiszka 2012-06-21 10:28 ` [Qemu-devel] " Alexey Kardashevskiy 2012-06-21 10:28 ` Alexey Kardashevskiy 2012-06-21 10:38 ` [Qemu-devel] " Jan Kiszka 2012-06-21 10:38 ` Jan Kiszka 2012-06-21 10:50 ` [Qemu-devel] " Alexey Kardashevskiy 2012-06-21 10:50 ` Alexey Kardashevskiy 2012-06-21 10:56 ` [Qemu-devel] " Jan Kiszka 2012-06-21 10:56 ` Jan Kiszka 2012-06-21 11:39 ` [Qemu-devel] [PATCH] msi/msix: added API to set MSI message address " Alexey Kardashevskiy 2012-06-21 11:39 ` Alexey Kardashevskiy 2012-06-21 11:49 ` [Qemu-devel] " Jan Kiszka 2012-06-21 11:49 ` Jan Kiszka 2012-06-22 1:03 ` [Qemu-devel] " Alexey Kardashevskiy 2012-06-22 1:03 ` Alexey Kardashevskiy 2012-06-22 1:15 ` [Qemu-devel] " Alexey Kardashevskiy 2012-06-22 1:15 ` Alexey Kardashevskiy 2012-07-02 4:28 ` [Qemu-devel] " Alexey Kardashevskiy 2012-07-02 4:28 ` Alexey Kardashevskiy 2012-07-02 7:24 ` [Qemu-devel] " Jan Kiszka 2012-07-02 7:24 ` Jan Kiszka 2012-07-06 15:36 ` [Qemu-devel] " Alexander Graf 2012-07-06 15:36 ` Alexander Graf 2012-07-06 15:58 ` [Qemu-devel] " Jan Kiszka 2012-07-06 15:58 ` Jan Kiszka 2012-07-11 18:22 ` [Qemu-devel] " Alexander Graf 2012-07-11 18:22 ` Alexander Graf 2012-07-18 12:43 ` [Qemu-devel] " Michael S. Tsirkin 2012-07-18 12:43 ` Michael S. Tsirkin 2012-07-18 13:17 ` [Qemu-devel] " Alexey Kardashevskiy 2012-07-18 13:17 ` Alexey Kardashevskiy 2012-07-18 15:23 ` [Qemu-devel] " Michael S. Tsirkin 2012-07-18 15:23 ` Michael S. Tsirkin 2012-07-19 0:32 ` [Qemu-devel] " Alexey Kardashevskiy 2012-07-19 0:32 ` Alexey Kardashevskiy 2012-07-19 9:27 ` [Qemu-devel] " Michael S. Tsirkin 2012-07-19 9:27 ` Michael S. Tsirkin 2012-07-19 14:24 ` [Qemu-devel] " Alexey Kardashevskiy 2012-07-19 14:43 ` Michael S. Tsirkin 2012-07-19 14:50 ` Alexey Kardashevskiy 2012-07-19 14:56 ` Michael S. Tsirkin 2012-07-19 0:35 ` Alexey Kardashevskiy 2012-07-19 9:27 ` Michael S. Tsirkin 2012-06-21 15:44 ` [Qemu-devel] [PATCH] msi/msix: added public API to set/get MSI message address, " Alex Williamson 2012-06-21 15:44 ` Alex Williamson 2012-06-14 4:33 ` [Qemu-devel] [PATCH 2/3] pseries: added allocator for a block of IRQs Alexey Kardashevskiy 2012-06-14 4:33 ` Alexey Kardashevskiy 2012-06-27 14:47 ` Alexander Graf 2012-06-14 4:34 ` [Qemu-devel] [PATCH 3/3] pseries pci: added MSI/MSIX support Alexey Kardashevskiy 2012-06-14 4:34 ` Alexey Kardashevskiy 2012-06-27 18:15 ` Alexander Graf 2012-06-14 4:42 ` [Qemu-devel] [PATCH 0/3] adding MSI/MSIX for PCI on POWER Alexey Kardashevskiy 2012-06-14 4:42 ` Alexey Kardashevskiy 2012-06-27 14:43 ` Alexander Graf 2012-06-27 21:32 ` Benjamin Herrenschmidt 2012-06-27 21:34 ` Alexander Graf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=4FD9693E.2090508@ozlabs.ru \ --to=aik@ozlabs.ru \ --cc=kvm-ppc@vger.kernel.org \ --cc=qemu-devel@nongnu.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.