From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48228) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZeN-0005nr-OU for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:45:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfZeL-0001RP-Rx for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:45:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26689) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfZeL-0001R9-JU for qemu-devel@nongnu.org; Fri, 15 Jun 2012 12:45:29 -0400 Message-ID: <4FDB66A1.10409@redhat.com> Date: Fri, 15 Jun 2012 10:45:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-2-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig417D26DD2D58EB628218A81A" Subject: Re: [Qemu-devel] [RFC PATCH 01/36] qapi: generalize documentation of streaming commands List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig417D26DD2D58EB628218A81A Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > Talk about background operations in general, rather than specifically > about streaming. >=20 > Signed-off-by: Paolo Bonzini > --- > hmp-commands.hx | 2 +- > qapi-schema.json | 17 ++++++++--------- > 2 files changed, 9 insertions(+), 10 deletions(-) >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > index f5d9d91..26a4d8d 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -101,7 +101,7 @@ ETEXI > .name =3D "block_job_cancel", > .args_type =3D "device:B", > .params =3D "device", > - .help =3D "stop an active block streaming operation", > + .help =3D "stop an active background block operation", Reviewed-by: Eric Blake > # > -# The image file retains its backing file unless the streaming operati= on happens > -# to complete just as it is being cancelled. > -# > -# A new block streaming operation can be started at a later time to fi= nish > -# copying all data from the backing file. > +# For streaming, the image file retains its backing file unless the st= reaming > +# operation happens to complete just as it is being cancelled. A new = streaming Pre-existing, but do we have any policy on US (canceled) vs. UK (cancelled) spelling? Obviously, our API spelling is locked into UK spelling, but if the docs generally prefer US spelling, do we need to adjust things here? But any such adjustments should be separate commits, so no impact to my reviewed-by. --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig417D26DD2D58EB628218A81A Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP22ahAAoJEKeha0olJ0NqxesH/j/lnWJoO4ASzjn8uhiiDDrj IBeYapLK+W/E9ghQnzTxExs/UJ+LIwb/IxwGTNoh4GNDfUZ3oysGg6SFgRImyHLp Rk52BJhiixBf+1uW5lNBf/4M4el/dnvCanoWuwJbgz8TXIiDnrwhs7doq5zFPeHY RWgWc1nYkBhFHtfK1UqyF8stFJWH45J1kz6RIHcrNVsGjb9o2FFc+Ue8auBJXbwu zef8Y+61V3jEYZhFqBoYRh6nKw44UZfO/B2D6d1ZwyJD6ZpWHorzNFvs3LIeKi1k 4qiuBTdksIiQnGSXp1AfgkbWLcistzgqCokNzNN6wH7Qy8lMTz7huaNsFMCs+Dw= =XYqZ -----END PGP SIGNATURE----- --------------enig417D26DD2D58EB628218A81A--