From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42466) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfaez-00036r-N8 for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:50:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sfaex-0002xK-SE for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:50:13 -0400 Received: from mx1.redhat.com ([209.132.183.28]:15032) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sfaex-0002x6-KB for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:50:11 -0400 Message-ID: <4FDB75CF.6000004@redhat.com> Date: Fri, 15 Jun 2012 11:50:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-14-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-14-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig292932472A9294B15034D3F2" Subject: Re: [Qemu-devel] [RFC PATCH 13/36] block: introduce block job error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig292932472A9294B15034D3F2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > The following behaviors are possible: >=20 > 'report': The behavior is the same as in 1.1. An I/O error, > respectively during a read or a write, will complete the job immediatel= y > with an error code. >=20 > 'ignore': An I/O error, respectively during a read or a write, will be > ignored. For streaming, the job will complete with an error and the > backing file will be left in place. For mirroring, the sector will be > marked again as dirty and re-examined later. >=20 > 'stop': The job will be paused and the job iostatus will be set to > failed or nospace, while the VM will keep running. This can only be > specified if the block device has rerror=3Dstop and werror=3Dstop or en= ospc. >=20 > 'enospc': Behaves as 'stop' for ENOSPC errors, 'report' for others. >=20 > In all cases, even for 'report', the I/O error is reported as a QMP > event BLOCK_JOB_ERROR, with the same arguments as BLOCK_IO_ERROR. Looks reasonable. > +++ b/qapi-schema.json > @@ -935,11 +935,14 @@ > # > # @speed: the rate limit, bytes per second > # > +# @io-status: the status of the job > +# > # Since: 1.1 > ## > { 'type': 'BlockJobInfo', > 'data': {'type': 'str', 'device': 'str', 'len': 'int', > - 'offset': 'int', 'paused': 'bool', 'speed': 'int'} } > + 'offset': 'int', 'paused': 'bool', 'speed': 'int', > + 'io-status': 'BlockDeviceIoStatus'} } Again, when adding members to output-only types compared to a previous release, should we be marking the additions as optional, as in: '*io-status': 'BlockDeviceIoStatus' to indicate that the member may not be present when talking to older qemu= ? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig292932472A9294B15034D3F2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP23XPAAoJEKeha0olJ0NqQHMH/RH5tSdwauJBFv67ciBRhSKH d4Ze5mrivzk4F2/3gkq+DGfyfGz+7AJb1t1PuJTjtIySpyoHfaANpfPYeRsnwZ+M GLZy/kT17sEWrJjd2eeTHbZHGYgBsjoPwswthL290iP5Shtgbb2bgiZKd3z5e2dj 6A9mvy9w80ZqmGSOJFhYGF0QIrgX8i7jFIgob9zvc8HHkbyyddEdYKO6CT2H2chi P3hKddeUwteiL0RhYIi3qDBKP5McqaD1g4Hqd5ACsiO90kGzAVnQCzFsjSc/EnXR tXRG9Pj/D4Khr+9mZCmT4bBCxp+igj9Tb3pxNNqXO+zG1+Ap8m21poFl6JpXqmw= =oVAa -----END PGP SIGNATURE----- --------------enig292932472A9294B15034D3F2--