From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38373) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfanG-0005pl-6x for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:58:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SfanE-0006Sa-9h for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:58:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:7483) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SfanE-0006Qx-1A for qemu-devel@nongnu.org; Fri, 15 Jun 2012 13:58:44 -0400 Message-ID: <4FDB77CF.8000906@redhat.com> Date: Fri, 15 Jun 2012 11:58:39 -0600 From: Eric Blake MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-15-git-send-email-pbonzini@redhat.com> In-Reply-To: <1339772759-31004-15-git-send-email-pbonzini@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------enig61D6EDDFF484CB93AEF9692D" Subject: Re: [Qemu-devel] [RFC PATCH 14/36] stream: add on_error argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig61D6EDDFF484CB93AEF9692D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 06/15/2012 09:05 AM, Paolo Bonzini wrote: > This patch adds support for error management to streaming. >=20 > Signed-off-by: Paolo Bonzini > --- > block/stream.c | 28 +++++++++++++++++++++++++++- > block_int.h | 3 ++- > blockdev.c | 11 ++++++++--- > hmp.c | 3 ++- > qapi-schema.json | 9 ++++++--- > qmp-commands.hx | 2 +- > 6 files changed, 46 insertions(+), 10 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -1650,6 +1650,8 @@ > # > # @speed: #optional the maximum speed, in bytes per second > # > +# @on_error: #optional the action to take on an error (default report)= > +# > # Returns: Nothing on success > # If streaming is already active on this device, DeviceInUse > # If @device does not exist, DeviceNotFound > @@ -1657,10 +1659,11 @@ > # If @base does not exist, BaseNotFound > # If @speed is invalid, InvalidParameter Should you mention the possibility of the new QERR_INVALID_PARAMETER_COMBINATION error when on_error requests an action that the device doesn't support? > # > -# Since: 1.1 > +# Since: 1.1, on_error since 1.2 First instance of a double since. I like the idea; should we be using it in more places? --=20 Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --------------enig61D6EDDFF484CB93AEF9692D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.12 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iQEcBAEBCAAGBQJP23fPAAoJEKeha0olJ0NqaA4H/jW7NDSdOBCIjFB1azhdqO2M F+WCDoX+BdJrqJHgmBTQ/lwmPsl+Adr4qdxdC+AC32fEde8MQjLdPysfDj6g8AsU AQvn4OIUIHi30ZvGGByw0A686xRS/J9tof61AaoNL3x7CVSWGqayrBUi56gdbDE0 RLboqFC5nEQ14aepWMuunWb4TLSHV71lbaF08e7LycCeJDMMDylXdxUs6ZyI6U81 8hlxhq+6teJmrroMJknJFmSzm39fDsFmd36rc4mDay9445KKR8L44k95XvQBTz+n BZaGk2TQRD0iWJoOfR7VJ8NjaSXPZgWRxtFoO3nC1ajTo9K0JmrRAAogU+D2OPk= =249g -----END PGP SIGNATURE----- --------------enig61D6EDDFF484CB93AEF9692D--