On 06/27/2012 01:22 PM, Shawn Guo wrote: > On 27 June 2012 17:55, Hui Wang wrote: >> After read and compared with his patch: >> 1. Shawn use gpio_is_valid(gpio) instead of (gpio >= 0), it is good. >> 2. Shawn add a flag to record active level, it is good. >> 3. Shawn only add 1 gpio, this is not enough for imx6 sabre lite board. >> 4. Shawn forget to call gpio_release() > > I'm about to resend my series to have linux-can copied and use > devm_gpio_request_one instead. Do you want me to add STBY gpio > support into my patch? devm is a good idea. Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |