From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53227) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SozbE-0007pQ-Fs for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:17:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sozb9-0000GL-5I for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:17:11 -0400 Received: from mail-pb0-f45.google.com ([209.85.160.45]:53339) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sozb8-0000Ft-Sp for qemu-devel@nongnu.org; Wed, 11 Jul 2012 12:17:07 -0400 Received: by pbbro12 with SMTP id ro12so2344933pbb.4 for ; Wed, 11 Jul 2012 09:17:04 -0700 (PDT) Sender: Paolo Bonzini Message-ID: <4FFDA6FA.6070703@redhat.com> Date: Wed, 11 Jul 2012 18:16:58 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-27-git-send-email-pbonzini@redhat.com> <4FDBA5D2.5020209@redhat.com> In-Reply-To: <4FDBA5D2.5020209@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 26/36] block: live snapshot documentation tweaks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com, lcapitulino@redhat.com Il 15/06/2012 23:14, Eric Blake ha scritto: > On 06/15/2012 09:05 AM, Paolo Bonzini wrote: >> Signed-off-by: Paolo Bonzini >> --- >> qapi-schema.json | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/qapi-schema.json b/qapi-schema.json >> index 2ee988b..250edf2 100644 >> --- a/qapi-schema.json >> +++ b/qapi-schema.json >> @@ -1289,6 +1289,7 @@ >> # >> # Returns: nothing on success >> # If @device is not a valid block device, DeviceNotFound >> +# If the block device has no medium inserted, DeviceHasNoMedium >> # If @device is busy, DeviceInUse will be returned >> # If @snapshot-file can't be created, OpenFileFailed >> # If @snapshot-file can't be opened, OpenFileFailed > > Can we combine these? > > If @snapshot-file can't be opened or created, OpenFileFailed > >> @@ -1321,6 +1322,9 @@ >> # >> # Returns: nothing on success >> # If @device is not a valid block device, DeviceNotFound >> +# If the block device has no medium inserted, DeviceHasNoMedium >> +# If @device is busy, DeviceInUse will be returned >> +# If @snapshot-file can't be created, OpenFileFailed >> # If @snapshot-file can't be opened, OpenFileFailed > > and again. > Yes, done. Paolo