From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:48993)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sp1mO-0005dB-Vx
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 14:36:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sp1mN-0008CW-JP
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 14:36:52 -0400
Received: from mx1.redhat.com ([209.132.183.28]:26240)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1Sp1mN-0008CR-Bb
	for qemu-devel@nongnu.org; Wed, 11 Jul 2012 14:36:51 -0400
Message-ID: <4FFDA9A5.30500@redhat.com>
Date: Wed, 11 Jul 2012 18:28:21 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com>
	<1339772759-31004-26-git-send-email-pbonzini@redhat.com>
	<4FDBA535.7000008@redhat.com>
In-Reply-To: <4FDBA535.7000008@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC PATCH 25/36] mirror: add support for
	on_source_error/on_target_error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eric Blake <eblake@redhat.com>
Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com

Il 15/06/2012 23:12, Eric Blake ha scritto:
>> > +#
>> >  # Returns: nothing on success
>> >  #          If @device is not a valid block device, DeviceNotFound
>> >  #          If @target can't be opened, OpenFileFailed
>> > @@ -1389,7 +1393,8 @@
>> >  { 'command': 'drive-mirror',
>> >    'data': { 'device': 'str', 'target': 'str', '*format': 'str',
>> >              'sync': 'MirrorSyncMode', '*mode': 'NewImageMode',
>> > -            '*speed': 'int' } }
>> > +            '*speed': 'int', '*on_source_error': 'BlockdevOnError',
>> > +            '*on_target_error': 'BlockdevOnError' } }
> QMP should prefer - over _; shouldn't this be '*on-source-error' and
> '*on-target-error'?

Will fix.

Paolo