From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48966) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp1mK-0005Vi-LZ for qemu-devel@nongnu.org; Wed, 11 Jul 2012 14:36:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sp1mJ-0008Bl-Pv for qemu-devel@nongnu.org; Wed, 11 Jul 2012 14:36:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:62740) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sp1mJ-0008BX-IP for qemu-devel@nongnu.org; Wed, 11 Jul 2012 14:36:47 -0400 Message-ID: <4FFDAB4F.5020405@redhat.com> Date: Wed, 11 Jul 2012 18:35:27 +0200 From: Paolo Bonzini MIME-Version: 1.0 References: <1339772759-31004-1-git-send-email-pbonzini@redhat.com> <1339772759-31004-31-git-send-email-pbonzini@redhat.com> <4FDBBF0D.5090607@redhat.com> In-Reply-To: <4FDBBF0D.5090607@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH 30/36] add hierarchical bitmap data type and test cases List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: kwolf@redhat.com, lcapitulino@redhat.com, qemu-devel@nongnu.org, stefanha@linux.vnet.ibm.com Il 16/06/2012 01:02, Eric Blake ha scritto: >> > + unsigned long *levels[HBITMAP_LEVELS]; > and at this point, I decided reading the .h first makes more sense. > Also, this is a high-level first-impressions review, not a line-by-line > algorithmic accuracy review. Did you invent this yourself, or copy from > the ideas from a published work? I came up with this, and actually the comment is wrong because the complexity is log32 N or log64 N, not log log N. I first tried to go for doubly logarithmic, but it didn't make much sense. Paolo