From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64260C433E0 for ; Sun, 27 Dec 2020 16:52:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C9E5E22512 for ; Sun, 27 Dec 2020 16:52:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C9E5E22512 Authentication-Results: mail.kernel.org; dmarc=pass (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:42558 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ktZHN-0000zt-VR for qemu-devel@archiver.kernel.org; Sun, 27 Dec 2020 11:52:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktZCD-00065H-2a for qemu-devel@nongnu.org; Sun, 27 Dec 2020 11:47:05 -0500 Received: from zero.eik.bme.hu ([152.66.115.2]:26176) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ktZCB-0005Or-HK for qemu-devel@nongnu.org; Sun, 27 Dec 2020 11:47:04 -0500 Received: from zero.eik.bme.hu (blah.eik.bme.hu [152.66.115.182]) by localhost (Postfix) with SMTP id A47117470DB; Sun, 27 Dec 2020 17:47:01 +0100 (CET) Received: by zero.eik.bme.hu (Postfix, from userid 432) id 217C274646C; Sun, 27 Dec 2020 17:47:01 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zero.eik.bme.hu (Postfix) with ESMTP id 204F874645F; Sun, 27 Dec 2020 17:47:01 +0100 (CET) Date: Sun, 27 Dec 2020 17:47:01 +0100 (CET) To: =?ISO-8859-15?Q?Philippe_Mathieu-Daud=E9?= Subject: Re: [PATCH 06/12] audio/via-ac97: Simplify code and set user_creatable to false In-Reply-To: <59478f83-35ab-6610-5233-dd300fc8cb27@amsat.org> Message-ID: <4a618736-44bb-ccf3-b5bd-e443ab5502b@eik.bme.hu> References: <717bd2ed67a42476fdb4c6132d7c351eb9f54282.1609031406.git.balaton@eik.bme.hu> <59478f83-35ab-6610-5233-dd300fc8cb27@amsat.org> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="3866299591-437266030-1609087621=:84491" Received-SPF: pass client-ip=152.66.115.2; envelope-from=balaton@eik.bme.hu; helo=zero.eik.bme.hu X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Huacai Chen , qemu-devel@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Reply-to: BALATON Zoltan From: BALATON Zoltan via This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --3866299591-437266030-1609087621=:84491 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8BIT On Sun, 27 Dec 2020, Philippe Mathieu-Daudé wrote: > Hi Zoltan, > > On 12/27/20 2:10 AM, BALATON Zoltan via wrote: >> Remove some unneded, empty code and set user_creatable to false >> (besides being not implemented yet, so does nothing anyway) it's also >> normally part of VIA south bridge chips so no need to confuse users >> showing them these devices. > > After contributing during more than 8 years you should know we try > to avoid to do multiples changes in the same patch ;) Yes, in my understanding patches should be split if - it makes bisecting easier or - makes reviewing easier Which of the above appies in this case? I think these are changes that should neither brake anything (as this device doesn't don't do anyting yet) and adding user_creatable false is a one line change that's easy to review even with the other changes. If you insist I can split this into two but I didn't think that would be any better and the series was long enough already. Regards, BALATON Zoltan >> >> Signed-off-by: BALATON Zoltan >> --- >> hw/audio/via-ac97.c | 51 +++++++++++++++++---------------------------- >> 1 file changed, 19 insertions(+), 32 deletions(-) > > --3866299591-437266030-1609087621=:84491--