All of lore.kernel.org
 help / color / mirror / Atom feed
From: "kai" <kai.kang@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [OE-core] [PATCH v2 1/1] Customize prompt string for SDKs
Date: Mon, 22 Feb 2021 09:46:00 +0800	[thread overview]
Message-ID: <4a696ed8-9cd1-4486-19b3-2a738e9e21dd@windriver.com> (raw)
In-Reply-To: <16581C35A2764503.27524@lists.openembedded.org>

[-- Attachment #1: Type: text/plain, Size: 2932 bytes --]

On 1/8/21 9:02 AM, kai wrote:
> From: Kai Kang <kai.kang@windriver.com>
>
> Introduce a new variable SDK_PS1 to customize prompt string for SDKs
> when source script environment-setup-script. The prompt string of SDKs
> is set by default with something looks like:
>
> SDK-poky-glibc-x86_64--cortexa57-qemuarm64$

Hi Richard,

It has been in master-next for a long time. Any concern about it please?

Regards,
Kai

>
> Signed-off-by: Kai Kang <kai.kang@windriver.com>
> ---
>   meta/classes/toolchain-scripts.bbclass       | 1 +
>   meta/conf/bitbake.conf                       | 1 +
>   meta/recipes-core/meta/buildtools-tarball.bb | 1 +
>   3 files changed, 3 insertions(+)
>
> diff --git a/meta/classes/toolchain-scripts.bbclass b/meta/classes/toolchain-scripts.bbclass
> index db1d3215ef..88df373d0b 100644
> --- a/meta/classes/toolchain-scripts.bbclass
> +++ b/meta/classes/toolchain-scripts.bbclass
> @@ -45,6 +45,7 @@ toolchain_create_sdk_env_script () {
>   		EXTRAPATH="$EXTRAPATH:$sdkpathnative$bindir/${TARGET_ARCH}${TARGET_VENDOR}-$i"
>   	done
>   	echo "export PATH=$sdkpathnative$bindir:$sdkpathnative$sbindir:$sdkpathnative$base_bindir:$sdkpathnative$base_sbindir:$sdkpathnative$bindir/../${HOST_SYS}/bin:$sdkpathnative$bindir/${TARGET_SYS}"$EXTRAPATH':$PATH' >> $script
> +	echo 'export PS1="${SDK_PS1}"' >>$script
>   	echo 'export PKG_CONFIG_SYSROOT_DIR=$SDKTARGETSYSROOT' >> $script
>   	echo 'export PKG_CONFIG_PATH=$SDKTARGETSYSROOT'"$libdir"'/pkgconfig:$SDKTARGETSYSROOT'"$prefix"'/share/pkgconfig' >> $script
>   	echo 'export CONFIG_SITE=${SDKPATH}/site-config-'"${multimach_target_sys}" >> $script
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index a04005b0f5..93687f9950 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -424,6 +424,7 @@ PKGDATA_DIR = "${TMPDIR}/pkgdata/${MACHINE}"
>   
>   SDK_NAME_PREFIX ?= "oecore"
>   SDK_NAME = "${SDK_NAME_PREFIX}-${SDK_ARCH}-${TUNE_PKGARCH}"
> +SDK_PS1 ?= "SDK-${SDK_NAME}:\\\\$ "
>   SDKPATH = "/usr/local/${SDK_NAME_PREFIX}-${SDK_ARCH}"
>   SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"
>   
> diff --git a/meta/recipes-core/meta/buildtools-tarball.bb b/meta/recipes-core/meta/buildtools-tarball.bb
> index 9da81d5523..59cfc64ce8 100644
> --- a/meta/recipes-core/meta/buildtools-tarball.bb
> +++ b/meta/recipes-core/meta/buildtools-tarball.bb
> @@ -71,6 +71,7 @@ create_sdk_files_append () {
>   	echo 'export OECORE_NATIVE_SYSROOT="${SDKPATHNATIVE}"' >> $script
>   	echo 'export GIT_SSL_CAINFO="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script
>   	echo 'export SSL_CERT_FILE="${SDKPATHNATIVE}${sysconfdir}/ssl/certs/ca-certificates.crt"' >>$script
> +	echo 'export PS1="${SDK_PS1}"' >>$script
>   
>   	toolchain_create_sdk_version ${SDK_OUTPUT}/${SDKPATH}/version-${SDK_SYS}
>   
>
> 
>

-- 
Kai Kang
Wind River Linux


[-- Attachment #2: Type: text/html, Size: 3902 bytes --]

      parent reply	other threads:[~2021-02-22  1:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-08  1:02 [PATCH v2 0/1] Customize prompt string for SDKs kai
2021-01-08  1:02 ` [PATCH v2 1/1] " kai
     [not found] ` <16581C35A2764503.27524@lists.openembedded.org>
2021-02-22  1:46   ` kai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4a696ed8-9cd1-4486-19b3-2a738e9e21dd@windriver.com \
    --to=kai.kang@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.