All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/5] ARM: rpi_3_32b_defconfig: Add FS_UUID command
Date: Tue, 23 Oct 2018 08:33:20 +0100	[thread overview]
Message-ID: <4c96db2c-df68-e2fb-89e1-18fba8ae87c3@suse.de> (raw)
In-Reply-To: <20181023063822.27896-2-otavio@ossystems.com.br>



On 23.10.18 07:38, Otavio Salvador wrote:
> From: Fabio Berton <fabio.berton@ossystems.com.br>

Thanks a lot for the patch :). However, as it is it will be confusing
for people who read the git log to figure out why this patch is in the
tree and what its net effect is.

So could you please provide a proper patch description that explains:

  1) Why do you need the config flag?
  2) Why isn't it set already?
  3) Why are you only touching the 32b defconfig?


Thanks,

Alex

> 
> Signed-off-by: Fabio Berton <fabio.berton@ossystems.com.br>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> ---
> 
>  configs/rpi_3_32b_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/configs/rpi_3_32b_defconfig b/configs/rpi_3_32b_defconfig
> index d3d4596ba0..33c476bb4f 100644
> --- a/configs/rpi_3_32b_defconfig
> +++ b/configs/rpi_3_32b_defconfig
> @@ -14,6 +14,7 @@ CONFIG_SYS_PROMPT="U-Boot> "
>  CONFIG_CMD_GPIO=y
>  CONFIG_CMD_MMC=y
>  CONFIG_CMD_USB=y
> +CONFIG_CMD_FS_UUID=y
>  CONFIG_OF_EMBED=y
>  CONFIG_DEFAULT_DEVICE_TREE="bcm2837-rpi-3-b"
>  CONFIG_ENV_FAT_INTERFACE="mmc"
> 

  reply	other threads:[~2018-10-23  7:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-23  6:38 [U-Boot] [PATCH 1/5] ARM: vexpress-ca9x4_defconfig: Enable CMD_UBI support Otavio Salvador
2018-10-23  6:38 ` [U-Boot] [PATCH 2/5] ARM: rpi_3_32b_defconfig: Add FS_UUID command Otavio Salvador
2018-10-23  7:33   ` Alexander Graf [this message]
2018-10-23 13:36     ` Otavio Salvador
2018-10-23  6:38 ` [U-Boot] [PATCH 3/5] clk_rv1108: Sync with vendor tree Otavio Salvador
2018-10-23  6:38 ` [U-Boot] [PATCH 4/5] rv1108: Enable eMMC support Otavio Salvador
2018-10-23  6:38 ` [U-Boot] [PATCH 5/5] rv1108: Make USB OTG functional Otavio Salvador
2018-10-23  7:26 ` [U-Boot] [PATCH 1/5] ARM: vexpress-ca9x4_defconfig: Enable CMD_UBI support Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c96db2c-df68-e2fb-89e1-18fba8ae87c3@suse.de \
    --to=agraf@suse.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.