From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96B99C5DF60 for ; Fri, 8 Nov 2019 10:58:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7210A21924 for ; Fri, 8 Nov 2019 10:58:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729873AbfKHK57 (ORCPT ); Fri, 8 Nov 2019 05:57:59 -0500 Received: from s3.sipsolutions.net ([144.76.43.62]:54884 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726149AbfKHK57 (ORCPT ); Fri, 8 Nov 2019 05:57:59 -0500 Received: by sipsolutions.net with esmtpsa (TLS1.3:ECDHE_SECP256R1__RSA_PSS_RSAE_SHA256__AES_256_GCM:256) (Exim 4.92.3) (envelope-from ) id 1iT1xk-00006s-GM; Fri, 08 Nov 2019 11:57:56 +0100 Message-ID: <4ce4c199522ef112362efb8db8823e31d5c41944.camel@sipsolutions.net> Subject: Re: [PATCH v6 2/4] mac80211: Import airtime calculation code from mt76 From: Johannes Berg To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: linux-wireless@vger.kernel.org, make-wifi-fast@lists.bufferbloat.net, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau , Kan Yan , Rajkumar Manoharan , Kevin Hayes Date: Fri, 08 Nov 2019 11:57:54 +0100 In-Reply-To: <87d0e2fxi0.fsf@toke.dk> References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474174.150713.17459330922820192258.stgit@toke.dk> <42266e95f45d5772e04c9c016bd6179ea14ffefa.camel@sipsolutions.net> <87d0e2fxi0.fsf@toke.dk> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.30.5 (3.30.5-1.fc29) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-wireless-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Fri, 2019-11-08 at 11:55 +0100, Toke Høiland-Jørgensen wrote: > Johannes Berg writes: > > > On Wed, 2019-10-23 at 11:59 +0200, Toke Høiland-Jørgensen wrote: > > > From: Toke Høiland-Jørgensen > > > > > > Felix recently added code to calculate airtime of packets to the mt76 > > > driver. Import this into mac80211 so we can use it for airtime queue limit > > > calculations later. > > > > > > The airtime.c file is copied verbatim from the mt76 driver, and adjusted to > > > use mac80211 data structures instead (which is fairly straight forward). > > > The per-rate TX rate calculation is split out to its own > > > function (ieee80211_calc_tx_airtime_rate()) so it can be used directly for > > > the AQL calculations added in a subsequent patch. > > > > Any way it could be exposed by mac80211 back to the drivers, perhaps, to > > share it? > > Didn't I already export some of the functions? My intention was to do > that, certainly, and to patch mt76 to switch to using them once the > trees have converged... Yeah, I think you did. Sounds good. johannes From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([2a01:4f8:191:4433::2] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iT1xo-0004qt-Ik for ath10k@lists.infradead.org; Fri, 08 Nov 2019 10:58:01 +0000 Message-ID: <4ce4c199522ef112362efb8db8823e31d5c41944.camel@sipsolutions.net> Subject: Re: [PATCH v6 2/4] mac80211: Import airtime calculation code from mt76 From: Johannes Berg Date: Fri, 08 Nov 2019 11:57:54 +0100 In-Reply-To: <87d0e2fxi0.fsf@toke.dk> References: <157182473951.150713.7978051149956899705.stgit@toke.dk> <157182474174.150713.17459330922820192258.stgit@toke.dk> <42266e95f45d5772e04c9c016bd6179ea14ffefa.camel@sipsolutions.net> <87d0e2fxi0.fsf@toke.dk> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Toke =?ISO-8859-1?Q?H=F8iland-J=F8rgensen?= Cc: Kan Yan , Rajkumar Manoharan , Kevin Hayes , make-wifi-fast@lists.bufferbloat.net, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org, John Crispin , Lorenzo Bianconi , Felix Fietkau T24gRnJpLCAyMDE5LTExLTA4IGF0IDExOjU1ICswMTAwLCBUb2tlIEjDuGlsYW5kLUrDuHJnZW5z ZW4gd3JvdGU6Cj4gSm9oYW5uZXMgQmVyZyA8am9oYW5uZXNAc2lwc29sdXRpb25zLm5ldD4gd3Jp dGVzOgo+IAo+ID4gT24gV2VkLCAyMDE5LTEwLTIzIGF0IDExOjU5ICswMjAwLCBUb2tlIEjDuGls YW5kLUrDuHJnZW5zZW4gd3JvdGU6Cj4gPiA+IEZyb206IFRva2UgSMO4aWxhbmQtSsO4cmdlbnNl biA8dG9rZUByZWRoYXQuY29tPgo+ID4gPiAKPiA+ID4gRmVsaXggcmVjZW50bHkgYWRkZWQgY29k ZSB0byBjYWxjdWxhdGUgYWlydGltZSBvZiBwYWNrZXRzIHRvIHRoZSBtdDc2Cj4gPiA+IGRyaXZl ci4gSW1wb3J0IHRoaXMgaW50byBtYWM4MDIxMSBzbyB3ZSBjYW4gdXNlIGl0IGZvciBhaXJ0aW1l IHF1ZXVlIGxpbWl0Cj4gPiA+IGNhbGN1bGF0aW9ucyBsYXRlci4KPiA+ID4gCj4gPiA+IFRoZSBh aXJ0aW1lLmMgZmlsZSBpcyBjb3BpZWQgdmVyYmF0aW0gZnJvbSB0aGUgbXQ3NiBkcml2ZXIsIGFu ZCBhZGp1c3RlZCB0bwo+ID4gPiB1c2UgbWFjODAyMTEgZGF0YSBzdHJ1Y3R1cmVzIGluc3RlYWQg KHdoaWNoIGlzIGZhaXJseSBzdHJhaWdodCBmb3J3YXJkKS4KPiA+ID4gVGhlIHBlci1yYXRlIFRY IHJhdGUgY2FsY3VsYXRpb24gaXMgc3BsaXQgb3V0IHRvIGl0cyBvd24KPiA+ID4gZnVuY3Rpb24g KGllZWU4MDIxMV9jYWxjX3R4X2FpcnRpbWVfcmF0ZSgpKSBzbyBpdCBjYW4gYmUgdXNlZCBkaXJl Y3RseSBmb3IKPiA+ID4gdGhlIEFRTCBjYWxjdWxhdGlvbnMgYWRkZWQgaW4gYSBzdWJzZXF1ZW50 IHBhdGNoLgo+ID4gCj4gPiBBbnkgd2F5IGl0IGNvdWxkIGJlIGV4cG9zZWQgYnkgbWFjODAyMTEg YmFjayB0byB0aGUgZHJpdmVycywgcGVyaGFwcywgdG8KPiA+IHNoYXJlIGl0Pwo+IAo+IERpZG4n dCBJIGFscmVhZHkgZXhwb3J0IHNvbWUgb2YgdGhlIGZ1bmN0aW9ucz8gTXkgaW50ZW50aW9uIHdh cyB0byBkbwo+IHRoYXQsIGNlcnRhaW5seSwgYW5kIHRvIHBhdGNoIG10NzYgdG8gc3dpdGNoIHRv IHVzaW5nIHRoZW0gb25jZSB0aGUKPiB0cmVlcyBoYXZlIGNvbnZlcmdlZC4uLgoKWWVhaCwgSSB0 aGluayB5b3UgZGlkLiBTb3VuZHMgZ29vZC4KCmpvaGFubmVzCgoKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRoMTBrIG1haWxpbmcgbGlzdAphdGgxMGtA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2F0aDEwawo=