All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Menzel <pmenzel+amd-gfx-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org>
To: Aaron Liu <Aaron.Liu-5C7GfCeVMHo@public.gmane.org>
Cc: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
Subject: Re: [[PATCH v2]drm/amdgpu/psp: ignore psp reponse status] drm/amdgpu/psp: ignore psp reponse status
Date: Tue, 15 Jan 2019 12:07:26 +0100	[thread overview]
Message-ID: <4e208ce3-afef-fa24-d17d-28cd0e95f3f6@molgen.mpg.de> (raw)
In-Reply-To: <DM6PR12MB361131D6DD69B1A720F7A265F0810-lmeGfMZKVrGUZgGQSl7qawdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 782 bytes --]

Dear Aaron,


On 01/15/19 07:30, Liu, Aaron wrote:

> The psp code only support ucode loading at the beginning, but forgot
> to remove the checking when more and more PSP command get into PSP.

I didn’t know that, and missed that your patch is not only about
microcode loading.

> So some old PSP FW maybe have problem but PSP driver didn’t find it
> out. If reverting the patch, we also can’t find out wrong PSP FW and
> have big problem when support new PSP command.

Understood.

> The temporary solution is: do not return error if response is invalid
> but add warning message to notify, it will not block old FW and get
> attention if new PSP FW have some issue.
There is still a small typo in *response* in the summary.


Kind regards,

Paul


[-- Attachment #1.2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 5174 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

      parent reply	other threads:[~2019-01-15 11:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-14  8:47 [[PATCH v2]drm/amdgpu/psp: ignore psp reponse status] drm/amdgpu/psp: ignore psp reponse status Aaron Liu
     [not found] ` <1547455677-7074-1-git-send-email-aaron.liu-5C7GfCeVMHo@public.gmane.org>
2019-01-14 13:23   ` Paul Menzel
     [not found]     ` <a4b67076-9903-30ed-9478-71cdbac54327-KUpvgZVWgV9o1qOY/usvUg@public.gmane.org>
2019-01-15  6:30       ` Liu, Aaron
     [not found]         ` <DM6PR12MB361131D6DD69B1A720F7A265F0810-lmeGfMZKVrGUZgGQSl7qawdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
2019-01-15 11:07           ` Paul Menzel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e208ce3-afef-fa24-d17d-28cd0e95f3f6@molgen.mpg.de \
    --to=pmenzel+amd-gfx-kupvgzvwgv9o1qoy/usvug@public.gmane.org \
    --cc=Aaron.Liu-5C7GfCeVMHo@public.gmane.org \
    --cc=amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.