From: Hans Verkuil <hverkuil@xs4all.nl>
To: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>,
Dmitry Osipenko <digetx@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, outreachy-kernel@googlegroups.com
Subject: Re: [PATCH] staging: media: tegra-vde: Align line break to match with the open parenthesis in file trace.h
Date: Tue, 13 Apr 2021 17:38:21 +0200 [thread overview]
Message-ID: <4e67a6e9-b400-7447-2cd7-6b60230882d0@xs4all.nl> (raw)
In-Reply-To: <20210412222040.GA13659@focaruja>
Hi Aline,
On 13/04/2021 00:20, Aline Santana Cordeiro wrote:
> Align line break to match with the open parenthesis.
> Issue detected by checkpatch.pl.
> It consequently solved a few end lines with a '(',
> issue also detected by checkpatch.pl
These trace headers are almost a language by themselves, and the
usual alignment rules do not apply. Look at other existing trace.h files
in the kernel and you'll see that they have their own coding style.
So I prefer not to apply this patch.
You couldn't have known that, so it's not your fault.
Regards,
Hans
>
> Signed-off-by: Aline Santana Cordeiro <alinesantanacordeiro@gmail.com>
> ---
> drivers/staging/media/tegra-vde/trace.h | 111 ++++++++++++++------------------
> 1 file changed, 50 insertions(+), 61 deletions(-)
>
> diff --git a/drivers/staging/media/tegra-vde/trace.h b/drivers/staging/media/tegra-vde/trace.h
> index e571410..1fcc573 100644
> --- a/drivers/staging/media/tegra-vde/trace.h
> +++ b/drivers/staging/media/tegra-vde/trace.h
> @@ -11,79 +11,68 @@
> #include "vde.h"
>
> DECLARE_EVENT_CLASS(register_access,
> - TP_PROTO(struct tegra_vde *vde, void __iomem *base,
> - u32 offset, u32 value),
> - TP_ARGS(vde, base, offset, value),
> - TP_STRUCT__entry(
> - __string(hw_name, tegra_vde_reg_base_name(vde, base))
> - __field(u32, offset)
> - __field(u32, value)
> - ),
> - TP_fast_assign(
> - __assign_str(hw_name, tegra_vde_reg_base_name(vde, base));
> - __entry->offset = offset;
> - __entry->value = value;
> - ),
> - TP_printk("%s:0x%03x 0x%08x", __get_str(hw_name), __entry->offset,
> - __entry->value)
> + TP_PROTO(struct tegra_vde *vde, void __iomem *base,
> + u32 offset, u32 value),
> + TP_ARGS(vde, base, offset, value),
> + TP_STRUCT__entry(__string(hw_name, tegra_vde_reg_base_name(vde, base))
> + __field(u32, offset)
> + __field(u32, value)
> + ),
> + TP_fast_assign(__assign_str(hw_name,
> + tegra_vde_reg_base_name(vde, base));
> + __entry->offset = offset;
> + __entry->value = value;
> + ),
> + TP_printk("%s:0x%03x 0x%08x", __get_str(hw_name), __entry->offset,
> + __entry->value)
> );
>
> DEFINE_EVENT(register_access, vde_writel,
> - TP_PROTO(struct tegra_vde *vde, void __iomem *base,
> - u32 offset, u32 value),
> - TP_ARGS(vde, base, offset, value));
> + TP_PROTO(struct tegra_vde *vde, void __iomem *base,
> + u32 offset, u32 value),
> + TP_ARGS(vde, base, offset, value));
> DEFINE_EVENT(register_access, vde_readl,
> - TP_PROTO(struct tegra_vde *vde, void __iomem *base,
> - u32 offset, u32 value),
> - TP_ARGS(vde, base, offset, value));
> + TP_PROTO(struct tegra_vde *vde, void __iomem *base,
> + u32 offset, u32 value),
> + TP_ARGS(vde, base, offset, value));
>
> TRACE_EVENT(vde_setup_iram_entry,
> - TP_PROTO(unsigned int table, unsigned int row, u32 value, u32 aux_addr),
> - TP_ARGS(table, row, value, aux_addr),
> - TP_STRUCT__entry(
> - __field(unsigned int, table)
> - __field(unsigned int, row)
> - __field(u32, value)
> - __field(u32, aux_addr)
> - ),
> - TP_fast_assign(
> - __entry->table = table;
> - __entry->row = row;
> - __entry->value = value;
> - __entry->aux_addr = aux_addr;
> - ),
> - TP_printk("[%u][%u] = { 0x%08x (flags = \"%s\", frame_num = %u); 0x%08x }",
> - __entry->table, __entry->row, __entry->value,
> - __print_flags(__entry->value, " ", { (1 << 25), "B" }),
> - __entry->value & 0x7FFFFF, __entry->aux_addr)
> + TP_PROTO(unsigned int table, unsigned int row, u32 value, u32 aux_addr),
> + TP_ARGS(table, row, value, aux_addr),
> + TP_STRUCT__entry(__field(unsigned int, table)
> + __field(unsigned int, row)
> + __field(u32, value)
> + __field(u32, aux_addr)
> + ),
> + TP_fast_assign(__entry->table = table;
> + __entry->row = row;
> + __entry->value = value;
> + __entry->aux_addr = aux_addr;
> + ),
> + TP_printk("[%u][%u] = { 0x%08x (flags = \"%s\", frame_num = %u); 0x%08x }",
> + __entry->table, __entry->row, __entry->value,
> + __print_flags(__entry->value, " ", { (1 << 25), "B" }),
> + __entry->value & 0x7FFFFF, __entry->aux_addr)
> );
>
> TRACE_EVENT(vde_ref_l0,
> - TP_PROTO(unsigned int frame_num),
> - TP_ARGS(frame_num),
> - TP_STRUCT__entry(
> - __field(unsigned int, frame_num)
> - ),
> - TP_fast_assign(
> - __entry->frame_num = frame_num;
> - ),
> - TP_printk("REF L0: DPB: Frame 0: frame_num = %u", __entry->frame_num)
> + TP_PROTO(unsigned int frame_num),
> + TP_ARGS(frame_num),
> + TP_STRUCT__entry(__field(unsigned int, frame_num)),
> + TP_fast_assign(__entry->frame_num = frame_num;),
> + TP_printk("REF L0: DPB: Frame 0: frame_num = %u", __entry->frame_num)
> );
>
> TRACE_EVENT(vde_ref_l1,
> - TP_PROTO(unsigned int with_later_poc_nb,
> - unsigned int with_earlier_poc_nb),
> - TP_ARGS(with_later_poc_nb, with_earlier_poc_nb),
> - TP_STRUCT__entry(
> - __field(unsigned int, with_later_poc_nb)
> - __field(unsigned int, with_earlier_poc_nb)
> - ),
> - TP_fast_assign(
> - __entry->with_later_poc_nb = with_later_poc_nb;
> - __entry->with_earlier_poc_nb = with_earlier_poc_nb;
> - ),
> - TP_printk("REF L1: with_later_poc_nb %u, with_earlier_poc_nb %u",
> - __entry->with_later_poc_nb, __entry->with_earlier_poc_nb)
> + TP_PROTO(unsigned int with_later_poc_nb,
> + unsigned int with_earlier_poc_nb),
> + TP_ARGS(with_later_poc_nb, with_earlier_poc_nb),
> + TP_STRUCT__entry(__field(unsigned int, with_later_poc_nb)
> + __field(unsigned int, with_earlier_poc_nb)),
> + TP_fast_assign(__entry->with_later_poc_nb = with_later_poc_nb;
> + __entry->with_earlier_poc_nb = with_earlier_poc_nb;),
> + TP_printk("REF L1: with_later_poc_nb %u, with_earlier_poc_nb %u",
> + __entry->with_later_poc_nb, __entry->with_earlier_poc_nb)
> );
>
> #endif /* TEGRA_VDE_TRACE_H */
>
prev parent reply other threads:[~2021-04-13 15:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-12 22:20 [PATCH] staging: media: tegra-vde: Align line break to match with the open parenthesis in file trace.h Aline Santana Cordeiro
2021-04-13 15:30 ` Thierry Reding
2021-04-13 16:05 ` Dwaipayan Ray
2021-04-13 16:05 ` Dwaipayan Ray
2021-04-13 17:43 ` Joe Perches
2021-04-13 17:43 ` Joe Perches
2021-04-13 17:43 ` Joe Perches
2021-04-13 15:38 ` Hans Verkuil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e67a6e9-b400-7447-2cd7-6b60230882d0@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=alinesantanacordeiro@gmail.com \
--cc=digetx@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=outreachy-kernel@googlegroups.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.