All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pawel Baldysiak <pawel.baldysiak@intel.com>
To: Shaohua Li <shli@kernel.org>
Cc: linux-raid@vger.kernel.org
Subject: Re: [PATCH 0/2] md: Add support for Multiple PPLs
Date: Mon, 21 Aug 2017 16:54:21 +0200	[thread overview]
Message-ID: <4e72946d-3bdc-8a69-0b44-591570aae3a2@intel.com> (raw)
In-Reply-To: <20170817180331.baxoqhgbqi5q6fvx@kernel.org>



On 08/17/2017 08:03 PM, Shaohua Li wrote:
> On Wed, Aug 16, 2017 at 05:13:44PM +0200, Pawel Baldysiak wrote:
>> Current Partial Parity Log implementation allows only single PPL to be
>> written to particular member drive. In such case PPL entry is
>> overwritten by every write as it's stored at the same sector of a drive.
>> Such approach is suboptimal for SSD drives as it leads to increased
>> write amplification factor due to write-after-write limitations.
>>
>> This patchset changes the implementation by extending PPL area to 1MB.
>> PPL is not stored at fixed location but multiple PPLs are written in a
>> circular buffer. There is at most one valid PPL at any time (latest
>> one). Recovery algorithm stays the same. The main benefits of this
>> approach are increased drive lifespan and in some cases improved
>> performance.
> 
> The patches look good. Is this in intel RST standard?

Hello,
Yes, this is a part of upcoming RSTe version.

> 
> I didn't get the point why this is helpful though. You mentioned reduce write
> amplification. Why does this reduce write amplification? As far as I know, SSD
> never does in-place write, write to the same sector or different sector has no
> difference.

Well, it depends on SSD drive and firmware implementation.

Thanks,
Pawel

  reply	other threads:[~2017-08-21 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-16 15:13 [PATCH 0/2] md: Add support for Multiple PPLs Pawel Baldysiak
2017-08-16 15:13 ` [PATCH 1/2] md: Runtime support for multiple ppls Pawel Baldysiak
2017-08-16 15:13 ` [PATCH 2/2] raid5-ppl: Recovery support for multiple partial parity logs Pawel Baldysiak
2017-08-17 18:03 ` [PATCH 0/2] md: Add support for Multiple PPLs Shaohua Li
2017-08-21 14:54   ` Pawel Baldysiak [this message]
2017-08-21 16:14     ` Shaohua Li
2017-08-25 20:02       ` Pawel Baldysiak
2017-08-25 21:53         ` Shaohua Li
2017-08-28  7:44           ` Artur Paszkiewicz
2017-08-28 14:54             ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4e72946d-3bdc-8a69-0b44-591570aae3a2@intel.com \
    --to=pawel.baldysiak@intel.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=shli@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.