Re: [PATCH 20/20] can: flexcan: add lx2160ar1 support

From: Michael Walle <michael@walle.cc>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-can@vger.kernel.org, kernel@pengutronix.de,
	qiangqing.zhang@nxp.com
Subject: Re: [PATCH 20/20] can: flexcan: add lx2160ar1 support
Date: Wed, 23 Sep 2020 09:45:25 +0200	[thread overview]
Message-ID: <4ffe89fbb4c91a9587622862c3509180@walle.cc> (raw)
In-Reply-To: <20200922144429.2613631-21-mkl@pengutronix.de>

Hi Joakim, Hi Marc,

Am 2020-09-22 16:44, schrieb Marc Kleine-Budde:
> From: Joakim Zhang <qiangqing.zhang@nxp.com>
> 
> The Flexcan on lx2160ar1 supports CAN FD protocol.
> 
> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> Link: 
> https://lore.kernel.org/r/20190712075926.7357-9-qiangqing.zhang@nxp.com
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
> ---
>  drivers/net/can/flexcan.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c
> index 5f778c961a0c..e86925134009 100644
> --- a/drivers/net/can/flexcan.c
> +++ b/drivers/net/can/flexcan.c
> @@ -216,6 +216,7 @@
>   *   MX8QM FlexCAN3  03.00.23.00    yes       yes        no       no
>      yes          yes
>   *   VF610 FlexCAN3  ?               no       yes        no      yes
>      yes?          no
>   * LS1021A FlexCAN2  03.00.04.00     no       yes        no       no
>      yes           no
> + * LX2160A FlexCAN3  03.00.23.00     no       yes        no       no
>      yes          yes

I'd really like to see LS1028A support. At the moment, I'm having the
following additional patch for the ls1028a device tree.

can0: can@2180000 {
     compatible = "fsl,ls1028ar1-flexcan", "fsl,lx2160ar1-flexcan";
     reg = <0x0 0x2180000 0x0 0x10000>;
     interrupts = <GIC_SPI 21 IRQ_TYPE_LEVEL_HIGH>;
                   clocks = <&sysclk>, <&clockgen 4 1>;
                   clock-names = "ipg", "per";
                   status = "disabled";
};

Do we need to add a dedicated compatible entry for the LS1028A
the driver?

-michael