From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from zju.edu.cn (spam.zju.edu.cn [61.164.42.155]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 876216D13 for ; Fri, 9 Apr 2021 08:00:08 +0000 (UTC) Received: by ajax-webmail-mail-app3 (Coremail) ; Fri, 9 Apr 2021 15:59:53 +0800 (GMT+08:00) X-Originating-IP: [222.205.72.8] Date: Fri, 9 Apr 2021 15:59:53 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: dinghao.liu@zju.edu.cn To: "Rui Miguel Silva" Cc: kjlu@umn.edu, "Steve Longerbeam" , "Philipp Zabel" , "Mauro Carvalho Chehab" , "Greg Kroah-Hartman" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH] media: imx: imx7-mipi-csis: Fix runtime PM imbalance in mipi_csis_s_stream X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20210104(ab8c30b6) Copyright (c) 2002-2021 www.mailtech.cn zju.edu.cn In-Reply-To: <20210408135702.f7ikjvwirvtzsarv@arch-thunder.localdomain> References: <20210408090827.32612-1-dinghao.liu@zju.edu.cn> <20210408135702.f7ikjvwirvtzsarv@arch-thunder.localdomain> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-ID: <5025467a.453b6.178b5a50321.Coremail.dinghao.liu@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID:cC_KCgC3nz55CXBgg0vxAA--.30249W X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgkKBlZdtTUlDwABsn X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= PiBIaSBMaXUsCj4gVGhhbmtzIGZvciB5b3VyIHBhdGNoLgo+IAo+IE9uIFRodSwgQXByIDA4LCAy MDIxIGF0IDA1OjA4OjI3UE0gKzA4MDAsIERpbmdoYW8gTGl1IHdyb3RlOgo+ID4gV2hlbiB2NGwy X3N1YmRldl9jYWxsKCkgZmFpbHMsIGEgcGFpcmluZyBQTSB1c2FnZSBjb3VudGVyCj4gPiBkZWNy ZW1lbnQgaXMgbmVlZGVkIHRvIGtlZXAgdGhlIGNvdW50ZXIgYmFsYW5jZWQuIEl0J3MgdGhlCj4g PiBzYW1lIGZvciB0aGUgZm9sbG93aW5nIGVycm9yIHBhdGhzIGluIGNhc2UgJ2VuYWJsZScgaXMg b24uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IERpbmdoYW8gTGl1IDxkaW5naGFvLmxpdUB6anUu ZWR1LmNuPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9zdGFnaW5nL21lZGlhL2lteC9pbXg3LW1pcGkt Y3Npcy5jIHwgOSArKysrKysrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL21l ZGlhL2lteC9pbXg3LW1pcGktY3Npcy5jIGIvZHJpdmVycy9zdGFnaW5nL21lZGlhL2lteC9pbXg3 LW1pcGktY3Npcy5jCj4gPiBpbmRleCBhMDFhNzM2NGI0YjkuLjJhM2ZmZjIzMWE0MCAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9pbXgvaW14Ny1taXBpLWNzaXMuYwo+ID4g KysrIGIvZHJpdmVycy9zdGFnaW5nL21lZGlhL2lteC9pbXg3LW1pcGktY3Npcy5jCj4gPiBAQCAt NjI3LDIxICs2MjcsMjYgQEAgc3RhdGljIGludCBtaXBpX2NzaXNfc19zdHJlYW0oc3RydWN0IHY0 bDJfc3ViZGV2ICptaXBpX3NkLCBpbnQgZW5hYmxlKQo+ID4gIAkJCXJldHVybiByZXQ7Cj4gPiAg CQl9Cj4gPiAgCQlyZXQgPSB2NGwyX3N1YmRldl9jYWxsKHN0YXRlLT5zcmNfc2QsIGNvcmUsIHNf cG93ZXIsIDEpOwo+ID4gLQkJaWYgKHJldCA8IDApCj4gPiArCQlpZiAocmV0IDwgMCkgewo+ID4g KwkJCXBtX3J1bnRpbWVfcHV0X25vaWRsZSgmc3RhdGUtPnBkZXYtPmRldik7Cj4gCj4gSSB0aGlu ayBoZXJlIHdlIHNob3VsZCBnbyBjb21wbGV0ZWx5IHBtX3J1bnRpbWVfcHV0IHRvIGNhbGwgdGhl Cj4gbWlwaV9jc2lzX3BtX3N1c3BlbmQgZG93biB0aGUgbGluZSwgcmlnaHQ/Cj4gCj4gPiAgCQkJ cmV0dXJuIHJldDsKPiA+ICsJCX0KPiA+ICAJfQo+ID4gIAo+ID4gIAltdXRleF9sb2NrKCZzdGF0 ZS0+bG9jayk7Cj4gPiAgCWlmIChlbmFibGUpIHsKPiA+ICAJCWlmIChzdGF0ZS0+ZmxhZ3MgJiBT VF9TVVNQRU5ERUQpIHsKPiA+ICAJCQlyZXQgPSAtRUJVU1k7Cj4gPiArCQkJcG1fcnVudGltZV9w dXRfbm9pZGxlKCZzdGF0ZS0+cGRldi0+ZGV2KTsKPiAKPiBzaW5jZSB3ZSBhcmUgaW4gU1RfU1VT UEVOREVEIHN0YXRlLCBmb3Igc3VyZSB0aGUgcG0gY291bnRlciB3YXMKPiBhbHJlYWR5IDAuCj4g Cj4gPiAgCQkJZ290byB1bmxvY2s7Cj4gPiAgCQl9Cj4gPiAgCj4gPiAgCQltaXBpX2NzaXNfc3Rh cnRfc3RyZWFtKHN0YXRlKTsKPiA+ICAJCXJldCA9IHY0bDJfc3ViZGV2X2NhbGwoc3RhdGUtPnNy Y19zZCwgdmlkZW8sIHNfc3RyZWFtLCAxKTsKPiA+IC0JCWlmIChyZXQgPCAwKQo+ID4gKwkJaWYg KHJldCA8IDApIHsKPiA+ICsJCQlwbV9ydW50aW1lX3B1dF9ub2lkbGUoJnN0YXRlLT5wZGV2LT5k ZXYpOwo+IAo+IGhlcmUgYWxzbyB3ZSBuZWVkIHRoZSBwbV9ydW50aW1lX3B1dCwgbWF5YmUganVz dCBjaGFuZ2luZyB0aGUgdW5sb2NrCj4gdGFnIGJlbGxvdyBmcm9tOgo+ICAgICBpZiAoIWVuYWJs ZSkKPiAgICAgICAgIHBtX3J1bnRpbWVfcHV0KCZzdGF0ZS0+cGRldi0+ZGV2KTsKPiAKPiB0byAK PiAgICAgaWYgKCFlbmFibGUgfHwgKHJldCA8IDApKQo+ICAgICAgICAgcG1fcnVudGltZV9wdXQo JnN0YXRlLT5wZGV2LT5kZXYpOwo+IAo+IHdpbGwgbm90IGh1cnQgdGhlIGZpcnN0IGNhc2UgYW5k IHdpbGwgY29tcGxldGUgdGhlIHN1c3BlbmQgcm91dGluZQo+IGFmdGVyd2FyZCBpbiB0aGUgc2Vj b25kIGNhc2UuCj4gCgpUaGlzIGlzIG11Y2ggY2xlYXJlciwgdGhhbmtzISBJIHdpbGwgZml4IHRo aXMgYW5kIHNlbmQgYSBuZXcgcGF0Y2ggc29vbi4KClJlZ2FyZHMsCkRpbmdoYW8= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD7FFC433ED for ; Fri, 9 Apr 2021 08:00:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9F849611BE for ; Fri, 9 Apr 2021 08:00:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232018AbhDIIA0 (ORCPT ); Fri, 9 Apr 2021 04:00:26 -0400 Received: from spam.zju.edu.cn ([61.164.42.155]:62422 "EHLO zju.edu.cn" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229621AbhDIIAY (ORCPT ); Fri, 9 Apr 2021 04:00:24 -0400 Received: by ajax-webmail-mail-app3 (Coremail) ; Fri, 9 Apr 2021 15:59:53 +0800 (GMT+08:00) X-Originating-IP: [222.205.72.8] Date: Fri, 9 Apr 2021 15:59:53 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: dinghao.liu@zju.edu.cn To: "Rui Miguel Silva" Cc: kjlu@umn.edu, "Steve Longerbeam" , "Philipp Zabel" , "Mauro Carvalho Chehab" , "Greg Kroah-Hartman" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH] media: imx: imx7-mipi-csis: Fix runtime PM imbalance in mipi_csis_s_stream X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20210104(ab8c30b6) Copyright (c) 2002-2021 www.mailtech.cn zju.edu.cn In-Reply-To: <20210408135702.f7ikjvwirvtzsarv@arch-thunder.localdomain> References: <20210408090827.32612-1-dinghao.liu@zju.edu.cn> <20210408135702.f7ikjvwirvtzsarv@arch-thunder.localdomain> Content-Transfer-Encoding: base64 Content-Type: text/plain; charset=UTF-8 MIME-Version: 1.0 Message-ID: <5025467a.453b6.178b5a50321.Coremail.dinghao.liu@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: cC_KCgC3nz55CXBgg0vxAA--.30249W X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgkKBlZdtTUlDwABsn X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PiBIaSBMaXUsCj4gVGhhbmtzIGZvciB5b3VyIHBhdGNoLgo+IAo+IE9uIFRodSwgQXByIDA4LCAy MDIxIGF0IDA1OjA4OjI3UE0gKzA4MDAsIERpbmdoYW8gTGl1IHdyb3RlOgo+ID4gV2hlbiB2NGwy X3N1YmRldl9jYWxsKCkgZmFpbHMsIGEgcGFpcmluZyBQTSB1c2FnZSBjb3VudGVyCj4gPiBkZWNy ZW1lbnQgaXMgbmVlZGVkIHRvIGtlZXAgdGhlIGNvdW50ZXIgYmFsYW5jZWQuIEl0J3MgdGhlCj4g PiBzYW1lIGZvciB0aGUgZm9sbG93aW5nIGVycm9yIHBhdGhzIGluIGNhc2UgJ2VuYWJsZScgaXMg b24uCj4gPiAKPiA+IFNpZ25lZC1vZmYtYnk6IERpbmdoYW8gTGl1IDxkaW5naGFvLmxpdUB6anUu ZWR1LmNuPgo+ID4gLS0tCj4gPiAgZHJpdmVycy9zdGFnaW5nL21lZGlhL2lteC9pbXg3LW1pcGkt Y3Npcy5jIHwgOSArKysrKysrLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRpb25zKCsp LCAyIGRlbGV0aW9ucygtKQo+ID4gCj4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL21l ZGlhL2lteC9pbXg3LW1pcGktY3Npcy5jIGIvZHJpdmVycy9zdGFnaW5nL21lZGlhL2lteC9pbXg3 LW1pcGktY3Npcy5jCj4gPiBpbmRleCBhMDFhNzM2NGI0YjkuLjJhM2ZmZjIzMWE0MCAxMDA2NDQK PiA+IC0tLSBhL2RyaXZlcnMvc3RhZ2luZy9tZWRpYS9pbXgvaW14Ny1taXBpLWNzaXMuYwo+ID4g KysrIGIvZHJpdmVycy9zdGFnaW5nL21lZGlhL2lteC9pbXg3LW1pcGktY3Npcy5jCj4gPiBAQCAt NjI3LDIxICs2MjcsMjYgQEAgc3RhdGljIGludCBtaXBpX2NzaXNfc19zdHJlYW0oc3RydWN0IHY0 bDJfc3ViZGV2ICptaXBpX3NkLCBpbnQgZW5hYmxlKQo+ID4gIAkJCXJldHVybiByZXQ7Cj4gPiAg CQl9Cj4gPiAgCQlyZXQgPSB2NGwyX3N1YmRldl9jYWxsKHN0YXRlLT5zcmNfc2QsIGNvcmUsIHNf cG93ZXIsIDEpOwo+ID4gLQkJaWYgKHJldCA8IDApCj4gPiArCQlpZiAocmV0IDwgMCkgewo+ID4g KwkJCXBtX3J1bnRpbWVfcHV0X25vaWRsZSgmc3RhdGUtPnBkZXYtPmRldik7Cj4gCj4gSSB0aGlu ayBoZXJlIHdlIHNob3VsZCBnbyBjb21wbGV0ZWx5IHBtX3J1bnRpbWVfcHV0IHRvIGNhbGwgdGhl Cj4gbWlwaV9jc2lzX3BtX3N1c3BlbmQgZG93biB0aGUgbGluZSwgcmlnaHQ/Cj4gCj4gPiAgCQkJ cmV0dXJuIHJldDsKPiA+ICsJCX0KPiA+ICAJfQo+ID4gIAo+ID4gIAltdXRleF9sb2NrKCZzdGF0 ZS0+bG9jayk7Cj4gPiAgCWlmIChlbmFibGUpIHsKPiA+ICAJCWlmIChzdGF0ZS0+ZmxhZ3MgJiBT VF9TVVNQRU5ERUQpIHsKPiA+ICAJCQlyZXQgPSAtRUJVU1k7Cj4gPiArCQkJcG1fcnVudGltZV9w dXRfbm9pZGxlKCZzdGF0ZS0+cGRldi0+ZGV2KTsKPiAKPiBzaW5jZSB3ZSBhcmUgaW4gU1RfU1VT UEVOREVEIHN0YXRlLCBmb3Igc3VyZSB0aGUgcG0gY291bnRlciB3YXMKPiBhbHJlYWR5IDAuCj4g Cj4gPiAgCQkJZ290byB1bmxvY2s7Cj4gPiAgCQl9Cj4gPiAgCj4gPiAgCQltaXBpX2NzaXNfc3Rh cnRfc3RyZWFtKHN0YXRlKTsKPiA+ICAJCXJldCA9IHY0bDJfc3ViZGV2X2NhbGwoc3RhdGUtPnNy Y19zZCwgdmlkZW8sIHNfc3RyZWFtLCAxKTsKPiA+IC0JCWlmIChyZXQgPCAwKQo+ID4gKwkJaWYg KHJldCA8IDApIHsKPiA+ICsJCQlwbV9ydW50aW1lX3B1dF9ub2lkbGUoJnN0YXRlLT5wZGV2LT5k ZXYpOwo+IAo+IGhlcmUgYWxzbyB3ZSBuZWVkIHRoZSBwbV9ydW50aW1lX3B1dCwgbWF5YmUganVz dCBjaGFuZ2luZyB0aGUgdW5sb2NrCj4gdGFnIGJlbGxvdyBmcm9tOgo+ICAgICBpZiAoIWVuYWJs ZSkKPiAgICAgICAgIHBtX3J1bnRpbWVfcHV0KCZzdGF0ZS0+cGRldi0+ZGV2KTsKPiAKPiB0byAK PiAgICAgaWYgKCFlbmFibGUgfHwgKHJldCA8IDApKQo+ICAgICAgICAgcG1fcnVudGltZV9wdXQo JnN0YXRlLT5wZGV2LT5kZXYpOwo+IAo+IHdpbGwgbm90IGh1cnQgdGhlIGZpcnN0IGNhc2UgYW5k IHdpbGwgY29tcGxldGUgdGhlIHN1c3BlbmQgcm91dGluZQo+IGFmdGVyd2FyZCBpbiB0aGUgc2Vj b25kIGNhc2UuCj4gCgpUaGlzIGlzIG11Y2ggY2xlYXJlciwgdGhhbmtzISBJIHdpbGwgZml4IHRo aXMgYW5kIHNlbmQgYSBuZXcgcGF0Y2ggc29vbi4KClJlZ2FyZHMsCkRpbmdoYW8= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F00C433ED for ; Fri, 9 Apr 2021 08:06:09 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B775461182 for ; Fri, 9 Apr 2021 08:06:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B775461182 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=zju.edu.cn Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:MIME-Version:References:In-Reply-To: Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=bleCQTf08nBKwJVDEgbNm6HYkmX5IjSS4VvGf7PK2mA=; b=qoNP1f5IhIWvMsMPFM8dz82+f 7QnRGj0LrbqVkrMLSg/EycltCHM4ztXbIYrYr4P8+iqeqU7XvhRAIlwE73Z3rkrZ2tKWOSeXCo82K d2qVoxU+9z1uEdvmJCwWd8ZxH67cceM7LGJFF9wMUD0KtfWKTS4kEoFeW7kZDjbmXYsify2B6g4wC 1ahQzg5cMqJaPHKj30RcUVEUAdMzg1AwibGXKvrPcRMZYqfQ/qm28dpUqttV0aeS+C55v/AjpVOMJ ltNB4MbH9HptFvBF1+2+LYHt3Im33J+Y6JJaTEBa+/HlboxDirWeuT7y18AXy2bO2YrR82XAvMZ5p EX8nDZXuA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUm4c-00AXIQ-6q; Fri, 09 Apr 2021 08:01:02 +0000 Received: from spam.zju.edu.cn ([61.164.42.155] helo=zju.edu.cn) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lUm3a-00AX2K-Ud for linux-arm-kernel@lists.infradead.org; Fri, 09 Apr 2021 08:00:02 +0000 Received: by ajax-webmail-mail-app3 (Coremail) ; Fri, 9 Apr 2021 15:59:53 +0800 (GMT+08:00) X-Originating-IP: [222.205.72.8] Date: Fri, 9 Apr 2021 15:59:53 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: dinghao.liu@zju.edu.cn To: "Rui Miguel Silva" Cc: kjlu@umn.edu, "Steve Longerbeam" , "Philipp Zabel" , "Mauro Carvalho Chehab" , "Greg Kroah-Hartman" , "Shawn Guo" , "Sascha Hauer" , "Pengutronix Kernel Team" , "Fabio Estevam" , "NXP Linux Team" , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH] media: imx: imx7-mipi-csis: Fix runtime PM imbalance in mipi_csis_s_stream X-Priority: 3 X-Mailer: Coremail Webmail Server Version XT5.0.13 build 20210104(ab8c30b6) Copyright (c) 2002-2021 www.mailtech.cn zju.edu.cn In-Reply-To: <20210408135702.f7ikjvwirvtzsarv@arch-thunder.localdomain> References: <20210408090827.32612-1-dinghao.liu@zju.edu.cn> <20210408135702.f7ikjvwirvtzsarv@arch-thunder.localdomain> MIME-Version: 1.0 Message-ID: <5025467a.453b6.178b5a50321.Coremail.dinghao.liu@zju.edu.cn> X-Coremail-Locale: zh_CN X-CM-TRANSID: cC_KCgC3nz55CXBgg0vxAA--.30249W X-CM-SenderInfo: qrrzjiaqtzq6lmxovvfxof0/1tbiAgkKBlZdtTUlDwABsn X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210409_085959_581399_0DD163CF X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Hi Liu, > Thanks for your patch. > > On Thu, Apr 08, 2021 at 05:08:27PM +0800, Dinghao Liu wrote: > > When v4l2_subdev_call() fails, a pairing PM usage counter > > decrement is needed to keep the counter balanced. It's the > > same for the following error paths in case 'enable' is on. > > > > Signed-off-by: Dinghao Liu > > --- > > drivers/staging/media/imx/imx7-mipi-csis.c | 9 +++++++-- > > 1 file changed, 7 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/media/imx/imx7-mipi-csis.c b/drivers/staging/media/imx/imx7-mipi-csis.c > > index a01a7364b4b9..2a3fff231a40 100644 > > --- a/drivers/staging/media/imx/imx7-mipi-csis.c > > +++ b/drivers/staging/media/imx/imx7-mipi-csis.c > > @@ -627,21 +627,26 @@ static int mipi_csis_s_stream(struct v4l2_subdev *mipi_sd, int enable) > > return ret; > > } > > ret = v4l2_subdev_call(state->src_sd, core, s_power, 1); > > - if (ret < 0) > > + if (ret < 0) { > > + pm_runtime_put_noidle(&state->pdev->dev); > > I think here we should go completely pm_runtime_put to call the > mipi_csis_pm_suspend down the line, right? > > > return ret; > > + } > > } > > > > mutex_lock(&state->lock); > > if (enable) { > > if (state->flags & ST_SUSPENDED) { > > ret = -EBUSY; > > + pm_runtime_put_noidle(&state->pdev->dev); > > since we are in ST_SUSPENDED state, for sure the pm counter was > already 0. > > > goto unlock; > > } > > > > mipi_csis_start_stream(state); > > ret = v4l2_subdev_call(state->src_sd, video, s_stream, 1); > > - if (ret < 0) > > + if (ret < 0) { > > + pm_runtime_put_noidle(&state->pdev->dev); > > here also we need the pm_runtime_put, maybe just changing the unlock > tag bellow from: > if (!enable) > pm_runtime_put(&state->pdev->dev); > > to > if (!enable || (ret < 0)) > pm_runtime_put(&state->pdev->dev); > > will not hurt the first case and will complete the suspend routine > afterward in the second case. > This is much clearer, thanks! I will fix this and send a new patch soon. Regards, Dinghao _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel