From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [RFC v2 14/18] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs Date: Wed, 9 Jan 2013 15:23:05 +0530 Message-ID: <50ED3E01.9010400@ti.com> References: <1356959231-17335-1-git-send-email-vaibhav.bedia@ti.com> <1356959231-17335-15-git-send-email-vaibhav.bedia@ti.com> <50EC3964.3060708@ti.com> <50ED1CB7.1090202@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from arroyo.ext.ti.com ([192.94.94.40]:55381 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757422Ab3AIJwQ (ORCPT ); Wed, 9 Jan 2013 04:52:16 -0500 In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Bedia, Vaibhav" Cc: "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "tony@atomide.com" , "khilman@deeprootsystems.com" , "Cousson, Benoit" , Paul Walmsley , "Hiremath, Vaibhav" On Wednesday 09 January 2013 03:07 PM, Bedia, Vaibhav wrote: > On Wed, Jan 09, 2013 at 13:01:03, Shilimkar, Santosh wrote: >> On Wednesday 09 January 2013 11:08 AM, Bedia, Vaibhav wrote: >>> On Tue, Jan 08, 2013 at 20:51:08, Shilimkar, Santosh wrote: >>>> On Monday 31 December 2012 06:37 PM, Vaibhav Bedia wrote: >>>>> Add minimal APIs for writing to the IPC and the M3_TXEV registers >>>>> in the Control module. These will be used in a subsequent patch which >>>>> adds suspend-resume support for AM33XX. >>>>> >>>>> Signed-off-by: Vaibhav Bedia >>>>> Cc: Tony Lingren >>>>> Cc: Santosh Shilimkar >>>>> Cc: Benoit Cousson >>>>> Cc: Paul Walmsley >>>>> Cc: Kevin Hilman >>>>> Cc: Vaibhav Hiremath >>>>> --- >>>> On Control module, we are trying to move driver/module >>>> specific code to respective drivers. Can you not >>>> add below code to ipc related driver component. >>>> >>>> If not, then patch as such is fine with me. >>>> >>> >>> I had it in the pm33xx.c in the previous version. Kevin had asked me to >>> move it to control.c. Should I revert move it back there? >>> >> pm33xx.c is not the right place. I was hoping to move to some driver. >> If that is not possible then leave it in control module. >> > > I think I'll leave it here for now. Could I have you ack in that case? > Yep. Acked-by: Santosh Shilimkar From mboxrd@z Thu Jan 1 00:00:00 1970 From: santosh.shilimkar@ti.com (Santosh Shilimkar) Date: Wed, 9 Jan 2013 15:23:05 +0530 Subject: [RFC v2 14/18] ARM: OMAP2+: AM33XX: control: Add some control module registers and APIs In-Reply-To: References: <1356959231-17335-1-git-send-email-vaibhav.bedia@ti.com> <1356959231-17335-15-git-send-email-vaibhav.bedia@ti.com> <50EC3964.3060708@ti.com> <50ED1CB7.1090202@ti.com> Message-ID: <50ED3E01.9010400@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wednesday 09 January 2013 03:07 PM, Bedia, Vaibhav wrote: > On Wed, Jan 09, 2013 at 13:01:03, Shilimkar, Santosh wrote: >> On Wednesday 09 January 2013 11:08 AM, Bedia, Vaibhav wrote: >>> On Tue, Jan 08, 2013 at 20:51:08, Shilimkar, Santosh wrote: >>>> On Monday 31 December 2012 06:37 PM, Vaibhav Bedia wrote: >>>>> Add minimal APIs for writing to the IPC and the M3_TXEV registers >>>>> in the Control module. These will be used in a subsequent patch which >>>>> adds suspend-resume support for AM33XX. >>>>> >>>>> Signed-off-by: Vaibhav Bedia >>>>> Cc: Tony Lingren >>>>> Cc: Santosh Shilimkar >>>>> Cc: Benoit Cousson >>>>> Cc: Paul Walmsley >>>>> Cc: Kevin Hilman >>>>> Cc: Vaibhav Hiremath >>>>> --- >>>> On Control module, we are trying to move driver/module >>>> specific code to respective drivers. Can you not >>>> add below code to ipc related driver component. >>>> >>>> If not, then patch as such is fine with me. >>>> >>> >>> I had it in the pm33xx.c in the previous version. Kevin had asked me to >>> move it to control.c. Should I revert move it back there? >>> >> pm33xx.c is not the right place. I was hoping to move to some driver. >> If that is not possible then leave it in control module. >> > > I think I'll leave it here for now. Could I have you ack in that case? > Yep. Acked-by: Santosh Shilimkar